Re: [PATCH v2 03/11] dt-bindings: pinctrl: sun4i-a10: add Allwinner B288

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: pinctrl: sunxi: missing b288 interrupts constraint validation
--

commit 5d0ff1f67ca22e7e0aeb81a6bb9183820225e5b3
Author: Pablo Mazzini <pmazzini@gmail.com>

dt-bindings: pinctrl: sun4i-a10: add Allwinner B288

The B288 driver takes its mux values from the DT, so allwinner,pinmux
becomes an allowed property here, required for this compatible only.

> diff --git a/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml
> index 45b7a0b6c626d..6fe3b64107349 100644
> --- a/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml
> @@ -39,6 +39,7 @@ properties:
>        - allwinner,sun8i-a33-pinctrl
>        - allwinner,sun8i-a83t-pinctrl
>        - allwinner,sun8i-a83t-r-pinctrl
> +      - allwinner,sun8i-b288-pinctrl

[Severity: Medium]
Since this compatible is for hardware with exactly 4 interrupt banks, shouldn't
it also be added to the later allOf constraints block in this file that
enforces exact hardware limits for interrupts?

For example:

  - if:
      properties:
        compatible:
          enum:
            - allwinner,sun6i-a31-pinctrl
            - allwinner,sun6i-a31s-pinctrl
            - allwinner,sun50i-h6-pinctrl
            - allwinner,sun8i-b288-pinctrl
    then:
      properties:
        interrupts:
          minItems: 4
          maxItems: 4

Without this, validation for this variant falls back to the broad global default
of 1 to 8 interrupts.

Does this allow a device tree with an incorrect number of interrupts for the
B288 to silently pass validation?

>        - allwinner,sun8i-h3-pinctrl
>        - allwinner,sun8i-h3-r-pinctrl
>        - allwinner,sun8i-r40-pinctrl

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260927151016.186493-1-pmazzini@gmail.com?part=3