Re: [PATCH 1/2] arm64: dts: ti: k3-am62l-main: Add ADC nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dts: k3-am62l: tscadc0 reg exceeds parent cbass_main ranges
--

commit 06bc07c12d27dc31a3a3ae1cf4ef12f047b8b0e7
Author: Judith Mendez <jm@ti.com>

arm64: dts: ti: k3-am62l-main: Add ADC nodes

AM62L has an ADC in main domain, add ADC node in the respective
voltage domain file.

> diff --git a/arch/arm64/boot/dts/ti/k3-am62l-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62l-main.dtsi
> index 80615ca1e01a2..70157981aba5d 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62l-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62l-main.dtsi
[ ... ]
> +	tscadc0: tscadc@28001000 {
> +		compatible = "ti,am654-tscadc", "ti,am3359-tscadc";
> +		reg = <0x00 0x28001000 0x00 0x1000>;

[Severity: Low]
Does this reg size exceed the parent cbass_main ranges?

In arch/arm64/boot/dts/ti/k3-am62l.dtsi, the parent cbass_main bus defines
the Second Peripheral Window ending at 0x28001400 (0x0e000000 + 0x1a001400):

	<0x00 0x0e000000 0x00 0x0e000000 0x00 0x1a001400>, /* Second Peripheral Window */

The tscadc0 node's reg size of 0x1000 bytes starting at 0x28001000 extends
up to 0x28002000, which exceeds the parent window by 0xC00 bytes. This causes
a device tree schema and dtc validation warning when building the dtbs.

While devm_ioremap_resource() still maps the full 0x1000 bytes, and the driver
only accesses registers up to 0x200 (well within the valid 0x400-byte window),
should the reg size or the parent range be adjusted to avoid the validation
warnings?

> +		interrupts = <GIC_SPI 253 IRQ_TYPE_LEVEL_HIGH>;
> +		power-domains = <&scmi_pds 0>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260928034115.1084840-1-s-adivi@ti.com?part=1