Re: [PATCH 1/3] dt-bindings: embedded-controller: qcom,hamoa-crd-ec: Add thermal sensors

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: qcom,hamoa-crd-ec: unconditional schema ref breaks dtbs_check
--

commit ee4c510364f0a8d45223544f87706874323cd5cb
Author: Anvesh Jain P <anvesh.p@oss.qualcomm.com>
Date:   Mon Sep 28 06:36:37 2026 +0000

    dt-bindings: embedded-controller: qcom,hamoa-crd-ec: Add thermal sensors

This commit updates the Hamoa embedded controller bindings to act as a
thermal-sensor provider. It introduces a thermal-sensor schema reference and 
defines the #thermal-sensor-cells property.

> diff --git a/Documentation/devicetree/bindings/embedded-controller/qcom,hamoa-crd-ec.yaml b/Documentation/devicetree/bindings/embedded-controller/qcom,hamoa-crd-ec.yaml
> index ac5a08f8f76df..13de6bed81297 100644
> --- a/Documentation/devicetree/bindings/embedded-controller/qcom,hamoa-crd-ec.yaml
> +++ b/Documentation/devicetree/bindings/embedded-controller/qcom,hamoa-crd-ec.yaml
> @@ -15,6 +15,9 @@ description:
>    EC running on different MCU chips. The EC handles things like fan control,
>    temperature sensors, access to EC internal state changes.
>  
> +allOf:
> +  - $ref: /schemas/thermal/thermal-sensor.yaml#
> +

[Severity: Medium]
Will this unconditional reference break schema validation for existing device 
trees? 

The thermal-sensor.yaml schema enforces the #thermal-sensor-cells property, 
but existing in-tree device trees (arch/arm64/boot/dts/qcom/x1-crd.dtsi and 
arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts) use the qcom,hamoa-crd-ec 
compatible without specifying #thermal-sensor-cells:

	embedded-controller@76 {
		compatible = "qcom,hamoa-crd-ec";
		reg = <0x76>;

		interrupts-extended = <&tlmm 66 IRQ_TYPE_EDGE_FALLING>;

Does this patch series need to add the property to those existing users, or 
should the $ref be made conditional to preserve backwards compatibility?

>  properties:
>    compatible:
>      oneOf:
[ ... ]
> @@ -32,6 +35,14 @@ properties:
>    interrupts:
>      maxItems: 1
>  
> +  "#thermal-sensor-cells":
> +    description:
> +      The EC exposes up to 7 onboard thermistors (indices 0-6). Which
> +      indices are physically populated on a given board is discovered at
> +      runtime from EC firmware capabilities; a board may reference any index
> +      0-6.
> +    const: 1
> +
>  required:
>    - compatible
>    - reg

[Severity: Medium]
Should #thermal-sensor-cells be added to this explicit required list? 

The subsystem guidelines state that when a variant compatible string adds 
provider capabilities, the corresponding properties must appear in the required 
list with appropriate constraints.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260928-ec_thermistor_support-v1-0-d9c1bae4cd0d@oss.qualcomm.com?part=1