Re: [PATCH 3/3] arm64: dts: qcom: glymur: Add EC thermal zones

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dts: qcom: thermal zone nodes violate thermal-zones schema
--

commit 5002150e61d17adad9a02df5206f78ef229da8ab
Author: Anvesh Jain P <anvesh.p@oss.qualcomm.com>

arm64: dts: qcom: glymur: Add EC thermal zones

This commit adds support for back cover, keyboard, and SoC thermal zones
through temperature sensors hosted on the EC for Glymur and Mahua CRDs.

> diff --git a/arch/arm64/boot/dts/qcom/glymur-crd.dtsi b/arch/arm64/boot/dts/qcom/glymur-crd.dtsi
> index e27c697e31702..571c98124a406 100644
> --- a/arch/arm64/boot/dts/qcom/glymur-crd.dtsi
> +++ b/arch/arm64/boot/dts/qcom/glymur-crd.dtsi
[ ... ]
> @@ -955,6 +957,47 @@ right_tweeter: speaker@0,1 {
>  	};
>  };
>  
> +&thermal_zones {
> +	ec-back-cover {

[Severity: Low]
Does this node name violate the thermal-zones.yaml schema? The schema
requires thermal zone nodes to have a -thermal suffix (matching the regex
^[a-zA-Z][a-zA-Z0-9\-]{1,10}-thermal$).

Additionally, trivially appending -thermal to ec-back-cover yields a
21-character string. The schema limits the prefix to 10 characters, and
the kernel enforces a THERMAL_NAME_LENGTH limit of 20 bytes (including
NUL). Should the prefix be shortened to comply with these limits?

> +		polling-delay = <10000>;
> +		thermal-sensors = <&ec 2>;
> +
> +		trips {
[ ... ]
> +			};
> +		};
> +	};
> +
> +	ec-keyboard {

[Severity: Low]
Does this node name also need the -thermal suffix to pass dtbs_check
validation against the thermal-zones schema?

> +		polling-delay = <10000>;
> +		thermal-sensors = <&ec 1>;
> +
> +		trips {
[ ... ]
> +			};
> +		};
> +	};
> +
> +	ec-soc {

[Severity: Low]
Does this node name also need the -thermal suffix to pass dtbs_check
validation?

> +		polling-delay = <10000>;
> +		thermal-sensors = <&ec 0>;
> +
> +		trips {
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260928-ec_thermistor_support-v1-0-d9c1bae4cd0d@oss.qualcomm.com?part=3