From: Chen Pei <cp0613@linux.alibaba.com>
To: acme@kernel.org, peterz@infradead.org, mingo@redhat.com,
namhyung@kernel.org
Cc: mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com,
james.clark@linaro.org, leo.yan@linux.dev,
john.g.garry@oracle.com, will@kernel.org, mike.leach@arm.com,
pjw@kernel.org, palmer@dabbelt.com, guoren@kernel.org,
linux-perf-users@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH 0/2] perf riscv: Implement rdtsc()
Date: Mon, 28 Sep 2026 17:47:37 +0800 [thread overview]
Message-ID: <20260928094739.2605-1-cp0613@linux.alibaba.com> (raw)
tools/perf falls back to the __weak rdtsc() stub in tools/perf/util/tsc.c
on every architecture that does not override it, riscv included. The
stub returns a constant 0, so anything that reaches for the counter gets
a value that means nothing and cannot tell it apart from a counter that
happens to be at 0.
The time CSR is a natural TSC equivalent on riscv: readable from user
mode, constant frequency, and the same counter that riscv's
arch_perf_update_userpage() feeds the user page conversion fields from,
ever since commit 83c5e13b8cbb ("riscv: Prepare for user-space perf
event mmap support"). This series registers that on the tools side.
The two patches are split so that the first stands on its own:
1. Implement rdtsc() over the time CSR for riscv.
2. Replace the compile-time TSC support check with a weak
arch__rdtsc_supported() hook, so that support is declared next to
the rdtsc() it describes rather than in the central list of compiler
macros.
What this is worth beyond the subtest result:
1. The subtest is the only reader of those conversion fields riscv
can run, so it guards arithmetic that has shipped unexercised;
registering the counter at the same time leaves a future riscv
auxtrace driver the reading and the conversion already in place.
2. The hook gives a caller something to ask the architecture before
it uses the counter value, instead of each caller keeping its own
copy of the macro list.
Tests:
======
- The "Convert perf time to TSC" test in a riscv64 QEMU virt guest
with sscofpmf: the subtest skips before the series, passes after it.
- With the riscv implementation left out of the build, so that the
weak defaults are in effect, the subtest still skips: the behaviour
of an architecture without a counter is unchanged.
Chen Pei (2):
perf riscv: Implement rdtsc()
perf tsc: Replace the compile-time TSC support check with a weak hook
tools/perf/arch/arm64/util/tsc.c | 5 +++++
tools/perf/arch/riscv/util/Build | 1 +
tools/perf/arch/riscv/util/tsc.c | 24 ++++++++++++++++++++++++
tools/perf/arch/x86/util/tsc.c | 5 +++++
tools/perf/tests/perf-time-to-tsc.c | 12 +-----------
tools/perf/util/tsc.c | 9 +++++++++
tools/perf/util/tsc.h | 1 +
7 files changed, 46 insertions(+), 11 deletions(-)
create mode 100644 tools/perf/arch/riscv/util/tsc.c
--
2.50.1
WARNING: multiple messages have this Message-ID (diff)
From: Chen Pei <cp0613@linux.alibaba.com>
To: acme@kernel.org, peterz@infradead.org, mingo@redhat.com,
namhyung@kernel.org
Cc: mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com,
james.clark@linaro.org, leo.yan@linux.dev,
john.g.garry@oracle.com, will@kernel.org, mike.leach@arm.com,
pjw@kernel.org, palmer@dabbelt.com, guoren@kernel.org,
linux-perf-users@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH 0/2] perf riscv: Implement rdtsc()
Date: Mon, 28 Sep 2026 17:47:37 +0800 [thread overview]
Message-ID: <20260928094739.2605-1-cp0613@linux.alibaba.com> (raw)
tools/perf falls back to the __weak rdtsc() stub in tools/perf/util/tsc.c
on every architecture that does not override it, riscv included. The
stub returns a constant 0, so anything that reaches for the counter gets
a value that means nothing and cannot tell it apart from a counter that
happens to be at 0.
The time CSR is a natural TSC equivalent on riscv: readable from user
mode, constant frequency, and the same counter that riscv's
arch_perf_update_userpage() feeds the user page conversion fields from,
ever since commit 83c5e13b8cbb ("riscv: Prepare for user-space perf
event mmap support"). This series registers that on the tools side.
The two patches are split so that the first stands on its own:
1. Implement rdtsc() over the time CSR for riscv.
2. Replace the compile-time TSC support check with a weak
arch__rdtsc_supported() hook, so that support is declared next to
the rdtsc() it describes rather than in the central list of compiler
macros.
What this is worth beyond the subtest result:
1. The subtest is the only reader of those conversion fields riscv
can run, so it guards arithmetic that has shipped unexercised;
registering the counter at the same time leaves a future riscv
auxtrace driver the reading and the conversion already in place.
2. The hook gives a caller something to ask the architecture before
it uses the counter value, instead of each caller keeping its own
copy of the macro list.
Tests:
======
- The "Convert perf time to TSC" test in a riscv64 QEMU virt guest
with sscofpmf: the subtest skips before the series, passes after it.
- With the riscv implementation left out of the build, so that the
weak defaults are in effect, the subtest still skips: the behaviour
of an architecture without a counter is unchanged.
Chen Pei (2):
perf riscv: Implement rdtsc()
perf tsc: Replace the compile-time TSC support check with a weak hook
tools/perf/arch/arm64/util/tsc.c | 5 +++++
tools/perf/arch/riscv/util/Build | 1 +
tools/perf/arch/riscv/util/tsc.c | 24 ++++++++++++++++++++++++
tools/perf/arch/x86/util/tsc.c | 5 +++++
tools/perf/tests/perf-time-to-tsc.c | 12 +-----------
tools/perf/util/tsc.c | 9 +++++++++
tools/perf/util/tsc.h | 1 +
7 files changed, 46 insertions(+), 11 deletions(-)
create mode 100644 tools/perf/arch/riscv/util/tsc.c
--
2.50.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next reply other threads:[~2026-09-28 9:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 9:47 Chen Pei [this message]
2026-09-28 9:47 ` [PATCH 0/2] perf riscv: Implement rdtsc() Chen Pei
2026-09-28 9:47 ` [PATCH 1/2] " Chen Pei
2026-09-28 9:47 ` Chen Pei
2026-09-28 9:54 ` sashiko-bot
2026-09-28 13:42 ` Anup Patel
2026-09-28 13:42 ` Anup Patel
2026-09-28 9:47 ` [PATCH 2/2] perf tsc: Replace the compile-time TSC support check with a weak hook Chen Pei
2026-09-28 9:47 ` Chen Pei
2026-09-28 9:55 ` sashiko-bot
2026-09-28 13:42 ` Anup Patel
2026-09-28 13:42 ` Anup Patel
2026-09-28 16:34 ` Leo Yan
2026-09-28 16:34 ` Leo Yan
2026-09-29 3:40 ` Chen Pei
2026-09-29 3:40 ` Chen Pei
2026-09-29 8:28 ` David Laight
2026-09-29 8:28 ` David Laight
2026-09-29 9:08 ` Chen Pei
2026-09-29 9:08 ` Chen Pei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260928094739.2605-1-cp0613@linux.alibaba.com \
--to=cp0613@linux.alibaba.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=guoren@kernel.org \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=leo.yan@linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mike.leach@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=palmer@dabbelt.com \
--cc=peterz@infradead.org \
--cc=pjw@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.