From: sashiko-bot@kernel.org
To: "Zack Rusin" <zack.rusin@broadcom.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Dave Young" <ruirui.yang@linux.dev>,
"Baoquan He" <baoquan.he@linux.dev>,
"Mike Rapoport" <rppt@kernel.org>,
"Pratyush Yadav" <pratyush@kernel.org>,
"Pasha Tatashin" <pasha.tatashin@soleen.com>,
"Petr Mladek" <pmladek@suse.com>
Cc: "Alexey Makhalov" <alexey.makhalov@broadcom.com>,
"John Ogness" <john.ogness@linutronix.de>,
kexec@lists.infradead.org,
"Stephen Brennan" <stephen.s.brennan@oracle.com>,
"Shuah Khan" <skhan@linuxfoundation.org>,
bcm-kernel-feedback-list@broadcom.com,
"H. Peter Anvin" <hpa@zytor.com>, "Bo Gan" <bo.gan@broadcom.com>,
"Maaz Mombasawala" <maaz.mombasawala@broadcom.com>,
"Joel Granados" <joel.granados@kernel.org>,
"Ian Forbes" <ian.forbes@broadcom.com>,
"Randy Dunlap" <rdunlap@infradead.org>,
"Michael Kelley" <mhklinux@outlook.com>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Eugenio Perez" <eperezma@redhat.com>,
"Borislav Petkov" <bp@alien8.de>,
linux-kernel@vger.kernel.org, virtualization@lists.linux.dev,
"Michael S. Tsirkin" <mst@redhat.com>,
"Kees Cook" <kees@kernel.org>, "Jonathan Corbet" <corbet@lwn.net>,
"Guilherme G. Piccoli" <gpiccoli@igalia.com>,
"Sergey Senozhatsky" <senozhatsky@chromium.org>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
"Ajay Kaher" <ajay.kaher@broadcom.com>,
linux-doc@vger.kernel.org, "Ingo Molnar" <mingo@redhat.com>,
"Thomas Gleixner" <tglx@kernel.org>,
x86@kernel.org,
"Brennan Lamoreaux" <brennan.lamoreaux@broadcom.com>
Subject: Re: [PATCH v2 6/6] x86/vmware: Report guest crashes after kmsg dumpers
Date: Mon, 28 Sep 2026 18:03:36 +0000 [thread overview]
Message-ID: <20260928180337.6F9CE1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <996d3ceefd98ed9a7c40508e6f62039ba5a15325.1790014793.git.zack.rusin@broadcom.com>
> VMware accepts a structured guest-crash event, but a host configured with
> backdoor.coredumpOnCrash may terminate the VM before the hypercall
> returns. Keep this event separate from the pre-kdump log sender.
>
> Register a panic-only kmsg dumper with late_initcall_sync(), after built-in
> dumpers registered by then. Skip the event while a crash kernel is loaded
> so the host cannot terminate the guest before kdump saves its vmcore.
>
> Issue the event at most once. With CONFIG_PRINTK=n, use a late INT_MIN
> panic notifier. An unexpected dumper registration failure with printk
> enabled leaves reporting disabled rather than overtaking working dumpers.
>
> Link: https://lore.kernel.org/r/20260309235250.2611115-4-alexey.makhalov@broadcom.com
> Co-developed-by: Brennan Lamoreaux <brennan.lamoreaux@broadcom.com>
> Signed-off-by: Brennan Lamoreaux <brennan.lamoreaux@broadcom.com>
> Co-developed-by: Alexey Makhalov <alexey.makhalov@broadcom.com>
> Signed-off-by: Alexey Makhalov <alexey.makhalov@broadcom.com>
> Signed-off-by: Zack Rusin <zack.rusin@broadcom.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1790014793.git.zack.rusin@broadcom.com?part=6
WARNING: multiple messages have this Message-ID (diff)
From: sashiko-bot@kernel.org
To: "Zack Rusin" <zack.rusin@broadcom.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Dave Young" <ruirui.yang@linux.dev>,
"Baoquan He" <baoquan.he@linux.dev>,
"Mike Rapoport" <rppt@kernel.org>,
"Pratyush Yadav" <pratyush@kernel.org>,
"Pasha Tatashin" <pasha.tatashin@soleen.com>,
"Petr Mladek" <pmladek@suse.com>
Cc: x86@kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
Kees Cook <kees@kernel.org>,
Dave Hansen <dave.hansen@linux.intel.com>,
Stephen Brennan <stephen.s.brennan@oracle.com>,
Bo Gan <bo.gan@broadcom.com>, "H. Peter Anvin" <hpa@zytor.com>,
Jonathan Corbet <corbet@lwn.net>,
Brennan Lamoreaux <brennan.lamoreaux@broadcom.com>,
linux-doc@vger.kernel.org,
Joel Granados <joel.granados@kernel.org>,
Alexey Makhalov <alexey.makhalov@broadcom.com>,
Eugenio Perez <eperezma@redhat.com>,
Ingo Molnar <mingo@redhat.com>,
bcm-kernel-feedback-list@broadcom.com,
Ajay Kaher <ajay.kaher@broadcom.com>,
John Ogness <john.ogness@linutronix.de>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
virtualization@lists.linux.dev,
Steven Rostedt <rostedt@goodmis.org>,
Maaz Mombasawala <maaz.mombasawala@broadcom.com>,
Borislav Petkov <bp@alien8.de>,
Shuah Khan <skhan@linuxfoundation.org>,
Michael Kelley <mhklinux@outlook.com>,
Randy Dunlap <rdunlap@infradead.org>,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
Ian Forbes <ian.forbes@broadcom.com>,
Thomas Gleixner <tglx@kernel.org>
Subject: Re: [PATCH v2 6/6] x86/vmware: Report guest crashes after kmsg dumpers
Date: Mon, 28 Sep 2026 18:03:36 +0000 [thread overview]
Message-ID: <20260928180337.6F9CE1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <996d3ceefd98ed9a7c40508e6f62039ba5a15325.1790014793.git.zack.rusin@broadcom.com>
> VMware accepts a structured guest-crash event, but a host configured with
> backdoor.coredumpOnCrash may terminate the VM before the hypercall
> returns. Keep this event separate from the pre-kdump log sender.
>
> Register a panic-only kmsg dumper with late_initcall_sync(), after built-in
> dumpers registered by then. Skip the event while a crash kernel is loaded
> so the host cannot terminate the guest before kdump saves its vmcore.
>
> Issue the event at most once. With CONFIG_PRINTK=n, use a late INT_MIN
> panic notifier. An unexpected dumper registration failure with printk
> enabled leaves reporting disabled rather than overtaking working dumpers.
>
> Link: https://lore.kernel.org/r/20260309235250.2611115-4-alexey.makhalov@broadcom.com
> Co-developed-by: Brennan Lamoreaux <brennan.lamoreaux@broadcom.com>
> Signed-off-by: Brennan Lamoreaux <brennan.lamoreaux@broadcom.com>
> Co-developed-by: Alexey Makhalov <alexey.makhalov@broadcom.com>
> Signed-off-by: Alexey Makhalov <alexey.makhalov@broadcom.com>
> Signed-off-by: Zack Rusin <zack.rusin@broadcom.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1790014793.git.zack.rusin@broadcom.com?part=6
next prev parent reply other threads:[~2026-09-28 18:03 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 17:55 [PATCH v2 0/6] panic, x86/vmware: Preserve crash logs before kdump Zack Rusin
2026-09-28 17:55 ` Zack Rusin
2026-09-28 17:55 ` [PATCH v2 1/6] panic: Add a notifier chain for pre-kdump callbacks Zack Rusin
2026-09-28 17:55 ` Zack Rusin
2026-09-28 18:04 ` sashiko-bot
2026-09-28 18:04 ` sashiko-bot
2026-09-28 17:55 ` [PATCH v2 2/6] crash: Notify pre-kdump callbacks before switching kernels Zack Rusin
2026-09-28 17:55 ` Zack Rusin
2026-09-28 18:08 ` sashiko-bot
2026-09-28 18:08 ` sashiko-bot
2026-09-28 18:40 ` Zack Rusin
2026-09-28 18:40 ` Zack Rusin
2026-09-28 18:40 ` Zack Rusin
2026-09-28 17:55 ` [PATCH v2 3/6] panic: Allow postponing pre-kdump notifiers Zack Rusin
2026-09-28 17:55 ` Zack Rusin
2026-09-28 18:04 ` sashiko-bot
2026-09-28 18:04 ` sashiko-bot
2026-09-28 17:55 ` [PATCH v2 4/6] x86/vmware: Add a bounded pre-kdump log sender Zack Rusin
2026-09-28 17:55 ` Zack Rusin
2026-09-28 18:07 ` sashiko-bot
2026-09-28 18:07 ` sashiko-bot
2026-09-28 17:55 ` [PATCH v2 5/6] x86/vmware: Add the vmware_record_panic_msg sysctl Zack Rusin
2026-09-28 17:55 ` Zack Rusin
2026-09-28 18:06 ` sashiko-bot
2026-09-28 18:06 ` sashiko-bot
2026-09-28 17:55 ` [PATCH v2 6/6] x86/vmware: Report guest crashes after kmsg dumpers Zack Rusin
2026-09-28 17:55 ` Zack Rusin
2026-09-28 18:03 ` sashiko-bot [this message]
2026-09-28 18:03 ` sashiko-bot
2026-09-28 20:39 ` [PATCH v2 0/6] panic, x86/vmware: Preserve crash logs before kdump Bradley Morgan
2026-09-28 20:39 ` Bradley Morgan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260928180337.6F9CE1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=ajay.kaher@broadcom.com \
--cc=akpm@linux-foundation.org \
--cc=alexey.makhalov@broadcom.com \
--cc=baoquan.he@linux.dev \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bo.gan@broadcom.com \
--cc=bp@alien8.de \
--cc=brennan.lamoreaux@broadcom.com \
--cc=corbet@lwn.net \
--cc=dave.hansen@linux.intel.com \
--cc=eperezma@redhat.com \
--cc=gpiccoli@igalia.com \
--cc=hpa@zytor.com \
--cc=ian.forbes@broadcom.com \
--cc=joel.granados@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=kees@kernel.org \
--cc=kexec@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maaz.mombasawala@broadcom.com \
--cc=mhklinux@outlook.com \
--cc=mingo@redhat.com \
--cc=mst@redhat.com \
--cc=pasha.tatashin@soleen.com \
--cc=pmladek@suse.com \
--cc=pratyush@kernel.org \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
--cc=rppt@kernel.org \
--cc=ruirui.yang@linux.dev \
--cc=sashiko-reviews@lists.linux.dev \
--cc=senozhatsky@chromium.org \
--cc=skhan@linuxfoundation.org \
--cc=stephen.s.brennan@oracle.com \
--cc=tglx@kernel.org \
--cc=virtualization@lists.linux.dev \
--cc=x86@kernel.org \
--cc=zack.rusin@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.