Re: [PATCH 1/3] dt-bindings: power: spacemit: Add power domain controller

From: Rob Herring <robh@kernel.org>
To: Yixun Lan <dlan@kernel.org>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Ulf Hansson <ulfh@kernel.org>,
	Paul Walmsley <pjw@kernel.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Alexandre Ghiti <alex@ghiti.fr>,
	devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
	spacemit@lists.linux.dev, linux-kernel@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: power: spacemit: Add power domain controller
Date: Mon, 28 Sep 2026 13:30:26 -0500	[thread overview]
Message-ID: <20260928183026.GA211865-robh@kernel.org> (raw)
In-Reply-To: <20260918-04-k3-pm-support-v1-1-0acd2b36b96f@kernel.org>

On Fri, Sep 18, 2026 at 02:40:13AM +0000, Yixun Lan wrote:
> Add initial power domain driver support for SpacemiT K1/K3 SoC, The Power
> Domain Controller is SoC internal module which is part of APMU (Advanced
> Power Management Unit), it is responsible for managing power across multi
> power domains, which includes power on/off, isolation, power-on sequence.
> 
> Signed-off-by: Yixun Lan <dlan@kernel.org>
> ---
>  .../bindings/power/spacemit,power-controller.yaml  | 43 ++++++++++++++++++++++
>  include/dt-bindings/power/spacemit,k1-power.h      | 14 +++++++
>  include/dt-bindings/power/spacemit,k3-power.h      | 12 ++++++
>  3 files changed, 69 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/power/spacemit,power-controller.yaml b/Documentation/devicetree/bindings/power/spacemit,power-controller.yaml
> new file mode 100644
> index 000000000000..f869285f84da
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/spacemit,power-controller.yaml
> @@ -0,0 +1,43 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/power/spacemit,power-controller.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: SpacemiT Power Domains Controller
> +
> +maintainers:
> +  - Yixun Lan <dlan@kernel.org>
> +
> +description: |
> +  SpacemiT processors include support for multiple power domains which can be
> +  powered on/off by software based on different application scenes to save power.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - spacemit,k1-power-controller
> +      - spacemit,k3-power-controller
> +
> +  '#power-domain-cells':
> +    const: 1
> +
> +  spacemit,apmu:
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +    description:
> +      A phandle to APMU syscon to control registers for power domain

Sounds like the APMU should be the power-domain provider directly. You 
don't seem to have any other registers for this node.

Rob