Re: [PATCH 1/2] md: make mddev lookup and ioctl helpers non-static

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] md: generic update_array_info() and set_disk_faulty() lack subsystem prefix
--

commit 471cd6c3e9c36553c5976e00c65220dac80b2aea
Author: Abd-Alrhman Masalkhi <abd.masalkhi@gmail.com>

md: make mddev lookup and ioctl helpers non-static

This commit exposes several internal md array lookup and ioctl helper functions
by removing their static declarations. This change is intended to allow a new md
misc control device to reuse these helpers without opening the md block device.

> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index 680b34a63cb3d..b5027d65c6d8d 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
[ ... ]
> @@ -8101,7 +8101,7 @@ static void put_cluster_ops(struct mddev *mddev)
>   * Any differences that cannot be handled will cause an error.
>   * Normally, only one change can be managed at a time.
>   */
> -static int update_array_info(struct mddev *mddev, mdu_array_info_t *info)
> +int update_array_info(struct mddev *mddev, mdu_array_info_t *info)

[Severity: Low]
By removing the static keyword, update_array_info() is now added to the global
kernel namespace. Since this name is quite generic, should it be given an "md_"
prefix to avoid potential symbol collisions with other subsystems?

>  {
>  	int rv = 0;
>  	int cnt = 0;
[ ... ]
> @@ -8227,7 +8227,7 @@ static int update_array_info(struct mddev *mddev, mdu_array_info_t *info)
>  	return rv;
>  }
>  
> -static int set_disk_faulty(struct mddev *mddev, dev_t dev)
> +int set_disk_faulty(struct mddev *mddev, dev_t dev)

[Severity: Low]
Similar to update_array_info(), set_disk_faulty() is now globally visible.
Would it be safer to rename this to md_set_disk_faulty() to prevent namespace
pollution and potential collisions?

>  {
>  	struct md_rdev *rdev;
>  	int err = 0;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260928201224.3602262-1-abd.masalkhi@gmail.com?part=1