From: Greg KH <gregkh@linuxfoundation.org>
To: Abd-Alrhman Masalkhi <abd.masalkhi@gmail.com>
Cc: song@kernel.org, yukuai@fygo.io, chengzhihao1@huawei.com,
magiclinan@didiglobal.com, xiao@kernel.org, agk@redhat.com,
snitzer@kernel.org, mpatocka@redhat.com, bmarzins@redhat.com,
arnd@arndb.de, linux-kernel@vger.kernel.org,
linux-raid@vger.kernel.org, dm-devel@lists.linux.dev
Subject: Re: [PATCH 2/2] md: add a control device for array management
Date: Tue, 29 Sep 2026 06:49:00 +0200 [thread overview]
Message-ID: <2026092927-dominion-defeat-eed0@gregkh> (raw)
In-Reply-To: <20260928201224.3602262-3-abd.masalkhi@gmail.com>
On Mon, Sep 28, 2026 at 08:12:24PM +0000, Abd-Alrhman Masalkhi wrote:
> Add a misc character device, /dev/md-control, with a fixed minor
> MD_CTRL_MINOR. The control device is not tied to any md device, each
> request specifies the array in the payload, either by name, by UUID or
> by device number, without the need to open the md block device.
Why is this a fixed number and not a dynamic one? There should not eve
be a need for fixed numbers anymore.
> --- /dev/null
> +++ b/drivers/md/md-ctl.c
> @@ -0,0 +1,597 @@
> +// SPDX-License-Identifier: GPL-2.0
> +
No copyright information?
> diff --git a/include/linux/miscdevice.h b/include/linux/miscdevice.h
> index fa9000f68523..0bf2870dc191 100644
> --- a/include/linux/miscdevice.h
> +++ b/include/linux/miscdevice.h
> @@ -71,6 +71,7 @@
> #define VHOST_VSOCK_MINOR 241
> #define EISA_EEPROM_MINOR 241
> #define RFKILL_MINOR 242
> +#define MD_CTRL_MINOR 243
No, please use a dynamic number instead.
thanks,
greg k-h
next prev parent reply other threads:[~2026-09-29 4:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 20:12 [PATCH 0/2] md: add a control device for array management Abd-Alrhman Masalkhi
2026-09-28 20:12 ` [PATCH 1/2] md: make mddev lookup and ioctl helpers non-static Abd-Alrhman Masalkhi
2026-09-28 20:26 ` sashiko-bot
2026-09-28 20:12 ` [PATCH 2/2] md: add a control device for array management Abd-Alrhman Masalkhi
2026-09-28 20:26 ` sashiko-bot
2026-09-29 7:38 ` Abd-Alrhman Masalkhi
2026-09-29 4:49 ` Greg KH [this message]
2026-09-29 7:12 ` Abd-Alrhman Masalkhi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026092927-dominion-defeat-eed0@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=abd.masalkhi@gmail.com \
--cc=agk@redhat.com \
--cc=arnd@arndb.de \
--cc=bmarzins@redhat.com \
--cc=chengzhihao1@huawei.com \
--cc=dm-devel@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=magiclinan@didiglobal.com \
--cc=mpatocka@redhat.com \
--cc=snitzer@kernel.org \
--cc=song@kernel.org \
--cc=xiao@kernel.org \
--cc=yukuai@fygo.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.