* + mm-damon-tests-core-kunit-test-preservation-of-quota-state.patch added to mm-new branch
@ 2026-09-28 22:19 Andrew Morton
0 siblings, 0 replies; only message in thread
From: Andrew Morton @ 2026-09-28 22:19 UTC (permalink / raw)
To: mm-commits, sj, davidgow, brendan.higgins, bijan311, kmehltretter,
akpm
The patch titled
Subject: mm/damon/tests/core-kunit: test preservation of quota state
has been added to the -mm mm-new branch. Its filename is
mm-damon-tests-core-kunit-test-preservation-of-quota-state.patch
This patch will shortly appear at
https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-damon-tests-core-kunit-test-preservation-of-quota-state.patch
This patch will later appear in the mm-new branch at
git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
Note, mm-new is a provisional staging ground for work-in-progress
patches, and acceptance into mm-new is a notification for others take
notice and to finish up reviews. Please do not hesitate to respond to
review feedback and post updated versions to replace or incrementally
fixup patches in mm-new.
The mm-new branch of mm.git is not included in linux-next
If a few days of testing in mm-new is successful, the patch will me moved
into mm.git's mm-unstable branch, which is included in linux-next
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next via various
branches at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there most days
------------------------------------------------------
From: Karl Mehltretter <kmehltretter@gmail.com>
Subject: mm/damon/tests/core-kunit: test preservation of quota state
Date: Mon, 28 Sep 2026 01:58:34 -0700
Check that damon_new_scheme() initializes the new scheme's quota without
changing the quota passed as a parameter. Cover all eight fields
initialized by damos_quota_init().
Also check that damon_commit_ctx() preserves those fields in the
destination scheme for both accepted and rejected parameter updates. Use
an invalid min_region_sz for the rejected update and confirm that
returning -EINVAL leaves the running quota state unchanged.
Without the preceding fix, all eight fields are cleared in the constructor
test and in both context update cases.
Link: https://lore.kernel.org/20260928085835.7675-3-sj@kernel.org
Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
Signed-off-by: SJ Park <sj@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Reviewed-by: SJ Park <sj@kernel.org>
Assisted-by: LLM
Cc: Bijan Tabatabai <bijan311@gmail.com>
Cc: Brendan Higgins <brendan.higgins@linux.dev>
Cc: David Gow <davidgow@davidgow.net>
---
mm/damon/tests/core-kunit.h | 107 ++++++++++++++++++++++++++++++++++
1 file changed, 107 insertions(+)
--- a/mm/damon/tests/core-kunit.h~mm-damon-tests-core-kunit-test-preservation-of-quota-state
+++ a/mm/damon/tests/core-kunit.h
@@ -812,6 +812,48 @@ static void damos_test_new_filter(struct
damos_destroy_filter(filter);
}
+static void damos_test_new_scheme_keeps_src_quota(struct kunit *test)
+{
+ struct damos_access_pattern pattern = {};
+ struct damon_target target = {};
+ struct damos_quota quota = {
+ .sz = SZ_64K,
+ .esz = 123,
+ .esz_bp = 456,
+ .total_charged_sz = 789,
+ .total_charged_ns = 1011,
+ .charged_sz = 12,
+ .charged_from = 13,
+ .charge_target_from = &target,
+ .charge_addr_from = 14,
+ };
+ struct damos_watermarks wmarks = {};
+ struct damos *s;
+
+ s = damon_new_scheme(&pattern, DAMOS_STAT, 0, "a, &wmarks,
+ NUMA_NO_NODE);
+ if (!s)
+ kunit_skip(test, "scheme alloc fail");
+ KUNIT_EXPECT_EQ(test, s->quota.sz, (unsigned long)SZ_64K);
+ KUNIT_EXPECT_EQ(test, s->quota.esz, 0ul);
+ KUNIT_EXPECT_EQ(test, s->quota.esz_bp, 0ul);
+ KUNIT_EXPECT_EQ(test, s->quota.total_charged_sz, 0ul);
+ KUNIT_EXPECT_EQ(test, s->quota.total_charged_ns, 0ul);
+ KUNIT_EXPECT_EQ(test, s->quota.charged_sz, 0ul);
+ KUNIT_EXPECT_EQ(test, s->quota.charged_from, 0ul);
+ KUNIT_EXPECT_PTR_EQ(test, s->quota.charge_target_from, NULL);
+ KUNIT_EXPECT_EQ(test, s->quota.charge_addr_from, 0ul);
+ KUNIT_EXPECT_EQ(test, quota.esz, 123ul);
+ KUNIT_EXPECT_EQ(test, quota.esz_bp, 456ul);
+ KUNIT_EXPECT_EQ(test, quota.total_charged_sz, 789ul);
+ KUNIT_EXPECT_EQ(test, quota.total_charged_ns, 1011ul);
+ KUNIT_EXPECT_EQ(test, quota.charged_sz, 12ul);
+ KUNIT_EXPECT_EQ(test, quota.charged_from, 13ul);
+ KUNIT_EXPECT_PTR_EQ(test, quota.charge_target_from, &target);
+ KUNIT_EXPECT_EQ(test, quota.charge_addr_from, 14ul);
+ damon_destroy_scheme(s);
+}
+
static void damos_test_commit_quota_goal_for(struct kunit *test,
struct damos_quota_goal *dst,
struct damos_quota_goal *src)
@@ -1572,6 +1614,69 @@ static void damon_test_commit_ctx(struct
damon_destroy_ctx(dst);
}
+static void damon_test_commit_ctx_keeps_quota_for(struct kunit *test,
+ unsigned long min_region_sz, int expected_err)
+{
+ struct damos_access_pattern pattern = {};
+ struct damos_quota quota = {.sz = SZ_64K};
+ struct damos_watermarks wmarks = {};
+ struct damon_ctx *src, *dst;
+ struct damon_target *target;
+ struct damos *s;
+
+ dst = damon_new_ctx();
+ if (!dst)
+ kunit_skip(test, "dst alloc fail");
+ target = damon_new_target();
+ if (!target) {
+ damon_destroy_ctx(dst);
+ kunit_skip(test, "target alloc fail");
+ }
+ damon_add_target(dst, target);
+ s = damon_new_scheme(&pattern, DAMOS_STAT, 0, "a, &wmarks,
+ NUMA_NO_NODE);
+ if (!s) {
+ damon_destroy_ctx(dst);
+ kunit_skip(test, "scheme alloc fail");
+ }
+ damon_add_scheme(dst, s);
+
+ /* Copy the parameters before populating dst's runtime quota state. */
+ src = damon_new_test_ctx(dst);
+ if (!src) {
+ damon_destroy_ctx(dst);
+ kunit_skip(test, "src alloc fail");
+ }
+ src->min_region_sz = min_region_sz;
+ s->quota.esz = 123;
+ s->quota.esz_bp = 456;
+ s->quota.total_charged_sz = 789;
+ s->quota.total_charged_ns = 1011;
+ s->quota.charged_sz = 12;
+ s->quota.charged_from = 13;
+ s->quota.charge_target_from = target;
+ s->quota.charge_addr_from = 14;
+
+ KUNIT_EXPECT_EQ(test, damon_commit_ctx(dst, src), expected_err);
+ KUNIT_EXPECT_EQ(test, s->quota.esz, 123ul);
+ KUNIT_EXPECT_EQ(test, s->quota.esz_bp, 456ul);
+ KUNIT_EXPECT_EQ(test, s->quota.total_charged_sz, 789ul);
+ KUNIT_EXPECT_EQ(test, s->quota.total_charged_ns, 1011ul);
+ KUNIT_EXPECT_EQ(test, s->quota.charged_sz, 12ul);
+ KUNIT_EXPECT_EQ(test, s->quota.charged_from, 13ul);
+ KUNIT_EXPECT_PTR_EQ(test, s->quota.charge_target_from, target);
+ KUNIT_EXPECT_EQ(test, s->quota.charge_addr_from, 14ul);
+ damon_destroy_ctx(src);
+ damon_destroy_ctx(dst);
+}
+
+static void damon_test_commit_ctx_keeps_quota(struct kunit *test)
+{
+ /* Only power of two min_region_sz is allowed. */
+ damon_test_commit_ctx_keeps_quota_for(test, 4096, 0);
+ damon_test_commit_ctx_keeps_quota_for(test, 4095, -EINVAL);
+}
+
static void damon_test_valid_probe_params(struct kunit *test)
{
struct damon_ctx *ctx;
@@ -2259,6 +2364,7 @@ static struct kunit_case damon_test_case
KUNIT_CASE(damon_test_mvsum),
KUNIT_CASE(damon_test_nr_accesses_mvsum),
KUNIT_CASE(damos_test_new_filter),
+ KUNIT_CASE(damos_test_new_scheme_keeps_src_quota),
KUNIT_CASE(damos_test_commit_quota_goal),
KUNIT_CASE(damos_test_commit_quota_goals),
KUNIT_CASE(damos_test_commit_quota),
@@ -2270,6 +2376,7 @@ static struct kunit_case damon_test_case
KUNIT_CASE(damon_test_commit_filter),
KUNIT_CASE(damon_test_commit_probes),
KUNIT_CASE(damon_test_commit_ctx),
+ KUNIT_CASE(damon_test_commit_ctx_keeps_quota),
KUNIT_CASE(damon_test_valid_probe_params),
KUNIT_CASE(damos_test_filter_out),
KUNIT_CASE(damos_test_apply_scheme_filtered_sz),
_
Patches currently in -mm which might be from kmehltretter@gmail.com are
mm-damon-core-handle-uninitialized-damos_quota_goal-last_psi_total-fix.patch
docs-mm-ksm-use-the-renamed-ksm-structure-names.patch
mm-secretmem-fix-the-enable-parameter-description.patch
mm-damon-core-preserve-the-quota-passed-to-damon_new_scheme.patch
mm-damon-tests-core-kunit-test-preservation-of-quota-state.patch
klist-avoid-accesses-after-waking-klist_remove.patch
squashfs-fix-fragment-index-table-sizing-overflow-on-32-bit.patch
squashfs-make-the-fragment-index-table-bounds-check-overflow-safe.patch
fork-honor-task_structs-declared-alignment.patch
ocfs2-cluster-hold-a-reference-on-the-heartbeat-thread.patch
resource-kunit-stop-selecting-get_free_region.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-09-28 22:19 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-28 22:19 + mm-damon-tests-core-kunit-test-preservation-of-quota-state.patch added to mm-new branch Andrew Morton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.