Re: [PATCH 3/4] riscv: dts: thead: enable AP6256 Wi-Fi on Milk-V Meles

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Missing function = "gpio" in wifi_host_wake_pins pinctrl node
--

commit de373882dd24540cebce78cb7e64ca51c97365ba
Author: Han Gao <gaohan@iscas.ac.cn>

riscv: dts: thead: enable AP6256 Wi-Fi on Milk-V Meles

This commit adds device tree nodes to enable the AP6256 Wi-Fi module on the
Milk-V Meles. It configures the SDIO interface, PMIC clocks, regulators,
and GPIO pins for the Wi-Fi module's operation and host-wake interrupts.

> diff --git a/arch/riscv/boot/dts/thead/th1520-milkv-meles.dts b/arch/riscv/boot/dts/thead/th1520-milkv-meles.dts
> --- a/arch/riscv/boot/dts/thead/th1520-milkv-meles.dts
> +++ b/arch/riscv/boot/dts/thead/th1520-milkv-meles.dts

[ ... ]

> +&padctrl1_apsys {
> +	wifi_enable_pins: wifi-enable-0 {
> +		gpio-pins {
> +			pins = "GPIO0_20";
> +			bias-disable;
> +			drive-strength = <7>;
> +			input-disable;
> +		};
> +	};
> +
> +	wifi_host_wake_pins: wifi-host-wake-0 {
> +		gpio-pins {
> +			pins = "GPIO0_21";
> +			bias-disable;
> +			input-enable;
> +			input-schmitt-enable;

[Severity: Medium]
Does this pinctrl node also need a function = "gpio" property to ensure the 
pin is properly muxed?

If the bootloader configures GPIO0_21 for an alternate function, the missing
function assignment means the pinctrl-th1520 driver might skip creating a
PIN_MAP_TYPE_MUX_GROUP mapping. The dw-apb-gpio driver will request the
interrupt via gpiochip_irq_reqres(), which locks the IRQ but never calls
pinctrl_gpio_request().

This could leave the pin in its alternate function state, preventing the
host-wake interrupt from triggering and potentially breaking wake-on-WLAN
functionality.

> +		};
> +	};
> +};

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260929-rv-meles-v1-0-effdd14a76e8@iscas.ac.cn?part=3