Re: [PATCH 3/4] riscv: dts: thead: enable AP6256 Wi-Fi on Milk-V Meles

From: Drew Fustini <fustini@kernel.org>
To: Han Gao <gaohan@iscas.ac.cn>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Paul Walmsley <pjw@kernel.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Alexandre Ghiti <alex@ghiti.fr>,
	Jisheng Zhang <jszhang@kernel.org>, Guo Ren <guoren@kernel.org>,
	Fu Wei <wefu@redhat.com>, Han Gao <rabenda.cn@gmail.com>,
	devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] riscv: dts: thead: enable AP6256 Wi-Fi on Milk-V Meles
Date: Tue, 29 Sep 2026 15:38:58 -0700	[thread overview]
Message-ID: <arw-AtrtmdkicuBs@thelio> (raw)
In-Reply-To: <20260929-rv-meles-v1-3-effdd14a76e8@iscas.ac.cn>

On Tue, Sep 29, 2026 at 06:22:47PM +0800, Han Gao wrote:
> Connect AP6256 to SDIO1 with its fixed supplies and PMIC LPO clock.
> Use GPIO0_20 for WL_REG_ON and GPIO0_21 for the host-wake interrupt.
> Keep GPIO1_24 low to select the external antenna by default.
> 
> Use the existing BCM43456 binding and the 198 MHz board limit.
> Keep module power during suspend and assign mmc2 to SDIO1.
> 
> Signed-off-by: Han Gao <gaohan@iscas.ac.cn>
> ---
>  arch/riscv/boot/dts/thead/th1520-milkv-meles.dts | 93 ++++++++++++++++++++++++
>  1 file changed, 93 insertions(+)
> 
> diff --git a/arch/riscv/boot/dts/thead/th1520-milkv-meles.dts b/arch/riscv/boot/dts/thead/th1520-milkv-meles.dts
> index 3714047190789bfccd8ff6810342d7ff865e74e4..92b44cb90f57f4830efd29145744c005afa73119 100644
> --- a/arch/riscv/boot/dts/thead/th1520-milkv-meles.dts
> +++ b/arch/riscv/boot/dts/thead/th1520-milkv-meles.dts
[..]
> @@ -206,6 +249,26 @@ rx-pins {
>  	};
>  };
>  
> +&padctrl1_apsys {
> +	wifi_enable_pins: wifi-enable-0 {
> +		gpio-pins {
> +			pins = "GPIO0_20";
> +			bias-disable;
> +			drive-strength = <7>;
> +			input-disable;
> +		};
> +	};
> +
> +	wifi_host_wake_pins: wifi-host-wake-0 {
> +		gpio-pins {
> +			pins = "GPIO0_21";

This node needs function = "gpio". It is interrupt-only so nothing
selects the GPIO mux. I can fix this up when applying to save a v2.

Reviewed-by: Drew Fustini <fustini@kernel.org>