[LTP] [PATCH] openposix: lib: Use the configured compiler

[LTP] [PATCH] openposix: lib: Use the configured compiler

[Anders Roxell]

The lib Makefile does not include env.mk, so it does not get CC from
config.mk. When we cross compile, libcommon.a gets built with the host
compiler. Then the linker skips it and most tests fail to build.

Include env.mk, like the other Makefiles do.

Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
---
 testcases/open_posix_testsuite/lib/Makefile | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/testcases/open_posix_testsuite/lib/Makefile b/testcases/open_posix_testsuite/lib/Makefile
index ad6a9d7e6a1b..e63ee42647ac 100644
--- a/testcases/open_posix_testsuite/lib/Makefile
+++ b/testcases/open_posix_testsuite/lib/Makefile
@@ -1,6 +1,8 @@
 top_srcdir?=		..
 subdir=			lib
 
+include $(top_srcdir)/include/mk/env.mk
+
 AR?=			ar
 RANLIB?=		ranlib
 CFLAGS+=		-I$(top_srcdir)/include
-- 
2.53.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] openposix: lib: Use the configured compiler

[linuxtestproject.agent]

Hi Anders,

On Mon, 28 Sep 2026 23:27:21 +0200, Anders Roxell wrote:
> openposix: lib: Use the configured compiler

Verdict - Reviewed

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] openposix: lib: Use the configured compiler

[Petr Vorel]

Hi Anders,

> The lib Makefile does not include env.mk, so it does not get CC from
> config.mk. When we cross compile, libcommon.a gets built with the host
> compiler. Then the linker skips it and most tests fail to build.

> Include env.mk, like the other Makefiles do.

Make sense, thanks!
Verified and merged even close before the release.

Kind regards,
Petr

> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> ---
>  testcases/open_posix_testsuite/lib/Makefile | 2 ++
>  1 file changed, 2 insertions(+)

> diff --git a/testcases/open_posix_testsuite/lib/Makefile b/testcases/open_posix_testsuite/lib/Makefile
> index ad6a9d7e6a1b..e63ee42647ac 100644
> --- a/testcases/open_posix_testsuite/lib/Makefile
> +++ b/testcases/open_posix_testsuite/lib/Makefile
> @@ -1,6 +1,8 @@
>  top_srcdir?=		..
>  subdir=			lib

> +include $(top_srcdir)/include/mk/env.mk
> +
>  AR?=			ar
>  RANLIB?=		ranlib
>  CFLAGS+=		-I$(top_srcdir)/include

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp