All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Hung <alex.hung@amd.com>
To: <igt-dev@lists.freedesktop.org>
Cc: Alex Hung <alex.hung@amd.com>
Subject: [PATCH i-g-t v2 0/5] Preserve const qualifiers in string parsing
Date: Tue, 29 Sep 2026 11:49:45 -0400	[thread overview]
Message-ID: <20260929154950.838280-1-alex.hung@amd.com> (raw)

On Ubuntu 26.04 with glibc 2.43, string searches on const input return
const pointers when _GNU_SOURCE is defined.
-Wdiscarded-qualifiers warnings for assignments and initializations.

Use const char * for results that are only read. Keep char * where the
buffer is modified, and use a separate end pointer for numeric parsing
where needed. These changes preserve existing parsing behavior.

The five patches cover benchmarks, tools, libraries, the Intel SSEU
test, and the MSM mapping test, in that order. Each commit message
includes a warning example with its function and source location.

Changes in v2:
- Split the two v1 patches into five focused patches.
- Include the preceding function context and source location in each
  warning example, plus OS is Ubuntu 26.04.

The code is unchanged from v1.

Alex Hung (5):
  benchmarks/gem_wsim: Preserve const qualifiers
  tools/intel_reg_spec: Preserve const qualifiers
  lib: Preserve string const qualifiers
  tests/i915_pm_sseu: Preserve const qualifiers
  tests/msm_mapping: Keep parser buffers writable

 benchmarks/gem_wsim.c      |  2 +-
 lib/i915/i915_dp.c         |  2 +-
 lib/igt_core.c             |  2 +-
 lib/igt_drm_fdinfo.c       |  7 ++++---
 lib/igt_pm.c               | 10 +++++-----
 lib/igt_pm.h               |  2 +-
 tests/intel/i915_pm_sseu.c |  8 ++++----
 tests/msm/msm_mapping.c    |  6 +++---
 tools/intel_reg_spec.c     |  7 ++++---
 9 files changed, 24 insertions(+), 22 deletions(-)

-- 
2.53.0


             reply	other threads:[~2026-09-29 15:50 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-29 15:49 Alex Hung [this message]
2026-09-29 15:49 ` [PATCH i-g-t v2 1/5] benchmarks/gem_wsim: Preserve const qualifiers Alex Hung
2026-09-30 13:41   ` Kamil Konieczny
2026-09-29 15:49 ` [PATCH i-g-t v2 2/5] tools/intel_reg_spec: " Alex Hung
2026-09-30 13:43   ` Kamil Konieczny
2026-09-29 15:49 ` [PATCH i-g-t v2 3/5] lib: Preserve string " Alex Hung
2026-09-30 13:46   ` Kamil Konieczny
2026-09-29 15:49 ` [PATCH i-g-t v2 4/5] tests/i915_pm_sseu: Preserve " Alex Hung
2026-09-30 13:51   ` Kamil Konieczny
2026-09-29 15:49 ` [PATCH i-g-t v2 5/5] tests/msm_mapping: Keep parser buffers writable Alex Hung
2026-09-30 13:55   ` Kamil Konieczny
2026-09-30 14:32     ` Rob Clark
2026-10-02 14:17       ` Kamil Konieczny
2026-09-29 17:41 ` ✗ Xe.CI.BAT: failure for Preserve const qualifiers in string parsing (rev2) Patchwork
2026-09-30 14:24   ` Kamil Konieczny
2026-09-29 17:54 ` ✗ i915.CI.BAT: " Patchwork
2026-09-30 14:24   ` Kamil Konieczny
2026-10-01  8:03     ` Ravali, JupallyX
2026-09-29 21:56 ` ✗ Xe.CI.FULL: " Patchwork
2026-09-30 14:33   ` Kamil Konieczny
2026-10-01  7:08 ` ✓ i915.CI.BAT: success " Patchwork
2026-10-02  7:02 ` ✓ i915.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260929154950.838280-1-alex.hung@amd.com \
    --to=alex.hung@amd.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.