All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Hung <alex.hung@amd.com>
To: <igt-dev@lists.freedesktop.org>
Cc: Alex Hung <alex.hung@amd.com>
Subject: [PATCH i-g-t v2 5/5] tests/msm_mapping: Keep parser buffers writable
Date: Tue, 29 Sep 2026 11:49:50 -0400	[thread overview]
Message-ID: <20260929154950.838280-6-alex.hung@amd.com> (raw)
In-Reply-To: <20260929154950.838280-1-alex.hung@amd.com>

With glibc 2.43, strstr() on const input returns a const pointer.
Assigning that result to char * in endswith() discards const and
causes a compiler warning.

The following warning is observed on Ubuntu 26.04 (wrapped):

  ../tests/msm/msm_mapping.c: In function 'endswith':
  ../tests/msm/msm_mapping.c:128:19: warning:
    initialization discards 'const' qualifier from pointer target type
    [-Wdiscarded-qualifiers]

Keep the get_line() return value, line pointer and endswith() input
writable because endswith() modifies the buffer. This preserves
mutable access through the parser without casting away const.

Assisted-by: Copilot:GPT-6-Astra
Signed-off-by: Alex Hung <alex.hung@amd.com>
---
 tests/msm/msm_mapping.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/msm/msm_mapping.c b/tests/msm/msm_mapping.c
index 05960627c..52b494abf 100644
--- a/tests/msm/msm_mapping.c
+++ b/tests/msm/msm_mapping.c
@@ -102,7 +102,7 @@ wait_for_stall_on_fault(int drm_fd)
  * Helper to find named buffer address
  */
 
-static const char *
+static char *
 get_line(char **buf)
 {
 	char *ret, *eol;
@@ -123,7 +123,7 @@ get_line(char **buf)
 }
 
 static bool
-endswith(const char *str, const char *end)
+endswith(char *str, const char *end)
 {
 	char *p = strstr(str, end);
 
@@ -166,7 +166,7 @@ get_bo_addr(int drm_fd, const char *name)
 	 */
 
 	while (*p) {
-		const char *line = get_line(&p);
+		char *line = get_line(&p);
 
 		if (endswith(line, name)) {
 			uint64_t addr, dummy;
-- 
2.53.0


  parent reply	other threads:[~2026-09-29 15:54 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-29 15:49 [PATCH i-g-t v2 0/5] Preserve const qualifiers in string parsing Alex Hung
2026-09-29 15:49 ` [PATCH i-g-t v2 1/5] benchmarks/gem_wsim: Preserve const qualifiers Alex Hung
2026-09-30 13:41   ` Kamil Konieczny
2026-09-29 15:49 ` [PATCH i-g-t v2 2/5] tools/intel_reg_spec: " Alex Hung
2026-09-30 13:43   ` Kamil Konieczny
2026-09-29 15:49 ` [PATCH i-g-t v2 3/5] lib: Preserve string " Alex Hung
2026-09-30 13:46   ` Kamil Konieczny
2026-09-29 15:49 ` [PATCH i-g-t v2 4/5] tests/i915_pm_sseu: Preserve " Alex Hung
2026-09-30 13:51   ` Kamil Konieczny
2026-09-29 15:49 ` Alex Hung [this message]
2026-09-30 13:55   ` [PATCH i-g-t v2 5/5] tests/msm_mapping: Keep parser buffers writable Kamil Konieczny
2026-09-30 14:32     ` Rob Clark
2026-10-02 14:17       ` Kamil Konieczny
2026-09-29 17:41 ` ✗ Xe.CI.BAT: failure for Preserve const qualifiers in string parsing (rev2) Patchwork
2026-09-30 14:24   ` Kamil Konieczny
2026-09-29 17:54 ` ✗ i915.CI.BAT: " Patchwork
2026-09-30 14:24   ` Kamil Konieczny
2026-10-01  8:03     ` Ravali, JupallyX
2026-09-29 21:56 ` ✗ Xe.CI.FULL: " Patchwork
2026-09-30 14:33   ` Kamil Konieczny
2026-10-01  7:08 ` ✓ i915.CI.BAT: success " Patchwork
2026-10-02  7:02 ` ✓ i915.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260929154950.838280-6-alex.hung@amd.com \
    --to=alex.hung@amd.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.