From: Jason Gunthorpe <jgg@nvidia.com>
To: Simon Song <xinmengs@nvidia.com>
Cc: alex@shazbot.org, dakr@kernel.org, acourbot@nvidia.com,
yishaih@nvidia.com, skolothumtho@nvidia.com,
kevin.tian@intel.com, jhubbard@nvidia.com, ecourtney@nvidia.com,
cjia@nvidia.com, smitra@nvidia.com, kjaju@nvidia.com,
alkumar@nvidia.com, ankita@nvidia.com, aniketa@nvidia.com,
kwankhede@nvidia.com, targupta@nvidia.com,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
zhiwang@kernel.org, zhiw@nvidia.com,
Alex Williamson <alex.williamson@nvidia.com>
Subject: Re: [PATCH 1/1] vfio/pci: Remove the core dependency on driver data
Date: Tue, 29 Sep 2026 16:43:25 -0300 [thread overview]
Message-ID: <20260929194325.GP1616761@nvidia.com> (raw)
In-Reply-To: <20260929173102.3544151-2-xinmengs@nvidia.com>
On Tue, Sep 29, 2026 at 10:31:01AM -0700, Simon Song wrote:
> +#define VFIO_PCI_CORE_DEFINE_CALLBACKS(name) \
> +static int __maybe_unused name##_pm_suspend(struct device *dev) \
> +{ \
> + return vfio_pci_core_runtime_suspend(dev_get_drvdata(dev)); \
That's completely not the point, these macros need to cast it to the
drivers struct first and then dereference the core struct by member
name.
Jason
next parent reply other threads:[~2026-09-29 19:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260929173102.3544151-1-xinmengs@nvidia.com>
[not found] ` <20260929173102.3544151-2-xinmengs@nvidia.com>
2026-09-29 19:43 ` Jason Gunthorpe [this message]
2026-09-29 20:42 ` [PATCH 1/1] vfio/pci: Remove the core dependency on driver data Alex Williamson
2026-09-29 21:02 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260929194325.GP1616761@nvidia.com \
--to=jgg@nvidia.com \
--cc=acourbot@nvidia.com \
--cc=alex.williamson@nvidia.com \
--cc=alex@shazbot.org \
--cc=alkumar@nvidia.com \
--cc=aniketa@nvidia.com \
--cc=ankita@nvidia.com \
--cc=cjia@nvidia.com \
--cc=dakr@kernel.org \
--cc=ecourtney@nvidia.com \
--cc=jhubbard@nvidia.com \
--cc=kevin.tian@intel.com \
--cc=kjaju@nvidia.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=skolothumtho@nvidia.com \
--cc=smitra@nvidia.com \
--cc=targupta@nvidia.com \
--cc=xinmengs@nvidia.com \
--cc=yishaih@nvidia.com \
--cc=zhiw@nvidia.com \
--cc=zhiwang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.