From: "Danilo Krummrich" <dakr@kernel.org>
To: "Alex Williamson" <alex.williamson@nvidia.com>
Cc: "Jason Gunthorpe" <jgg@nvidia.com>,
"Simon Song" <xinmengs@nvidia.com>, <acourbot@nvidia.com>,
<yishaih@nvidia.com>, <skolothumtho@nvidia.com>,
<kevin.tian@intel.com>, <jhubbard@nvidia.com>,
<ecourtney@nvidia.com>, <cjia@nvidia.com>, <smitra@nvidia.com>,
<kjaju@nvidia.com>, <alkumar@nvidia.com>, <ankita@nvidia.com>,
<aniketa@nvidia.com>, <kwankhede@nvidia.com>,
<targupta@nvidia.com>, <linux-kernel@vger.kernel.org>,
<kvm@vger.kernel.org>, <zhiwang@kernel.org>, <zhiw@nvidia.com>
Subject: Re: [PATCH 1/1] vfio/pci: Remove the core dependency on driver data
Date: Tue, 29 Sep 2026 23:02:20 +0200 [thread overview]
Message-ID: <DLS3R2DXNZLC.32236MQO2JOTJ@kernel.org> (raw)
In-Reply-To: <20260929144243.5cb913a0@nvidia.com>
On Tue Sep 29, 2026 at 10:42 PM CEST, Alex Williamson wrote:
> @@ -552,13 +560,16 @@ static int xe_vfio_pci_probe(struct pci_dev *pdev, const struct pci_device_id *i
>
> dev_set_drvdata(&pdev->dev, &xe_vdev->core_device);
>
> - ret = vfio_pci_core_register_device(&xe_vdev->core_device);
> - if (ret) {
> - vfio_put_device(&xe_vdev->core_device.vdev);
> - return ret;
> - }
> + ret = vfio_pci_core_register_device(&xe_vdev->core_device,
> + xe_vfio_vga_set_decode);
> + if (ret)
> + goto out_put_vdev;
>
> return 0;
> +
> +out_put_vdev:
> + vfio_put_device(&xe_vdev->core_device.vdev);
> + return ret;
> }
NIT: Except for the new function argument this change seems unrelated; I suppose
the clanker did this following the cleanup pattern used by most of the other
drivers.
prev parent reply other threads:[~2026-09-29 21:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260929173102.3544151-1-xinmengs@nvidia.com>
[not found] ` <20260929173102.3544151-2-xinmengs@nvidia.com>
2026-09-29 19:43 ` [PATCH 1/1] vfio/pci: Remove the core dependency on driver data Jason Gunthorpe
2026-09-29 20:42 ` Alex Williamson
2026-09-29 21:02 ` Danilo Krummrich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DLS3R2DXNZLC.32236MQO2JOTJ@kernel.org \
--to=dakr@kernel.org \
--cc=acourbot@nvidia.com \
--cc=alex.williamson@nvidia.com \
--cc=alkumar@nvidia.com \
--cc=aniketa@nvidia.com \
--cc=ankita@nvidia.com \
--cc=cjia@nvidia.com \
--cc=ecourtney@nvidia.com \
--cc=jgg@nvidia.com \
--cc=jhubbard@nvidia.com \
--cc=kevin.tian@intel.com \
--cc=kjaju@nvidia.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=skolothumtho@nvidia.com \
--cc=smitra@nvidia.com \
--cc=targupta@nvidia.com \
--cc=xinmengs@nvidia.com \
--cc=yishaih@nvidia.com \
--cc=zhiw@nvidia.com \
--cc=zhiwang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.