Re: [PATCH v5 1/4] arm64: dts: qcom: shikra: Add MDSS display subsystem

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dts: incorrect over-indentation of the mdss node
--

commit c036145cd42553cee75513d9d43a23d346a733a4
Author: Nabige Aala <nabige.aala@oss.qualcomm.com>

arm64: dts: qcom: shikra: Add MDSS display subsystem

This commit adds the SoC-level display subsystem nodes for Qualcomm Shikra,
including the MDSS wrapper, DPU display controller, DSI host controller,
and 14nm DSI PHY.

> diff --git a/arch/arm64/boot/dts/qcom/shikra.dtsi b/arch/arm64/boot/dts/qcom/shikra.dtsi
> index 9823c591b02b1..4ff85c1c8fddc 100644
> --- a/arch/arm64/boot/dts/qcom/shikra.dtsi
> +++ b/arch/arm64/boot/dts/qcom/shikra.dtsi

[ ... ]

> @@ -2809,6 +2810,207 @@ adreno_smmu: iommu@59a0000 {
>  			power-domains = <&gpucc GPU_CX_GDSC>;
>  		};
>  
> +				mdss: display-subsystem@5e00000 {
> +			compatible = "qcom,shikra-mdss", "qcom,qcm2290-mdss";

[Severity: Low]
This isn't a bug, but does the mdss node have incorrect over-indentation here?

The node is declared with 4 tabs, while its properties (e.g., compatible)
and children use 3 tabs, and its siblings use 2 tabs. This creates visually
confusing formatting where a parent is indented further than its children.
Could this be adjusted to match standard device tree coding style?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260930-shikra-dt-changes-v5-0-8eaf658a0e38@oss.qualcomm.com?part=1