Re: [PATCH v5 2/4] arm64: dts: qcom: shikra-cqs-evk: Enable display and add ili7807s panel

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [High] dts: panel ilitek,ili7807s ignores invalid wled-supply leaving backlight disabled
- [High] dts: missing pinctrl configuration for vreg_wled GPIO 91
--

commit d926189f53e6ce7f475ac9993bc0332fb49bcb7f
Author: Arpit Saini <arpit.saini@oss.qualcomm.com>

arm64: dts: qcom: shikra-cqs-evk: Enable display and add ili7807s panel
    
Enable the Shikra MDSS display subsystem on the Qualcomm Shikra CQS EVK
board and add the DLC0697 MIPI DSI display panel node.

> diff --git a/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts b/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts
> index 7a2f3e1518fdb..5e49a5c71a777 100644
> --- a/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts
> +++ b/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts
> @@ -23,6 +23,86 @@ aliases {
[ ... ]
> +	vreg_wled: regulator-wled {
> +		compatible = "regulator-fixed";
> +		regulator-name = "vreg_wled";
> +		gpio = <&tlmm 91 GPIO_ACTIVE_HIGH>;
> +		enable-active-high;
> +	};

[Severity: High]
Does this regulator definition need a pinctrl configuration for gpio 91?

Without explicitly configuring the pin muxing to a GPIO output function with
appropriate drive strength and bias, the pin may remain in an alternate
function or High-Z state left by the bootloader, causing attempts to enable
the backlight power to fail silently during hardware initialization.

> +};
> +
> +&mdss {
> +	status = "okay";
> +};
> +
> +&mdss_dsi0 {
> +	vdda-supply = <&pm4125_l5>;
> +
> +	status = "okay";
> +
> +	panel@0 {
> +		compatible = "dlc,dlc0697", "ilitek,ili7807s";
> +		reg = <0>;
> +
> +		reset-gpios = <&tlmm 3 GPIO_ACTIVE_LOW>;
> +
> +		vddi-supply = <&pm4125_l15>;
> +		avdd-supply = <&vreg_disp_p>;
> +		avee-supply = <&vreg_disp_n>;
> +		wled-supply = <&vreg_wled>;

[Severity: High]
Is wled-supply supported by the ilitek,ili7807s panel binding and driver?

The ilitek,ili7807s device tree binding specifies unevaluatedProperties: false,
which makes wled-supply invalid and ignored by the panel-ilitek-ili7807s.c
driver.

Since vreg_wled lacks regulator-always-on and is not successfully tied to a
consumer that will enable it, it defaults to off, leaving the display backlight
hardware unpowered and the screen dark on the Shikra CQS EVK or CQM EVK boards.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260930-shikra-dt-changes-v5-0-8eaf658a0e38@oss.qualcomm.com?part=2