[PATCH] drm/virtio: add ARGB8888 support for primary planes

[PATCH] drm/virtio: add ARGB8888 support for primary planes

[Dorinda Bassey]

Add DRM_FORMAT_HOST_ARGB8888 to the list of supported formats for
virtio-gpu primary planes. Without this, glmark2-drm fails at
startup because it selects ARGB visual configs by default, which
don't match the XRGB-only plane capabilities. This causes
drmModeSetCrtc to fail with EINVAL.

The virtio_gpu_translate_format() function already handles
ARGB8888 translation to VIRTIO_GPU_FORMAT_B8G8R8A8_UNORM,
so this just exposes the existing capability to userspace.

Signed-off-by: Dorinda Bassey <dbassey@redhat.com>
---
 drivers/gpu/drm/virtio/virtgpu_plane.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/virtio/virtgpu_plane.c b/drivers/gpu/drm/virtio/virtgpu_plane.c
index b422eba42a5f..5f0bc1b1931b 100644
--- a/drivers/gpu/drm/virtio/virtgpu_plane.c
+++ b/drivers/gpu/drm/virtio/virtgpu_plane.c
@@ -37,6 +37,7 @@
 
 static const uint32_t virtio_gpu_formats[] = {
 	DRM_FORMAT_HOST_XRGB8888,
+	DRM_FORMAT_HOST_ARGB8888,
 };
 
 static const uint32_t virtio_gpu_cursor_formats[] = {
-- 
2.55.0

Re: [PATCH] drm/virtio: add ARGB8888 support for primary planes

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] drm/virtio: missing blend mode property for primary planes with alpha format
--

commit 9355c68bd37dd7d0e90b6eec00d769a8fd8ff04f
Author: Dorinda Bassey <dbassey@redhat.com>

    drm/virtio: add ARGB8888 support for primary planes
    
    Add DRM_FORMAT_HOST_ARGB8888 to the list of supported formats for
    virtio-gpu primary planes. Without this, glmark2-drm fails at
    startup because it selects ARGB visual configs by default, which
    don't match the XRGB-only plane capabilities. This causes
    drmModeSetCrtc to fail with EINVAL.

> diff --git a/drivers/gpu/drm/virtio/virtgpu_plane.c b/drivers/gpu/drm/virtio/virtgpu_plane.c
> index 10718bc736939..eef9ef42dffea 100644
> --- a/drivers/gpu/drm/virtio/virtgpu_plane.c
> +++ b/drivers/gpu/drm/virtio/virtgpu_plane.c
> @@ -38,6 +38,7 @@
>  
>  static const uint32_t virtio_gpu_formats[] = {
>  	DRM_FORMAT_HOST_XRGB8888,
> +	DRM_FORMAT_HOST_ARGB8888,
>  };

[Severity: Medium]
Does adding ARGB8888 support here also require adding a blend mode property
for the primary plane?

Looking at virtio_gpu_plane_init() in drivers/gpu/drm/virtio/virtgpu_plane.c,
the blend mode property is currently only created for cursor planes:

	if (type == DRM_PLANE_TYPE_PRIMARY)
		drm_plane_enable_fb_damage_clips(plane);
	else if (type == DRM_PLANE_TYPE_CURSOR)
		drm_plane_create_blend_mode_property(plane,
						     BIT(DRM_MODE_BLEND_PREMULTI));

Since the primary plane now exposes a format with an alpha channel
(DRM_FORMAT_HOST_ARGB8888), userspace compositors (like Wayland/Mutter) will
expect a blend mode property.

When a DRM client queries the properties of the primary plane after the
driver exposes this format, the missing blend mode property may prevent
userspace from correctly discovering or configuring the blend state. This
can potentially lead to incorrect blending or fallback to software
composition.

Should the primary plane also be updated to create the blend mode property in
virtio_gpu_plane_init()?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260930132707.500748-1-dbassey@redhat.com?part=1

Re: [PATCH] drm/virtio: add ARGB8888 support for primary planes

[Thomas Zimmermann]

Hi

Am 30.09.26 um 15:27 schrieb Dorinda Bassey:
> Add DRM_FORMAT_HOST_ARGB8888 to the list of supported formats for
> virtio-gpu primary planes. Without this, glmark2-drm fails at
> startup because it selects ARGB visual configs by default, which
> don't match the XRGB-only plane capabilities. This causes
> drmModeSetCrtc to fail with EINVAL.

But does the host also support ARGB on the primary plane? We usually 
don't export formats that are not available in (virtual) hardware.

Best regards
Thomas

>
> The virtio_gpu_translate_format() function already handles
> ARGB8888 translation to VIRTIO_GPU_FORMAT_B8G8R8A8_UNORM,
> so this just exposes the existing capability to userspace.
>
> Signed-off-by: Dorinda Bassey <dbassey@redhat.com>
> ---
>   drivers/gpu/drm/virtio/virtgpu_plane.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/virtio/virtgpu_plane.c b/drivers/gpu/drm/virtio/virtgpu_plane.c
> index b422eba42a5f..5f0bc1b1931b 100644
> --- a/drivers/gpu/drm/virtio/virtgpu_plane.c
> +++ b/drivers/gpu/drm/virtio/virtgpu_plane.c
> @@ -37,6 +37,7 @@
>   
>   static const uint32_t virtio_gpu_formats[] = {
>   	DRM_FORMAT_HOST_XRGB8888,
> +	DRM_FORMAT_HOST_ARGB8888,
>   };
>   
>   static const uint32_t virtio_gpu_cursor_formats[] = {

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Stefan Gaiser, Jochen Jaser, Abhinav Puri, (HRB 36809, AG Nürnberg)

Re: [PATCH] drm/virtio: add ARGB8888 support for primary planes

[Dorinda Bassey]

[-- Attachment #1: Type: text/plain, Size: 2711 bytes --]

Hi Thomas,

But does the host also support ARGB on the primary plane? We usually
> don't export formats that are not available in (virtual) hardware.


If you're asking about the hypervisor side providing the Virtual GPU,
Yes the host supports ARGB on primary plane. QEMU's virtio-gpu
supports this see qemu's include/hw/virtio/virtio-gpu-pixman.h:26
libkrun's virtio-gpu includes `B8G8R8A8_UNORM` in its
ResourceFormat enum and maps it to display backend formats.
Virglrenderer, which vhost-device-gpu also uses, maps
`GBM_FORMAT_ARGB8888` to `VIRGL_FORMAT_B8G8R8A8_UNORM`.
Other VMMs I've tested also support this format.

Also I see the cursor plane in the virtio-gpu driver already exposes
`DRM_FORMAT_HOST_ARGB8888`, confirming existing ARGB support
in backends. I tested this with the vhost-user-gpu backend from -
https://github.com/rust-vmm/vhost-device/tree/main/vhost-device-gpu
and the libkrun guest, glmark2-drm renders correctly with it.

BR,
Dorinda.


On Wed, Sep 30, 2026 at 5:04 PM Thomas Zimmermann <tzimmermann@suse.de>
wrote:

> Hi
>
> Am 30.09.26 um 15:27 schrieb Dorinda Bassey:
> > Add DRM_FORMAT_HOST_ARGB8888 to the list of supported formats for
> > virtio-gpu primary planes. Without this, glmark2-drm fails at
> > startup because it selects ARGB visual configs by default, which
> > don't match the XRGB-only plane capabilities. This causes
> > drmModeSetCrtc to fail with EINVAL.
>
> But does the host also support ARGB on the primary plane? We usually
> don't export formats that are not available in (virtual) hardware.
>
> Best regards
> Thomas
>
> >
> > The virtio_gpu_translate_format() function already handles
> > ARGB8888 translation to VIRTIO_GPU_FORMAT_B8G8R8A8_UNORM,
> > so this just exposes the existing capability to userspace.
> >
> > Signed-off-by: Dorinda Bassey <dbassey@redhat.com>
> > ---
> >   drivers/gpu/drm/virtio/virtgpu_plane.c | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/virtio/virtgpu_plane.c
> b/drivers/gpu/drm/virtio/virtgpu_plane.c
> > index b422eba42a5f..5f0bc1b1931b 100644
> > --- a/drivers/gpu/drm/virtio/virtgpu_plane.c
> > +++ b/drivers/gpu/drm/virtio/virtgpu_plane.c
> > @@ -37,6 +37,7 @@
> >
> >   static const uint32_t virtio_gpu_formats[] = {
> >       DRM_FORMAT_HOST_XRGB8888,
> > +     DRM_FORMAT_HOST_ARGB8888,
> >   };
> >
> >   static const uint32_t virtio_gpu_cursor_formats[] = {
>
> --
> --
> Thomas Zimmermann
> Graphics Driver Developer
> SUSE Software Solutions Germany GmbH
> Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
> GF: Stefan Gaiser, Jochen Jaser, Abhinav Puri, (HRB 36809, AG Nürnberg)
>
>
>

[-- Attachment #2: Type: text/html, Size: 3784 bytes --]

Re: [PATCH] drm/virtio: add ARGB8888 support for primary planes

[Thomas Zimmermann]

Am 30.09.26 um 18:12 schrieb Dorinda Bassey:
> Hi Thomas,
>
>     But does the host also support ARGB on the primary plane? We usually
>     don't export formats that are not available in (virtual) hardware.
>
>
> If you're asking about the hypervisor side providing the Virtual GPU,
> Yes the host supports ARGB on primary plane. QEMU's virtio-gpu

Ok, thanks.

Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>


> supports this see qemu's include/hw/virtio/virtio-gpu-pixman.h:26
> libkrun's virtio-gpu includes `B8G8R8A8_UNORM` in its
> ResourceFormat enum and maps it to display backend formats.
> Virglrenderer, which vhost-device-gpu also uses, maps
> `GBM_FORMAT_ARGB8888` to `VIRGL_FORMAT_B8G8R8A8_UNORM`.
> Other VMMs I've tested also support this format.
>
> Also I see the cursor plane in the virtio-gpu driver already exposes
> `DRM_FORMAT_HOST_ARGB8888`, confirming existing ARGB support
> in backends. I tested this with the vhost-user-gpu backend from -
> https://github.com/rust-vmm/vhost-device/tree/main/vhost-device-gpu
> and the libkrun guest, glmark2-drm renders correctly with it.
>
> BR,
> Dorinda.
>
>
> On Wed, Sep 30, 2026 at 5:04 PM Thomas Zimmermann 
> <tzimmermann@suse.de> wrote:
>
>     Hi
>
>     Am 30.09.26 um 15:27 schrieb Dorinda Bassey:
>     > Add DRM_FORMAT_HOST_ARGB8888 to the list of supported formats for
>     > virtio-gpu primary planes. Without this, glmark2-drm fails at
>     > startup because it selects ARGB visual configs by default, which
>     > don't match the XRGB-only plane capabilities. This causes
>     > drmModeSetCrtc to fail with EINVAL.
>
>     But does the host also support ARGB on the primary plane? We usually
>     don't export formats that are not available in (virtual) hardware.
>
>     Best regards
>     Thomas
>
>     >
>     > The virtio_gpu_translate_format() function already handles
>     > ARGB8888 translation to VIRTIO_GPU_FORMAT_B8G8R8A8_UNORM,
>     > so this just exposes the existing capability to userspace.
>     >
>     > Signed-off-by: Dorinda Bassey <dbassey@redhat.com>
>     > ---
>     >   drivers/gpu/drm/virtio/virtgpu_plane.c | 1 +
>     >   1 file changed, 1 insertion(+)
>     >
>     > diff --git a/drivers/gpu/drm/virtio/virtgpu_plane.c
>     b/drivers/gpu/drm/virtio/virtgpu_plane.c
>     > index b422eba42a5f..5f0bc1b1931b 100644
>     > --- a/drivers/gpu/drm/virtio/virtgpu_plane.c
>     > +++ b/drivers/gpu/drm/virtio/virtgpu_plane.c
>     > @@ -37,6 +37,7 @@
>     >
>     >   static const uint32_t virtio_gpu_formats[] = {
>     >       DRM_FORMAT_HOST_XRGB8888,
>     > +     DRM_FORMAT_HOST_ARGB8888,
>     >   };
>     >
>     >   static const uint32_t virtio_gpu_cursor_formats[] = {
>
>     -- 
>     --
>     Thomas Zimmermann
>     Graphics Driver Developer
>     SUSE Software Solutions Germany GmbH
>     Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
>     <http://www.suse.com>
>     GF: Stefan Gaiser, Jochen Jaser, Abhinav Puri, (HRB 36809, AG
>     Nürnberg)
>
>

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Stefan Gaiser, Jochen Jaser, Abhinav Puri, (HRB 36809, AG Nürnberg)

Re: [PATCH] drm/virtio: add ARGB8888 support for primary planes

[Dmitry Osipenko]

On 9/30/26 18:03, Thomas Zimmermann wrote:
> Hi
> 
> Am 30.09.26 um 15:27 schrieb Dorinda Bassey:
>> Add DRM_FORMAT_HOST_ARGB8888 to the list of supported formats for
>> virtio-gpu primary planes. Without this, glmark2-drm fails at
>> startup because it selects ARGB visual configs by default, which
>> don't match the XRGB-only plane capabilities. This causes
>> drmModeSetCrtc to fail with EINVAL.
> 
> But does the host also support ARGB on the primary plane? We usually
> don't export formats that are not available in (virtual) hardware.
> 
> Best regards
> Thomas
> 
>>
>> The virtio_gpu_translate_format() function already handles
>> ARGB8888 translation to VIRTIO_GPU_FORMAT_B8G8R8A8_UNORM,
>> so this just exposes the existing capability to userspace.
>>
>> Signed-off-by: Dorinda Bassey <dbassey@redhat.com>
>> ---
>>   drivers/gpu/drm/virtio/virtgpu_plane.c | 1 +
>>   1 file changed, 1 insertion(+)

For primary plane, alpha channel often doesn't matter as primary has
fixed z=0 order and a usual alpha blending mode would account only
overlay's alpha channel. Many real hw drivers expose alpha-channel
formats for primary plane for compatibility with userspace, even though
for them the alpha has no meaning for the primary plane.

QEMU is most popular VMM using virtio-gpu, but there are others. For a
stricter compatibility we can translate B8G8R8A8 to X8R8G8B8 for the
primary plane in the driver code, but I assume in practice it's very
unlike this will be necessary and we can always do it later on if will
be needed.

The change looks okay, will apply after testing.

-- 
Best regards,
Dmitry

Re: [PATCH] drm/virtio: add ARGB8888 support for primary planes

[Thomas Zimmermann]

Hi

Am 01.10.26 um 12:46 schrieb Dmitry Osipenko:
> On 9/30/26 18:03, Thomas Zimmermann wrote:
>> Hi
>>
>> Am 30.09.26 um 15:27 schrieb Dorinda Bassey:
>>> Add DRM_FORMAT_HOST_ARGB8888 to the list of supported formats for
>>> virtio-gpu primary planes. Without this, glmark2-drm fails at
>>> startup because it selects ARGB visual configs by default, which
>>> don't match the XRGB-only plane capabilities. This causes
>>> drmModeSetCrtc to fail with EINVAL.
>> But does the host also support ARGB on the primary plane? We usually
>> don't export formats that are not available in (virtual) hardware.
>>
>> Best regards
>> Thomas
>>
>>> The virtio_gpu_translate_format() function already handles
>>> ARGB8888 translation to VIRTIO_GPU_FORMAT_B8G8R8A8_UNORM,
>>> so this just exposes the existing capability to userspace.
>>>
>>> Signed-off-by: Dorinda Bassey <dbassey@redhat.com>
>>> ---
>>>    drivers/gpu/drm/virtio/virtgpu_plane.c | 1 +
>>>    1 file changed, 1 insertion(+)
> For primary plane, alpha channel often doesn't matter as primary has
> fixed z=0 order and a usual alpha blending mode would account only
> overlay's alpha channel. Many real hw drivers expose alpha-channel
> formats for primary plane for compatibility with userspace, even though
> for them the alpha has no meaning for the primary plane.

We decidedly do not offer formats that are not native to the hardware; 
except for adding XRGB888.


>
> QEMU is most popular VMM using virtio-gpu, but there are others. For a
> stricter compatibility we can translate B8G8R8A8 to X8R8G8B8 for the
> primary plane in the driver code, but I assume in practice it's very
> unlike this will be necessary and we can always do it later on if will
> be needed.

No in-kernel format conversion please; again except for adding XRGB8888.

Best regards
Thomas


>
> The change looks okay, will apply after testing.
>

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Stefan Gaiser, Jochen Jaser, Abhinav Puri, (HRB 36809, AG Nürnberg)

Re: [PATCH] drm/virtio: add ARGB8888 support for primary planes

[Dmitry Osipenko]

On 10/1/26 16:31, Thomas Zimmermann wrote:
> Hi
> 
> Am 01.10.26 um 12:46 schrieb Dmitry Osipenko:
>> On 9/30/26 18:03, Thomas Zimmermann wrote:
>>> Hi
>>>
>>> Am 30.09.26 um 15:27 schrieb Dorinda Bassey:
>>>> Add DRM_FORMAT_HOST_ARGB8888 to the list of supported formats for
>>>> virtio-gpu primary planes. Without this, glmark2-drm fails at
>>>> startup because it selects ARGB visual configs by default, which
>>>> don't match the XRGB-only plane capabilities. This causes
>>>> drmModeSetCrtc to fail with EINVAL.
>>> But does the host also support ARGB on the primary plane? We usually
>>> don't export formats that are not available in (virtual) hardware.
>>>
>>> Best regards
>>> Thomas
>>>
>>>> The virtio_gpu_translate_format() function already handles
>>>> ARGB8888 translation to VIRTIO_GPU_FORMAT_B8G8R8A8_UNORM,
>>>> so this just exposes the existing capability to userspace.
>>>>
>>>> Signed-off-by: Dorinda Bassey <dbassey@redhat.com>
>>>> ---
>>>>    drivers/gpu/drm/virtio/virtgpu_plane.c | 1 +
>>>>    1 file changed, 1 insertion(+)
>> For primary plane, alpha channel often doesn't matter as primary has
>> fixed z=0 order and a usual alpha blending mode would account only
>> overlay's alpha channel. Many real hw drivers expose alpha-channel
>> formats for primary plane for compatibility with userspace, even though
>> for them the alpha has no meaning for the primary plane.
> 
> We decidedly do not offer formats that are not native to the hardware;
> except for adding XRGB888.
> 
> 
>>
>> QEMU is most popular VMM using virtio-gpu, but there are others. For a
>> stricter compatibility we can translate B8G8R8A8 to X8R8G8B8 for the
>> primary plane in the driver code, but I assume in practice it's very
>> unlike this will be necessary and we can always do it later on if will
>> be needed.
> 
> No in-kernel format conversion please; again except for adding XRGB8888.

Chances are low this may ever become necessary. Confirm glmark2-drm now
works with this change.

Applied to misc-next

-- 
Best regards,
Dmitry