* [LTP] [PATCH] accept02: Join the multicast group on lo
@ 2026-09-28 21:27 Anders Roxell
2026-09-28 23:50 ` [LTP] " linuxtestproject.agent
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Anders Roxell @ 2026-09-28 21:27 UTC (permalink / raw)
To: ltp
The test joins the multicast group with interface 0. Then the kernel
needs a route to 224.0.0.0 to find a device. When we only have lo,
like in a QEMU guest with no network, there is no such route and the
test breaks:
accept02.c:52: TBROK: setsockopt(3, 0, 42, ...) failed: ENODEV (19)
All traffic in the test goes over 127.0.0.1, so join the group on lo.
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
---
testcases/kernel/syscalls/accept/accept02.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/testcases/kernel/syscalls/accept/accept02.c b/testcases/kernel/syscalls/accept/accept02.c
index 17056625e933..09a1c35e2591 100644
--- a/testcases/kernel/syscalls/accept/accept02.c
+++ b/testcases/kernel/syscalls/accept/accept02.c
@@ -22,6 +22,7 @@
#include <errno.h>
#include <sys/socket.h>
#include "tst_test.h"
+#include "tst_netdevice.h"
#include "tst_safe_net.h"
#include "tst_safe_pthread.h"
@@ -112,7 +113,7 @@ static void setup(void)
client_addr = tst_alloc(sizeof(*client_addr));
mc_group = tst_alloc(sizeof(*mc_group));
- mc_group->gr_interface = 0;
+ mc_group->gr_interface = NETDEV_INDEX_BY_NAME("lo");
mc_group_addr = (struct sockaddr_in *) &mc_group->gr_group;
mc_group_addr->sin_family = AF_INET;
inet_aton(MULTICASTIP, &mc_group_addr->sin_addr);
--
2.53.0
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [LTP] accept02: Join the multicast group on lo
2026-09-28 21:27 [LTP] [PATCH] accept02: Join the multicast group on lo Anders Roxell
@ 2026-09-28 23:50 ` linuxtestproject.agent
2026-09-30 12:53 ` [LTP] [PATCH] " Petr Vorel
2026-09-30 14:19 ` Martin Doucha
2 siblings, 0 replies; 6+ messages in thread
From: linuxtestproject.agent @ 2026-09-28 23:50 UTC (permalink / raw)
To: Anders Roxell; +Cc: ltp
Hi Anders,
On Mon Sep 28 23:27:33 2026 +0200, Anders Roxell wrote:
> accept02: Join the multicast group on lo
Verdict - Reviewed
---
Note:
The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.
Regards,
LTP AI Reviewer
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [LTP] [PATCH] accept02: Join the multicast group on lo
2026-09-28 21:27 [LTP] [PATCH] accept02: Join the multicast group on lo Anders Roxell
2026-09-28 23:50 ` [LTP] " linuxtestproject.agent
@ 2026-09-30 12:53 ` Petr Vorel
2026-09-30 14:10 ` Petr Vorel
2026-09-30 14:19 ` Martin Doucha
2 siblings, 1 reply; 6+ messages in thread
From: Petr Vorel @ 2026-09-30 12:53 UTC (permalink / raw)
To: Anders Roxell; +Cc: Martin Doucha, ltp
Hi Anders, all,
> The test joins the multicast group with interface 0. Then the kernel
> needs a route to 224.0.0.0 to find a device. When we only have lo,
> like in a QEMU guest with no network, there is no such route and the
> test breaks:
> accept02.c:52: TBROK: setsockopt(3, 0, 42, ...) failed: ENODEV (19)
> All traffic in the test goes over 127.0.0.1, so join the group on lo.
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> ---
> testcases/kernel/syscalls/accept/accept02.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
> diff --git a/testcases/kernel/syscalls/accept/accept02.c b/testcases/kernel/syscalls/accept/accept02.c
> index 17056625e933..09a1c35e2591 100644
> --- a/testcases/kernel/syscalls/accept/accept02.c
> +++ b/testcases/kernel/syscalls/accept/accept02.c
> @@ -22,6 +22,7 @@
> #include <errno.h>
> #include <sys/socket.h>
> #include "tst_test.h"
> +#include "tst_netdevice.h"
> #include "tst_safe_net.h"
> #include "tst_safe_pthread.h"
> @@ -112,7 +113,7 @@ static void setup(void)
> client_addr = tst_alloc(sizeof(*client_addr));
> mc_group = tst_alloc(sizeof(*mc_group));
> - mc_group->gr_interface = 0;
> + mc_group->gr_interface = NETDEV_INDEX_BY_NAME("lo");
Reviewed-by: Petr Vorel <pvorel@suse.cz>
I tested that it really fixes the problem when no network and runs ok.
But I'm not 100% sure that it did not affect the CVE reproducibility.
Therefore I do not add my TBT.
Kind regards,
Petr
> mc_group_addr = (struct sockaddr_in *) &mc_group->gr_group;
> mc_group_addr->sin_family = AF_INET;
> inet_aton(MULTICASTIP, &mc_group_addr->sin_addr);
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [LTP] [PATCH] accept02: Join the multicast group on lo
2026-09-30 12:53 ` [LTP] [PATCH] " Petr Vorel
@ 2026-09-30 14:10 ` Petr Vorel
0 siblings, 0 replies; 6+ messages in thread
From: Petr Vorel @ 2026-09-30 14:10 UTC (permalink / raw)
To: Anders Roxell, Martin Doucha, ltp
> Hi Anders, all,
> > The test joins the multicast group with interface 0. Then the kernel
> > needs a route to 224.0.0.0 to find a device. When we only have lo,
> > like in a QEMU guest with no network, there is no such route and the
> > test breaks:
> > accept02.c:52: TBROK: setsockopt(3, 0, 42, ...) failed: ENODEV (19)
> > All traffic in the test goes over 127.0.0.1, so join the group on lo.
> > Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> > ---
> > testcases/kernel/syscalls/accept/accept02.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> > diff --git a/testcases/kernel/syscalls/accept/accept02.c b/testcases/kernel/syscalls/accept/accept02.c
> > index 17056625e933..09a1c35e2591 100644
> > --- a/testcases/kernel/syscalls/accept/accept02.c
> > +++ b/testcases/kernel/syscalls/accept/accept02.c
> > @@ -22,6 +22,7 @@
> > #include <errno.h>
> > #include <sys/socket.h>
> > #include "tst_test.h"
> > +#include "tst_netdevice.h"
> > #include "tst_safe_net.h"
> > #include "tst_safe_pthread.h"
> > @@ -112,7 +113,7 @@ static void setup(void)
> > client_addr = tst_alloc(sizeof(*client_addr));
> > mc_group = tst_alloc(sizeof(*mc_group));
> > - mc_group->gr_interface = 0;
> > + mc_group->gr_interface = NETDEV_INDEX_BY_NAME("lo");
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
> I tested that it really fixes the problem when no network and runs ok.
> But I'm not 100% sure that it did not affect the CVE reproducibility.
> Therefore I do not add my TBT.
And unfortunately this should be really verified if the change does not affect
reproducibility. Hopefully Martin will get time for that soon, but this will for
sure will not make it into the release planned for today.
Kind regards,
Petr
> Kind regards,
> Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [LTP] [PATCH] accept02: Join the multicast group on lo
2026-09-28 21:27 [LTP] [PATCH] accept02: Join the multicast group on lo Anders Roxell
2026-09-28 23:50 ` [LTP] " linuxtestproject.agent
2026-09-30 12:53 ` [LTP] [PATCH] " Petr Vorel
@ 2026-09-30 14:19 ` Martin Doucha
2026-09-30 14:28 ` Petr Vorel
2 siblings, 1 reply; 6+ messages in thread
From: Martin Doucha @ 2026-09-30 14:19 UTC (permalink / raw)
To: Anders Roxell, ltp
Hi,
I've tested the patch on affected kernel v4.4 and the bug is still
reproducible. Let's merge it.
Reviewed-by: Martin Doucha <mdoucha@suse.cz>
Tested-by: Martin Doucha <mdoucha@suse.cz>
On 9/28/26 23:27, Anders Roxell wrote:
> The test joins the multicast group with interface 0. Then the kernel
> needs a route to 224.0.0.0 to find a device. When we only have lo,
> like in a QEMU guest with no network, there is no such route and the
> test breaks:
>
> accept02.c:52: TBROK: setsockopt(3, 0, 42, ...) failed: ENODEV (19)
>
> All traffic in the test goes over 127.0.0.1, so join the group on lo.
>
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> ---
> testcases/kernel/syscalls/accept/accept02.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/testcases/kernel/syscalls/accept/accept02.c b/testcases/kernel/syscalls/accept/accept02.c
> index 17056625e933..09a1c35e2591 100644
> --- a/testcases/kernel/syscalls/accept/accept02.c
> +++ b/testcases/kernel/syscalls/accept/accept02.c
> @@ -22,6 +22,7 @@
> #include <errno.h>
> #include <sys/socket.h>
> #include "tst_test.h"
> +#include "tst_netdevice.h"
> #include "tst_safe_net.h"
> #include "tst_safe_pthread.h"
>
> @@ -112,7 +113,7 @@ static void setup(void)
> client_addr = tst_alloc(sizeof(*client_addr));
> mc_group = tst_alloc(sizeof(*mc_group));
>
> - mc_group->gr_interface = 0;
> + mc_group->gr_interface = NETDEV_INDEX_BY_NAME("lo");
> mc_group_addr = (struct sockaddr_in *) &mc_group->gr_group;
> mc_group_addr->sin_family = AF_INET;
> inet_aton(MULTICASTIP, &mc_group_addr->sin_addr);
--
Martin Doucha mdoucha@suse.cz
SW Quality Engineer
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [LTP] [PATCH] accept02: Join the multicast group on lo
2026-09-30 14:19 ` Martin Doucha
@ 2026-09-30 14:28 ` Petr Vorel
0 siblings, 0 replies; 6+ messages in thread
From: Petr Vorel @ 2026-09-30 14:28 UTC (permalink / raw)
To: Martin Doucha; +Cc: ltp
Hi all,
> Hi,
> I've tested the patch on affected kernel v4.4 and the bug is still
> reproducible. Let's merge it.
Martin, thanks a lot, we really appreciate your effort to test last minutes
before the release => this one made it into the release (merged).
Anders, thanks for fixing this.
Kind regards,
Petr
> Reviewed-by: Martin Doucha <mdoucha@suse.cz>
> Tested-by: Martin Doucha <mdoucha@suse.cz>
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-09-30 14:29 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-28 21:27 [LTP] [PATCH] accept02: Join the multicast group on lo Anders Roxell
2026-09-28 23:50 ` [LTP] " linuxtestproject.agent
2026-09-30 12:53 ` [LTP] [PATCH] " Petr Vorel
2026-09-30 14:10 ` Petr Vorel
2026-09-30 14:19 ` Martin Doucha
2026-09-30 14:28 ` Petr Vorel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.