[chrome-os:chromeos-5.10 7/7] drivers/mmc/core/block.c:2035:54-75: opportunity for str_on_off(snap -> enhanced_strobe)

[chrome-os:chromeos-5.10 7/7] drivers/mmc/core/block.c:2035:54-75: opportunity for str_on_off(snap -> enhanced_strobe)

[kernel test robot]

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
TO: cros-kernel-buildreports@googlegroups.com

tree:   https://chromium.googlesource.com/chromiumos/third_party/kernel chromeos-5.10
head:   968d160d78834f5248a3edbafe10ea3cf35fc7dd
commit: 2e11830dabe66c3d5e88c419b7c0307ce0ce84d7 [7/7] CHROMIUM: mmc: block: dump registers and bus state on critical I/O errors
:::::: branch date: 8 hours ago
:::::: commit date: 8 hours ago
config: x86_64-randconfig-2102-20260930 (https://download.01.org/0day-ci/archive/20260930/202609301917.3iG9bEYj-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Julia Lawall <julia.lawall@inria.fr>
| Closes: https://lore.kernel.org/r/202609301917.3iG9bEYj-lkp@intel.com/

cocci warnings: (new ones prefixed by >>)
>> drivers/mmc/core/block.c:2035:54-75: opportunity for str_on_off(snap -> enhanced_strobe)

vim +2035 drivers/mmc/core/block.c

511ce378e16f07 Baolin Wang       2020-02-12  2020  
2e11830dabe66c Athira Palliprath 2026-09-16  2021  static void mmc_print_snapshot_entry(const struct mmc_bus_snapshot *snap,
2e11830dabe66c Athira Palliprath 2026-09-16  2022  				     const char *tag, int idx)
2e11830dabe66c Athira Palliprath 2026-09-16  2023  {
2e11830dabe66c Athira Palliprath 2026-09-16  2024  	pr_emerg("MMC_SNAP [%d] [%s] Time: %llu ns\n"
2e11830dabe66c Athira Palliprath 2026-09-16  2025  		 "  -> Registers   : OCR: 0x%08x | RCA: 0x%04x | State: 0x%08x\n"
2e11830dabe66c Athira Palliprath 2026-09-16  2026  		 "  -> CID         : %08x%08x%08x%08x\n"
2e11830dabe66c Athira Palliprath 2026-09-16  2027  		 "  -> CSD         : %08x%08x%08x%08x\n"
2e11830dabe66c Athira Palliprath 2026-09-16  2028  		 "  -> Electrical  : Clk: %u Hz | Width: %d-bit | Timing: %d | ES: %s\n"
2e11830dabe66c Athira Palliprath 2026-09-16  2029  		 "  -> Power/Bus   : VDD: 0x%02x | SigVolt: %d (%s) | PwrMode: %d (%s) | DrvType: %d\n",
2e11830dabe66c Athira Palliprath 2026-09-16  2030  		 idx, tag,
2e11830dabe66c Athira Palliprath 2026-09-16  2031  		 (unsigned long long)snap->timestamp,
2e11830dabe66c Athira Palliprath 2026-09-16  2032  		 snap->ocr, snap->rca, snap->state,
2e11830dabe66c Athira Palliprath 2026-09-16  2033  		 snap->raw_cid[0], snap->raw_cid[1], snap->raw_cid[2], snap->raw_cid[3],
2e11830dabe66c Athira Palliprath 2026-09-16  2034  		 snap->raw_csd[0], snap->raw_csd[1], snap->raw_csd[2], snap->raw_csd[3],
2e11830dabe66c Athira Palliprath 2026-09-16 @2035  		 snap->clock, (1 << snap->bus_width), snap->timing, snap->enhanced_strobe ? "on" : "off",
2e11830dabe66c Athira Palliprath 2026-09-16  2036  		 snap->vdd,
2e11830dabe66c Athira Palliprath 2026-09-16  2037  		 snap->signal_voltage,
2e11830dabe66c Athira Palliprath 2026-09-16  2038  		 snap->signal_voltage == 1 ? "1.8V" : (snap->signal_voltage == 2 ? "1.2V" : "3.3V"),
2e11830dabe66c Athira Palliprath 2026-09-16  2039  		 snap->power_mode,
2e11830dabe66c Athira Palliprath 2026-09-16  2040  		 snap->power_mode == 2 ? "On" : (snap->power_mode == 1 ? "Up" : "Off"),
2e11830dabe66c Athira Palliprath 2026-09-16  2041  		 snap->drv_type);
2e11830dabe66c Athira Palliprath 2026-09-16  2042  }
2e11830dabe66c Athira Palliprath 2026-09-16  2043  

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki