All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kees Cook <kees@kernel.org>
To: Bill Wendling <morbo@google.com>
Cc: "Kees Cook" <kees@kernel.org>,
	"Christophe Leroy (CS GROUP)" <chleroy@kernel.org>,
	"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
	linuxppc-dev@lists.ozlabs.org,
	"Madhavan Srinivasan" <maddy@linux.ibm.com>,
	"Michael Ellerman" <mpe@ellerman.id.au>,
	"Nicholas Piggin" <npiggin@gmail.com>,
	"Shivaprasad G Bhat" <sbhat@linux.ibm.com>,
	"Thorsten Blum" <blum@kernel.org>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Steven Rostedt" <rostedt@goodmis.org>,
	nikitash.mariiaw@gmail.com,
	"Greg KH" <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: [PATCH v3 09/11] powerpc/papr_scm: Return the string length from the sysfs show functions
Date: Wed, 30 Sep 2026 16:52:37 -0700	[thread overview]
Message-ID: <20260930235247.157921-9-kees@kernel.org> (raw)
In-Reply-To: <20260930235231.out.387-kees@kernel.org>

perf_stats_show() and flags_show() build their output with a seq_buf
and return seq_buf_used(), which may include the trailing NUL byte
when the seq_buf has overflowed. Use seq_buf_strlen() instead.

Build tested ARCH=powerpc ppc64_defconfig with GCC powerpc64-linux-gnu
16.1.0:
arch/powerpc/platforms/pseries/papr_scm.o

Assisted-by: LLM
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Kees Cook <kees@kernel.org>
---
 arch/powerpc/platforms/pseries/papr_scm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/powerpc/platforms/pseries/papr_scm.c b/arch/powerpc/platforms/pseries/papr_scm.c
index 75da96c08cdd..b03cfd8528f5 100644
--- a/arch/powerpc/platforms/pseries/papr_scm.c
+++ b/arch/powerpc/platforms/pseries/papr_scm.c
@@ -1108,7 +1108,7 @@ static ssize_t perf_stats_show(struct device *dev,
 
 free_stats:
 	kfree(stats);
-	return rc ? rc : (ssize_t)seq_buf_used(&s);
+	return rc ?: (ssize_t)seq_buf_strlen(&s);
 }
 static DEVICE_ATTR_ADMIN_RO(perf_stats);
 
@@ -1150,7 +1150,7 @@ static ssize_t flags_show(struct device *dev,
 	if (seq_buf_used(&s))
 		seq_buf_printf(&s, "\n");
 
-	return seq_buf_used(&s);
+	return seq_buf_strlen(&s);
 }
 DEVICE_ATTR_RO(flags);
 
-- 
2.34.1


  parent reply	other threads:[~2026-09-30 23:52 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-30 23:52 [PATCH v3 00/11] seq_buf: Add seq_buf_strlen() Kees Cook
2026-09-30 23:52 ` [PATCH v3 01/11] seq_buf: Do not print an empty line from an overflowed seq_buf_do_printk() Kees Cook
2026-10-02  7:32   ` Andy Shevchenko
2026-10-03  2:14     ` Kees Cook
2026-09-30 23:52 ` [PATCH v3 02/11] seq_buf: Do not pop from an overflowed seq_buf Kees Cook
2026-09-30 23:59   ` sashiko-bot
2026-09-30 23:52 ` [PATCH v3 03/11] seq_buf: Copy what fits when seq_buf_puts() and seq_buf_putmem() overflow Kees Cook
2026-09-30 23:52 ` [PATCH v3 04/11] seq_buf: Clear what a writer did not claim when a seq_buf overflows Kees Cook
2026-09-30 23:52 ` [PATCH v3 05/11] seq_buf: Add seq_buf_strlen() Kees Cook
2026-09-30 23:52 ` [PATCH v3 06/11] seq_buf: Add seq_buf_terminate() Kees Cook
2026-09-30 23:52 ` [PATCH v3 07/11] bpf: Remove dead newline stripping from format_disasm_line() Kees Cook
2026-09-30 23:52 ` [PATCH v3 08/11] seq_buf: Add seq_buf_init_append() Kees Cook
2026-10-02  7:20   ` Andy Shevchenko
2026-10-03  2:04     ` Kees Cook
2026-09-30 23:52 ` Kees Cook [this message]
2026-10-01  4:17   ` [PATCH v3 09/11] powerpc/papr_scm: Return the string length from the sysfs show functions Madhavan Srinivasan
2026-10-02  7:54     ` Kees Cook
2026-09-30 23:52 ` [PATCH v3 10/11] nvdimm: ndtest: Return the string length from flags_show() Kees Cook
2026-10-01  5:40   ` Alison Schofield
2026-10-01 23:39     ` Alison Schofield
2026-10-03  2:17       ` Kees Cook
2026-09-30 23:52 ` [PATCH v3 11/11] docs: core-api: Document the seq_buf API Kees Cook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260930235247.157921-9-kees@kernel.org \
    --to=kees@kernel.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=blum@kernel.org \
    --cc=chleroy@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=maddy@linux.ibm.com \
    --cc=morbo@google.com \
    --cc=mpe@ellerman.id.au \
    --cc=nikitash.mariiaw@gmail.com \
    --cc=npiggin@gmail.com \
    --cc=rostedt@goodmis.org \
    --cc=sbhat@linux.ibm.com \
    --cc=u.kleine-koenig@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.