From: Kees Cook <kees@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Bill Wendling <morbo@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
David Gow <david@davidgow.net>, Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Shuvam Pandey <shuvampandey1@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
nikitash.mariiaw@gmail.com, Greg KH <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH v3 01/11] seq_buf: Do not print an empty line from an overflowed seq_buf_do_printk()
Date: Fri, 2 Oct 2026 19:14:01 -0700 [thread overview]
Message-ID: <20261003021320.fd7e91-kees@kernel.org> (raw)
In-Reply-To: <ar9d9ChvEvBDX9j0@ashevche-desk.local>
On Fri, Oct 02, 2026 at 10:32:04AM +0300, Andy Shevchenko wrote:
> I believe a single blank line is enough.
>
> I would re-split to have it wrapped on logical boundary:
>
> static void seq_buf_printk_capture(struct console *con,
> const char *s, unsigned int count)
Fixed both for v4, along with two more doubled blank lines in 05/11.
Thanks!
-Kees
--
Kees Cook
next prev parent reply other threads:[~2026-10-03 2:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-30 23:52 [PATCH v3 00/11] seq_buf: Add seq_buf_strlen() Kees Cook
2026-09-30 23:52 ` [PATCH v3 01/11] seq_buf: Do not print an empty line from an overflowed seq_buf_do_printk() Kees Cook
2026-10-02 7:32 ` Andy Shevchenko
2026-10-03 2:14 ` Kees Cook [this message]
2026-09-30 23:52 ` [PATCH v3 02/11] seq_buf: Do not pop from an overflowed seq_buf Kees Cook
2026-09-30 23:59 ` sashiko-bot
2026-09-30 23:52 ` [PATCH v3 03/11] seq_buf: Copy what fits when seq_buf_puts() and seq_buf_putmem() overflow Kees Cook
2026-09-30 23:52 ` [PATCH v3 04/11] seq_buf: Clear what a writer did not claim when a seq_buf overflows Kees Cook
2026-09-30 23:52 ` [PATCH v3 05/11] seq_buf: Add seq_buf_strlen() Kees Cook
2026-09-30 23:52 ` [PATCH v3 06/11] seq_buf: Add seq_buf_terminate() Kees Cook
2026-09-30 23:52 ` [PATCH v3 07/11] bpf: Remove dead newline stripping from format_disasm_line() Kees Cook
2026-09-30 23:52 ` [PATCH v3 08/11] seq_buf: Add seq_buf_init_append() Kees Cook
2026-10-02 7:20 ` Andy Shevchenko
2026-10-03 2:04 ` Kees Cook
2026-09-30 23:52 ` [PATCH v3 09/11] powerpc/papr_scm: Return the string length from the sysfs show functions Kees Cook
2026-10-01 4:17 ` Madhavan Srinivasan
2026-10-02 7:54 ` Kees Cook
2026-09-30 23:52 ` [PATCH v3 10/11] nvdimm: ndtest: Return the string length from flags_show() Kees Cook
2026-10-01 5:40 ` Alison Schofield
2026-10-01 23:39 ` Alison Schofield
2026-10-03 2:17 ` Kees Cook
2026-09-30 23:52 ` [PATCH v3 11/11] docs: core-api: Document the seq_buf API Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261003021320.fd7e91-kees@kernel.org \
--to=kees@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=david@davidgow.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=morbo@google.com \
--cc=nikitash.mariiaw@gmail.com \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=shuvampandey1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.