From: Peter Zijlstra <peterz@infradead.org>
To: Juri Lelli <juri.lelli@redhat.com>
Cc: "Ingo Molnar" <mingo@redhat.com>,
"Vincent Guittot" <vincent.guittot@linaro.org>,
"Dietmar Eggemann" <dietmar.eggemann@arm.com>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Ben Segall" <bsegall@google.com>, "Mel Gorman" <mgorman@suse.de>,
"Valentin Schneider" <vschneid@redhat.com>,
"K Prateek Nayak" <kprateek.nayak@amd.com>,
"Andrea Righi" <arighi@nvidia.com>,
"Frederic Weisbecker" <frederic@kernel.org>,
linux-kernel@vger.kernel.org,
"David Haufe" <dhaufe@simplextrading.com>,
"Cao Ruichuang" <create0818@163.com>,
"Furkan Çalışkan" <frn1furkan10@gmail.com>
Subject: Re: [PATCH v2] sched/deadline: Make dl-server nohz full aware
Date: Thu, 1 Oct 2026 16:33:14 +0200 [thread overview]
Message-ID: <20261001143314.GK4121620@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20261001142735.GT2009045@noisy.programming.kicks-ass.net>
On Thu, Oct 01, 2026 at 04:27:36PM +0200, Peter Zijlstra wrote:
> > bool sched_can_stop_tick(struct rq *rq)
> > {
> > /* Deadline tasks, even if single, need the tick */
> > if (rq->dl.dl_nr_running)
> > return false;
> >
> > /*
> > + * If there are RT tasks, we may need the tick (for >1 RR tasks),
> > + * but we must also service lower-priority CFS/SCX tasks via dl-servers.
> > */
> > + if (rq->rt.rt_nr_running) {
> > + bool cfs_or_scx_queued = false;
> > +
> > + if (rq->cfs.h_nr_queued) {
> > + dl_server_start(&rq->fair_server);
> > + cfs_or_scx_queued = true;
> > + }
> > +#ifdef CONFIG_SCHED_CLASS_EXT
> > + if (rq->scx.nr_running) {
> > + dl_server_start(&rq->ext_server);
> > + cfs_or_scx_queued = true;
> > + }
> > +#endif
> > + if (cfs_or_scx_queued)
> > return false;
What the purpose of this boolean, both true assignments above can simply
be return false, no?
> >
> > + /*
> > + * Only RT tasks, no CFS/SCX. Stop servers to prevent spurious
No DL either, you've filtered those out above.
> > + * wakeups. Tick can stop for single RR or any FIFO, but must
> > + * run for multiple RR (round-robin behavior).
> > + */
> > + dl_servers_stop_all(rq);
> > + if (rq->rt.rr_nr_running > 1)
> > + return false;
> > return true;
> > + }
next prev parent reply other threads:[~2026-10-01 14:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 9:13 [PATCH v2] sched/deadline: Make dl-server nohz full aware Juri Lelli
2026-05-13 11:13 ` Andrea Righi
2026-05-15 15:56 ` Valentin Schneider
2026-07-21 12:18 ` Ionut Nechita (Wind River)
2026-09-24 17:02 ` Ionut Nechita (Wind River)
2026-09-25 15:07 ` Juri Lelli
2026-10-01 12:57 ` Frederic Weisbecker
2026-10-01 13:49 ` Juri Lelli
2026-10-05 12:49 ` Ionut Nechita (Wind River)
2026-10-05 13:20 ` [RFC PATCH] sched/deadline: keep nohz_full tickless while the fair server is deferred Ionut Nechita (Wind River)
2026-10-12 12:41 ` Juri Lelli
2026-10-01 14:27 ` [PATCH v2] sched/deadline: Make dl-server nohz full aware Peter Zijlstra
2026-10-01 14:33 ` Peter Zijlstra [this message]
2026-10-01 15:25 ` Juri Lelli
2026-10-01 15:33 ` Peter Zijlstra
2026-10-01 15:11 ` Juri Lelli
2026-10-02 9:20 ` Peter Zijlstra
2026-10-05 14:32 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261001143314.GK4121620@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=arighi@nvidia.com \
--cc=bsegall@google.com \
--cc=create0818@163.com \
--cc=dhaufe@simplextrading.com \
--cc=dietmar.eggemann@arm.com \
--cc=frederic@kernel.org \
--cc=frn1furkan10@gmail.com \
--cc=juri.lelli@redhat.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.