From: Frederic Weisbecker <frederic@kernel.org>
To: Juri Lelli <juri.lelli@redhat.com>
Cc: "Ionut Nechita (Wind River)" <ionut.nechita@windriver.com>,
mingo@redhat.com, peterz@infradead.org,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
vschneid@redhat.com, kprateek.nayak@amd.com, arighi@nvidia.com,
linux-kernel@vger.kernel.org, dhaufe@simplextrading.com,
create0818@163.com, frn1furkan10@gmail.com
Subject: Re: [PATCH v2] sched/deadline: Make dl-server nohz full aware
Date: Thu, 1 Oct 2026 14:57:13 +0200 [thread overview]
Message-ID: <ar5YqUCMbhZyjvtn@localhost.localdomain> (raw)
In-Reply-To: <araOR8aTAU_R5lwQ@jlelli-thinkpadt14gen4.remote.csb>
Le Fri, Sep 25, 2026 at 05:07:51PM +0200, Juri Lelli a écrit :
> Hi Ionut,
>
> On 24/09/26 20:02, Ionut Nechita (Wind River) wrote:
> > Hi Juri,
> >
> > I have been chasing timer noise on isolated nohz_full cores for an RT
> > product and ended up on this patch. It does restore the CFS bandwidth
> > guarantee, but on the isolated core itself it trades the dl-server's
> > timers for a full CONFIG_HZ tick, which for us is the more expensive of
> > the two.
> >
> > Below are measurements from two machines, a variant that keeps the core
> > tickless, and a hazard in the dl_servers_stop_all() call sites that an
> > equivalent change of mine ran into. The variant is not a replacement for
> > your patch as it stands, since it does not address the housekeeping
> > wakeups you are fixing, so this is more a "can we get both?" than a
> > counter-proposal.
>
> Thanks for the detailed analysis!
>
> I believe my v2 was never picked up, so I'm happy for you to send a v3
> modified with your approach. Keeping the tick stopped during the
> server's throttled window sounds reasonable to me. Having a proper
> single patch will make it easier to evaluate. Please do include the
> ext_server handling as well so we have the complete picture.
>
> ...
>
> > A separate observation
> > ======================
> >
> > Independently of either patch, the CFS wakeup pattern changed between
> > v6.12 and v6.18. With the same workload, v6.12 serves the periodic CFS
> > task every ~50ms (199 wakeups in 10s), while both v6.18 variants on that
> > machine serve it once per server period (10 wakeups in 10s, ~1s worst
> > case). The bandwidth is the same, but it arrives in one burst per period
> > instead of being spread out. For an isolated core running a periodic
> > housekeeping task next to an RT application, that is a user-visible
> > change. Is the deferred activation expected to behave this way, or is it
> > worth looking at separately?
>
> I think what you see is the deferred server model at work. The server
> now defers activation until zero-laxity. The dl-server is primarily a
> safety net to prevent complete CFS starvation under RT, not a latency
> guarantee, so the bandwidth being correct (5%) is what matters and how
> it's distributed within the period is a secondary concern. That said, if
> I understand your example correctly, that periodic housekeeping CFS task
> you have on the same isolated core of the RT application is relying on
> dl-server to be able to run? It doesn't seem a safe approach to me, the
> RT application should better ensure to sleep at times leaving space for
> CFS housekeeping task to execute w/o activating the dl-server?
I'm not sure I understand everything in this matter but in general
sched bandwidth is incompatible with nohz_full. It's about a single task
running so there shouldn't need to limit access to the CPU. And therefore
there should be no dl_server running there, right?
--
Frederic Weisbecker
SUSE Labs
next prev parent reply other threads:[~2026-10-01 12:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 9:13 [PATCH v2] sched/deadline: Make dl-server nohz full aware Juri Lelli
2026-05-13 11:13 ` Andrea Righi
2026-05-15 15:56 ` Valentin Schneider
2026-07-21 12:18 ` Ionut Nechita (Wind River)
2026-09-24 17:02 ` Ionut Nechita (Wind River)
2026-09-25 15:07 ` Juri Lelli
2026-10-01 12:57 ` Frederic Weisbecker [this message]
2026-10-01 13:49 ` Juri Lelli
2026-10-05 12:49 ` Ionut Nechita (Wind River)
2026-10-05 13:20 ` [RFC PATCH] sched/deadline: keep nohz_full tickless while the fair server is deferred Ionut Nechita (Wind River)
2026-10-12 12:41 ` Juri Lelli
2026-10-01 14:27 ` [PATCH v2] sched/deadline: Make dl-server nohz full aware Peter Zijlstra
2026-10-01 14:33 ` Peter Zijlstra
2026-10-01 15:25 ` Juri Lelli
2026-10-01 15:33 ` Peter Zijlstra
2026-10-01 15:11 ` Juri Lelli
2026-10-02 9:20 ` Peter Zijlstra
2026-10-05 14:32 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ar5YqUCMbhZyjvtn@localhost.localdomain \
--to=frederic@kernel.org \
--cc=arighi@nvidia.com \
--cc=bsegall@google.com \
--cc=create0818@163.com \
--cc=dhaufe@simplextrading.com \
--cc=dietmar.eggemann@arm.com \
--cc=frn1furkan10@gmail.com \
--cc=ionut.nechita@windriver.com \
--cc=juri.lelli@redhat.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.