All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Ronit Gupta <ronitgupta138@gmail.com>
Cc: Vaibhav Agarwal <vaibhav.sr@gmail.com>,
	mgreer@animalcreek.com, johan@kernel.org, elder@kernel.org,
	greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: greybus: audio_manager_module: Add missing newlines to sysfs_emit() formats
Date: Thu, 1 Oct 2026 14:24:46 +0200	[thread overview]
Message-ID: <2026100118-banner-casing-56e0@gregkh> (raw)
In-Reply-To: <CAO=9wt733yd9Z6nUbV7awHoQPuu-4eAHWnH10k-OMhRrW1bs3w@mail.gmail.com>

On Thu, Oct 01, 2026 at 05:43:48PM +0530, Ronit Gupta wrote:
> According to Documentation/filesystems/sysfs.rst, sysfs attribute values
> 
>       should terminate with a single newline character.
>       Add missing trailing '\n' characters to the format strings of all
> 
>       sysfs_emit() calls in gb_audio_module_*_show() attribute callbacks.
> 
>       Signed-off-by: Ronit Gupta <ronitgupta138@gmail.com>
> 
>       ---
> 
>        drivers/staging/greybus/audio_manager_module.c | 12 ++++++------
> 
>        1 file changed, 6 insertions(+), 6 deletions(-)
> 
>       diff --git a/drivers/staging/greybus/audio_manager_module.c
> b/drivers/staging/greybus/audio_manager_module.c
>       index dc90cc2d2..5737f2a32 100644
> 
>       --- a/drivers/staging/greybus/audio_manager_module.c
> 
>       +++ b/drivers/staging/greybus/audio_manager_module.c
> 
>       @@ -75,7 +75,7 @@ static void gb_audio_module_release(struct kobject
> *kobj)
>        static ssize_t gb_audio_module_name_show(struct
> gb_audio_manager_module *module,

<snip>

Something went really wrong here, please take a look at the email
documentation in the kernel for more details on how to do this properly.

thanks,

greg k-h

       reply	other threads:[~2026-10-01 12:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAO=9wt733yd9Z6nUbV7awHoQPuu-4eAHWnH10k-OMhRrW1bs3w@mail.gmail.com>
2026-10-01 12:24 ` Greg KH [this message]
2026-10-01 12:46   ` [PATCH] staging: greybus: audio_manager_module: Add missing newlines to sysfs_emit() formats Dan Carpenter
2026-10-01 12:43 Ronit Gupta
2026-10-01 13:07 ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026100118-banner-casing-56e0@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=elder@kernel.org \
    --cc=greybus-dev@lists.linaro.org \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=mgreer@animalcreek.com \
    --cc=ronitgupta138@gmail.com \
    --cc=vaibhav.sr@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.