From: Dan Carpenter <error27@gmail.com>
To: Ronit Gupta <ronitgupta138@gmail.com>
Cc: vaibhav.sr@gmail.com, mgreer@animalcreek.com, johan@kernel.org,
elder@kernel.org, gregkh@linuxfoundation.org,
greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: greybus: audio_manager_module: Add missing newlines to sysfs_emit() formats
Date: Thu, 1 Oct 2026 16:07:53 +0300 [thread overview]
Message-ID: <ar5bKXI9R-RuAux0@stanley.mountain> (raw)
In-Reply-To: <6abe5570.5b65f4c6.2632fe.6f95@mx.google.com>
On Thu, Oct 01, 2026 at 05:43:28AM -0700, Ronit Gupta wrote:
> According to Documentation/filesystems/sysfs.rst, sysfs attribute values
> should terminate with a single newline character.
>
> Add missing trailing '\n' characters to the format strings of all
> sysfs_emit() calls in gb_audio_module_*_show() attribute callbacks.
>
> Signed-off-by: Ronit Gupta <ronitgupta138@gmail.com>
> ---
Please slow down...
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
Anyway, see my previous response. This potentially breaks the API
so we can't do it. Search lore.kernel.org for the function name for
more details.
regards,
dan carpenter
next prev parent reply other threads:[~2026-10-01 13:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-01 12:43 [PATCH] staging: greybus: audio_manager_module: Add missing newlines to sysfs_emit() formats Ronit Gupta
2026-10-01 13:07 ` Dan Carpenter [this message]
[not found] <CAO=9wt733yd9Z6nUbV7awHoQPuu-4eAHWnH10k-OMhRrW1bs3w@mail.gmail.com>
2026-10-01 12:24 ` Greg KH
2026-10-01 12:46 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ar5bKXI9R-RuAux0@stanley.mountain \
--to=error27@gmail.com \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mgreer@animalcreek.com \
--cc=ronitgupta138@gmail.com \
--cc=vaibhav.sr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.