All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Rosen Penev <rosenp@gmail.com>
Cc: linux-serial@vger.kernel.org, Vineet Gupta <vgupta@kernel.org>,
	Jiri Slaby <jirislaby@kernel.org>,
	"open list:SYNOPSYS ARC ARCHITECTURE"
	<linux-snps-arc@lists.infradead.org>,
	"open list:TTY LAYER AND SERIAL DRIVERS"
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] serial: arc_uart: Use platform IRQ helper
Date: Thu, 1 Oct 2026 10:42:38 +0200	[thread overview]
Message-ID: <2026100129-unrest-cleaver-6528@gregkh> (raw)
In-Reply-To: <20260925183050.56839-1-rosenp@gmail.com>

On Fri, Sep 25, 2026 at 11:30:50AM -0700, Rosen Penev wrote:
> Avoid calling irq_dispose_mapping() by letting the platform_device
> machinery handle it. Also enable possibility of handling -EPROBE_DEFER
> and other errors. Handle as early as possible to avoid doing unnecessary
> work.
> 
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---
>  drivers/tty/serial/arc_uart.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/tty/serial/arc_uart.c b/drivers/tty/serial/arc_uart.c
> index 3988e5958896..b46b057a181b 100644
> --- a/drivers/tty/serial/arc_uart.c
> +++ b/drivers/tty/serial/arc_uart.c
> @@ -30,7 +30,6 @@
>  #include <linux/tty_flip.h>
>  #include <linux/serial_core.h>
>  #include <linux/io.h>
> -#include <linux/of_irq.h>
>  #include <linux/of_address.h>
>  
>  /*************************************
> @@ -571,12 +570,17 @@ static int arc_serial_probe(struct platform_device *pdev)
>  	struct arc_uart_port *uart;
>  	struct uart_port *port;
>  	int dev_id;
> +	int irq;
>  	u32 val;
>  
>  	/* no device tree device */
>  	if (!np)
>  		return -ENODEV;
>  
> +	irq = platform_get_irq(pdev, 0);
> +	if (irq < 0)
> +		return irq;
> +
>  	dev_id = of_alias_get_id(np, "serial");
>  	if (dev_id < 0)
>  		dev_id = 0;
> @@ -607,7 +611,7 @@ static int arc_serial_probe(struct platform_device *pdev)
>  		return PTR_ERR(port->membase);
>  	}
>  
> -	port->irq = irq_of_parse_and_map(np, 0);
> +	port->irq = irq;
>  
>  	port->dev = &pdev->dev;
>  	port->iotype = UPIO_MEM;
> -- 
> 2.55.0
> 
> 

You forgot an Assisted-by: tag here :(

_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc

WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Rosen Penev <rosenp@gmail.com>
Cc: linux-serial@vger.kernel.org, Vineet Gupta <vgupta@kernel.org>,
	Jiri Slaby <jirislaby@kernel.org>,
	"open list:SYNOPSYS ARC ARCHITECTURE"
	<linux-snps-arc@lists.infradead.org>,
	"open list:TTY LAYER AND SERIAL DRIVERS"
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] serial: arc_uart: Use platform IRQ helper
Date: Thu, 1 Oct 2026 10:42:38 +0200	[thread overview]
Message-ID: <2026100129-unrest-cleaver-6528@gregkh> (raw)
In-Reply-To: <20260925183050.56839-1-rosenp@gmail.com>

On Fri, Sep 25, 2026 at 11:30:50AM -0700, Rosen Penev wrote:
> Avoid calling irq_dispose_mapping() by letting the platform_device
> machinery handle it. Also enable possibility of handling -EPROBE_DEFER
> and other errors. Handle as early as possible to avoid doing unnecessary
> work.
> 
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---
>  drivers/tty/serial/arc_uart.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/tty/serial/arc_uart.c b/drivers/tty/serial/arc_uart.c
> index 3988e5958896..b46b057a181b 100644
> --- a/drivers/tty/serial/arc_uart.c
> +++ b/drivers/tty/serial/arc_uart.c
> @@ -30,7 +30,6 @@
>  #include <linux/tty_flip.h>
>  #include <linux/serial_core.h>
>  #include <linux/io.h>
> -#include <linux/of_irq.h>
>  #include <linux/of_address.h>
>  
>  /*************************************
> @@ -571,12 +570,17 @@ static int arc_serial_probe(struct platform_device *pdev)
>  	struct arc_uart_port *uart;
>  	struct uart_port *port;
>  	int dev_id;
> +	int irq;
>  	u32 val;
>  
>  	/* no device tree device */
>  	if (!np)
>  		return -ENODEV;
>  
> +	irq = platform_get_irq(pdev, 0);
> +	if (irq < 0)
> +		return irq;
> +
>  	dev_id = of_alias_get_id(np, "serial");
>  	if (dev_id < 0)
>  		dev_id = 0;
> @@ -607,7 +611,7 @@ static int arc_serial_probe(struct platform_device *pdev)
>  		return PTR_ERR(port->membase);
>  	}
>  
> -	port->irq = irq_of_parse_and_map(np, 0);
> +	port->irq = irq;
>  
>  	port->dev = &pdev->dev;
>  	port->iotype = UPIO_MEM;
> -- 
> 2.55.0
> 
> 

You forgot an Assisted-by: tag here :(

  parent reply	other threads:[~2026-10-01  8:42 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-25 18:30 [PATCH] serial: arc_uart: Use platform IRQ helper Rosen Penev
2026-09-25 18:30 ` Rosen Penev
2026-09-25 18:38 ` sashiko-bot
2026-10-01  8:42 ` Greg Kroah-Hartman [this message]
2026-10-01  8:42   ` Greg Kroah-Hartman
2026-10-01 18:58   ` Rosen Penev
2026-10-01 18:58     ` Rosen Penev
2026-10-02  5:55     ` Greg Kroah-Hartman
2026-10-02  5:55       ` Greg Kroah-Hartman
2026-10-02  7:25       ` Rosen Penev
2026-10-02  7:25         ` Rosen Penev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026100129-unrest-cleaver-6528@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux-snps-arc@lists.infradead.org \
    --cc=rosenp@gmail.com \
    --cc=vgupta@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.