[PATCH v2] staging: rtl8723bs: remove redundant goto in rtw_alloc_xmitframe_once()

[PATCH v2] staging: rtl8723bs: remove redundant goto in rtw_alloc_xmitframe_once()

[Moises Dominguez]

From: Moises Dominguez <dominguezsalcedom@gmail.com>

Remove the redundant goto and return NULL directly when allocation fails.

Signed-off-by: Moises Dominguez <dominguezsalcedom@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_xmit.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c
index 81d9e713fc12..cd659bd2f261 100644
--- a/drivers/staging/rtl8723bs/core/rtw_xmit.c
+++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c
@@ -1715,7 +1715,7 @@ struct xmit_frame *rtw_alloc_xmitframe_once(struct xmit_priv *pxmitpriv)
 
 	alloc_addr = kzalloc(sizeof(*pxframe) + 4, GFP_ATOMIC);
 	if (!alloc_addr)
-		goto exit;
+		return NULL;
 
 	pxframe = (struct xmit_frame *)N_BYTE_ALIGMENT((SIZE_PTR)(alloc_addr), 4);
 	pxframe->alloc_addr = alloc_addr;
@@ -1730,7 +1730,6 @@ struct xmit_frame *rtw_alloc_xmitframe_once(struct xmit_priv *pxmitpriv)
 
 	rtw_init_xmitframe(pxframe);
 
-exit:
 	return pxframe;
 }
 
-- 
2.55.0

Re: [PATCH v2] staging: rtl8723bs: remove redundant goto in rtw_alloc_xmitframe_once()

[Greg KH]

On Sun, Sep 13, 2026 at 02:53:49PM -0600, Moises Dominguez wrote:
> From: Moises Dominguez <dominguezsalcedom@gmail.com>
> 
> Remove the redundant goto and return NULL directly when allocation fails.
> 
> Signed-off-by: Moises Dominguez <dominguezsalcedom@gmail.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_xmit.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c
> index 81d9e713fc12..cd659bd2f261 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c
> @@ -1715,7 +1715,7 @@ struct xmit_frame *rtw_alloc_xmitframe_once(struct xmit_priv *pxmitpriv)
>  
>  	alloc_addr = kzalloc(sizeof(*pxframe) + 4, GFP_ATOMIC);
>  	if (!alloc_addr)
> -		goto exit;
> +		return NULL;
>  
>  	pxframe = (struct xmit_frame *)N_BYTE_ALIGMENT((SIZE_PTR)(alloc_addr), 4);
>  	pxframe->alloc_addr = alloc_addr;
> @@ -1730,7 +1730,6 @@ struct xmit_frame *rtw_alloc_xmitframe_once(struct xmit_priv *pxmitpriv)
>  
>  	rtw_init_xmitframe(pxframe);
>  
> -exit:
>  	return pxframe;
>  }
>  
> -- 
> 2.55.0
> 
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/process/submitting-patches.rst for what
  needs to be done here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot