From: sashiko-bot@kernel.org
To: "Rob Herring (Arm)" <robh@kernel.org>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH] dt-bindings: mailbox: Convert hisilicon,hi3660-mbox to DT schema
Date: Fri, 02 Oct 2026 09:14:15 +0000 [thread overview]
Message-ID: <20261002091415.B5F8B1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20261001230538.2751621-1-robh@kernel.org>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: missing subdirectory in schema id path for hi3660-mbox
--
commit 166b90ad2ed4cbcf55aa970feab55098ef88a99d
Author: Rob Herring (Arm) <robh@kernel.org>
dt-bindings: mailbox: Convert hisilicon,hi3660-mbox to DT schema
Convert the hisilicon,hi3660-mbox binding to DT schema format. The
binding and driver give no clue about what the 2 interrupts are, so more
details can't be added.
> diff --git a/Documentation/devicetree/bindings/mailbox/hisilicon,hi3660-mbox.yaml b/Documentation/devicetree/bindings/mailbox/hisilicon,hi3660-mbox.yaml
> new file mode 100644
> index 0000000000000..c42ce576a029c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mailbox/hisilicon,hi3660-mbox.yaml
> @@ -0,0 +1,57 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hisilicon,hi3660-mbox.yaml#
[Severity: Low]
Does this introduce a regression by omitting the mailbox/ subdirectory
from the schema id?
The $id field must exactly match the file location relative to
Documentation/devicetree/bindings/. Should this be updated to include
the mailbox/ path component?
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Hisilicon Hi3660 Mailbox Controller
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261001230538.2751621-1-robh@kernel.org?part=1
next prev parent reply other threads:[~2026-10-02 9:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-01 23:05 [PATCH] dt-bindings: mailbox: Convert hisilicon,hi3660-mbox to DT schema Rob Herring (Arm)
2026-10-02 9:14 ` sashiko-bot [this message]
2026-10-12 1:34 ` Jassi Brar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261002091415.B5F8B1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.