* [PATCH] dt-bindings: mailbox: Convert hisilicon,hi3660-mbox to DT schema
@ 2026-10-01 23:05 Rob Herring (Arm)
2026-10-02 9:14 ` sashiko-bot
2026-10-12 1:34 ` Jassi Brar
0 siblings, 2 replies; 3+ messages in thread
From: Rob Herring (Arm) @ 2026-10-01 23:05 UTC (permalink / raw)
To: Jassi Brar, Krzysztof Kozlowski, Conor Dooley, Wei Xu
Cc: linux-kernel, devicetree
Convert the hisilicon,hi3660-mbox binding to DT schema format. The
binding and driver give no clue about what the 2 interrupts are, so more
details can't be added.
Assisted-by: LLM
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
.../mailbox/hisilicon,hi3660-mailbox.txt | 51 -----------------
.../mailbox/hisilicon,hi3660-mbox.yaml | 57 +++++++++++++++++++
2 files changed, 57 insertions(+), 51 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/mailbox/hisilicon,hi3660-mailbox.txt
create mode 100644 Documentation/devicetree/bindings/mailbox/hisilicon,hi3660-mbox.yaml
diff --git a/Documentation/devicetree/bindings/mailbox/hisilicon,hi3660-mailbox.txt b/Documentation/devicetree/bindings/mailbox/hisilicon,hi3660-mailbox.txt
deleted file mode 100644
index ec2da5c9e647..000000000000
--- a/Documentation/devicetree/bindings/mailbox/hisilicon,hi3660-mailbox.txt
+++ /dev/null
@@ -1,51 +0,0 @@
-Hisilicon Hi3660 Mailbox Controller
-
-Hisilicon Hi3660 mailbox controller supports up to 32 channels. Messages
-are passed between processors, including application & communication
-processors, MCU, HIFI, etc. Each channel is unidirectional and accessed
-by using MMIO registers; it supports maximum to 8 words message.
-
-Controller
-----------
-
-Required properties:
-- compatible: : Shall be "hisilicon,hi3660-mbox"
-- reg: : Offset and length of the device's register set
-- #mbox-cells: : Must be 3
- <&phandle channel dst_irq ack_irq>
- phandle : Label name of controller
- channel : Channel number
- dst_irq : Remote interrupt vector
- ack_irq : Local interrupt vector
-
-- interrupts: : Contains the two IRQ lines for mailbox.
-
-Example:
-
-mailbox: mailbox@e896b000 {
- compatible = "hisilicon,hi3660-mbox";
- reg = <0x0 0xe896b000 0x0 0x1000>;
- interrupts = <0x0 0xc0 0x4>,
- <0x0 0xc1 0x4>;
- #mbox-cells = <3>;
-};
-
-Client
-------
-
-Required properties:
-- compatible : See the client docs
-- mboxes : Standard property to specify a Mailbox
- Cells must match 'mbox-cells' (See Controller docs above)
-
-Optional properties
-- mbox-names : Name given to channels seen in the 'mboxes' property.
-
-Example:
-
-stub_clock: stub_clock@e896b500 {
- compatible = "hisilicon,hi3660-stub-clk";
- reg = <0x0 0xe896b500 0x0 0x0100>;
- #clock-cells = <1>;
- mboxes = <&mailbox 13 3 0>;
-};
diff --git a/Documentation/devicetree/bindings/mailbox/hisilicon,hi3660-mbox.yaml b/Documentation/devicetree/bindings/mailbox/hisilicon,hi3660-mbox.yaml
new file mode 100644
index 000000000000..c42ce576a029
--- /dev/null
+++ b/Documentation/devicetree/bindings/mailbox/hisilicon,hi3660-mbox.yaml
@@ -0,0 +1,57 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/hisilicon,hi3660-mbox.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Hisilicon Hi3660 Mailbox Controller
+
+maintainers:
+ - Wei Xu <xuwei5@hisilicon.com>
+
+description:
+ Hisilicon Hi3660 mailbox controller supports up to 32 channels. Messages
+ are passed between processors, including application & communication
+ processors, MCU, HIFI, etc. Each channel is unidirectional and accessed
+ by using MMIO registers; it supports maximum to 8 words message.
+
+properties:
+ compatible:
+ items:
+ - const: hisilicon,hi3660-mbox
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ description: Mailbox interrupt vectors for message processing
+ maxItems: 2
+
+ '#mbox-cells':
+ description: >
+ The cells content are as follows:
+ - Channel number
+ - Remote destination interrupt vector
+ - Local ack interrupt vector
+ const: 3
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - '#mbox-cells'
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ #include <dt-bindings/interrupt-controller/irq.h>
+
+ mailbox@e896b000 {
+ compatible = "hisilicon,hi3660-mbox";
+ reg = <0xe896b000 0x1000>;
+ interrupts = <GIC_SPI 0xc0 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 0xc1 IRQ_TYPE_LEVEL_HIGH>;
+ #mbox-cells = <3>;
+ };
--
2.53.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: mailbox: Convert hisilicon,hi3660-mbox to DT schema
2026-10-01 23:05 [PATCH] dt-bindings: mailbox: Convert hisilicon,hi3660-mbox to DT schema Rob Herring (Arm)
@ 2026-10-02 9:14 ` sashiko-bot
2026-10-12 1:34 ` Jassi Brar
1 sibling, 0 replies; 3+ messages in thread
From: sashiko-bot @ 2026-10-02 9:14 UTC (permalink / raw)
To: Rob Herring (Arm); +Cc: devicetree, robh, conor+dt
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: missing subdirectory in schema id path for hi3660-mbox
--
commit 166b90ad2ed4cbcf55aa970feab55098ef88a99d
Author: Rob Herring (Arm) <robh@kernel.org>
dt-bindings: mailbox: Convert hisilicon,hi3660-mbox to DT schema
Convert the hisilicon,hi3660-mbox binding to DT schema format. The
binding and driver give no clue about what the 2 interrupts are, so more
details can't be added.
> diff --git a/Documentation/devicetree/bindings/mailbox/hisilicon,hi3660-mbox.yaml b/Documentation/devicetree/bindings/mailbox/hisilicon,hi3660-mbox.yaml
> new file mode 100644
> index 0000000000000..c42ce576a029c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mailbox/hisilicon,hi3660-mbox.yaml
> @@ -0,0 +1,57 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hisilicon,hi3660-mbox.yaml#
[Severity: Low]
Does this introduce a regression by omitting the mailbox/ subdirectory
from the schema id?
The $id field must exactly match the file location relative to
Documentation/devicetree/bindings/. Should this be updated to include
the mailbox/ path component?
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Hisilicon Hi3660 Mailbox Controller
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261001230538.2751621-1-robh@kernel.org?part=1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: mailbox: Convert hisilicon,hi3660-mbox to DT schema
2026-10-01 23:05 [PATCH] dt-bindings: mailbox: Convert hisilicon,hi3660-mbox to DT schema Rob Herring (Arm)
2026-10-02 9:14 ` sashiko-bot
@ 2026-10-12 1:34 ` Jassi Brar
1 sibling, 0 replies; 3+ messages in thread
From: Jassi Brar @ 2026-10-12 1:34 UTC (permalink / raw)
To: Rob Herring (Arm)
Cc: Krzysztof Kozlowski, Conor Dooley, Wei Xu, linux-kernel,
devicetree
On Thu, Oct 1, 2026 at 6:05 PM Rob Herring (Arm) <robh@kernel.org> wrote:
>
> Convert the hisilicon,hi3660-mbox binding to DT schema format. The
> binding and driver give no clue about what the 2 interrupts are, so more
> details can't be added.
>
> Assisted-by: LLM
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
> .../mailbox/hisilicon,hi3660-mailbox.txt | 51 -----------------
> .../mailbox/hisilicon,hi3660-mbox.yaml | 57 +++++++++++++++++++
> 2 files changed, 57 insertions(+), 51 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/mailbox/hisilicon,hi3660-mailbox.txt
> create mode 100644 Documentation/devicetree/bindings/mailbox/hisilicon,hi3660-mbox.yaml
>
> diff --git a/Documentation/devicetree/bindings/mailbox/hisilicon,hi3660-mailbox.txt b/Documentation/devicetree/bindings/mailbox/hisilicon,hi3660-mailbox.txt
> deleted file mode 100644
> index ec2da5c9e647..000000000000
> --- a/Documentation/devicetree/bindings/mailbox/hisilicon,hi3660-mailbox.txt
> +++ /dev/null
> @@ -1,51 +0,0 @@
> -Hisilicon Hi3660 Mailbox Controller
> -
> -Hisilicon Hi3660 mailbox controller supports up to 32 channels. Messages
> -are passed between processors, including application & communication
> -processors, MCU, HIFI, etc. Each channel is unidirectional and accessed
> -by using MMIO registers; it supports maximum to 8 words message.
> -
> -Controller
> -----------
> -
> -Required properties:
> -- compatible: : Shall be "hisilicon,hi3660-mbox"
> -- reg: : Offset and length of the device's register set
> -- #mbox-cells: : Must be 3
> - <&phandle channel dst_irq ack_irq>
> - phandle : Label name of controller
> - channel : Channel number
> - dst_irq : Remote interrupt vector
> - ack_irq : Local interrupt vector
> -
> -- interrupts: : Contains the two IRQ lines for mailbox.
> -
> -Example:
> -
> -mailbox: mailbox@e896b000 {
> - compatible = "hisilicon,hi3660-mbox";
> - reg = <0x0 0xe896b000 0x0 0x1000>;
> - interrupts = <0x0 0xc0 0x4>,
> - <0x0 0xc1 0x4>;
> - #mbox-cells = <3>;
> -};
> -
> -Client
> -------
> -
> -Required properties:
> -- compatible : See the client docs
> -- mboxes : Standard property to specify a Mailbox
> - Cells must match 'mbox-cells' (See Controller docs above)
> -
> -Optional properties
> -- mbox-names : Name given to channels seen in the 'mboxes' property.
> -
> -Example:
> -
> -stub_clock: stub_clock@e896b500 {
> - compatible = "hisilicon,hi3660-stub-clk";
> - reg = <0x0 0xe896b500 0x0 0x0100>;
> - #clock-cells = <1>;
> - mboxes = <&mailbox 13 3 0>;
> -};
> diff --git a/Documentation/devicetree/bindings/mailbox/hisilicon,hi3660-mbox.yaml b/Documentation/devicetree/bindings/mailbox/hisilicon,hi3660-mbox.yaml
> new file mode 100644
> index 000000000000..c42ce576a029
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mailbox/hisilicon,hi3660-mbox.yaml
> @@ -0,0 +1,57 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hisilicon,hi3660-mbox.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Hisilicon Hi3660 Mailbox Controller
> +
> +maintainers:
> + - Wei Xu <xuwei5@hisilicon.com>
> +
> +description:
> + Hisilicon Hi3660 mailbox controller supports up to 32 channels. Messages
> + are passed between processors, including application & communication
> + processors, MCU, HIFI, etc. Each channel is unidirectional and accessed
> + by using MMIO registers; it supports maximum to 8 words message.
> +
> +properties:
> + compatible:
> + items:
> + - const: hisilicon,hi3660-mbox
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + description: Mailbox interrupt vectors for message processing
> + maxItems: 2
> +
> + '#mbox-cells':
> + description: >
> + The cells content are as follows:
> + - Channel number
> + - Remote destination interrupt vector
> + - Local ack interrupt vector
> + const: 3
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - '#mbox-cells'
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> +
> + mailbox@e896b000 {
> + compatible = "hisilicon,hi3660-mbox";
> + reg = <0xe896b000 0x1000>;
> + interrupts = <GIC_SPI 0xc0 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 0xc1 IRQ_TYPE_LEVEL_HIGH>;
> + #mbox-cells = <3>;
> + };
> --
> 2.53.0
>
Applied to mailbox/for-next
Thanks
Jassi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-10-12 1:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-01 23:05 [PATCH] dt-bindings: mailbox: Convert hisilicon,hi3660-mbox to DT schema Rob Herring (Arm)
2026-10-02 9:14 ` sashiko-bot
2026-10-12 1:34 ` Jassi Brar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.