Re: staging: greybus: audio: Fix no terminating newline in sysfs emit

[kernel test robot <lkp@intel.com>]

Hi Raiden,

kernel test robot noticed the following build warnings:



url:    https://github.com/intel-lab-lkp/linux/commits/Raiden-Horner/staging-greybus-audio-Fix-no-terminating-newline-in-sysfs-emit/20261001-111458
base:   
patch link:    https://lore.kernel.org/r/202610021803.2F2RQ73w-lkp%40intel.com
config: csky-allmodconfig (https://download.01.org/0day-ci/archive/20261002/202610021803.2F2RQ73w-lkp@intel.com/config)
compiler: csky-linux-gcc (GCC) 16.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261002/202610021803.2F2RQ73w-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202610021803.2F2RQ73w-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/staging/greybus/audio_manager_module.c: In function 'send_add_uevent':
>> drivers/staging/greybus/audio_manager_module.c:180:53: warning: passing argument 3 of 'kobject_uevent_env' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
     180 |         kobject_uevent_env(&module->kobj, KOBJ_ADD, envp);
         |                                                     ^~~~
   In file included from drivers/staging/greybus/audio_manager.h:11,
                    from drivers/staging/greybus/audio_manager_module.c:10:
   include/linux/kobject.h:283:31: note: expected 'char **' but argument is of type 'char * const*'
     283 |                         char *envp[]);
         |                         ~~~~~~^~~~~~


vim +180 drivers/staging/greybus/audio_manager_module.c

8db00736d365b7 Svetlin Ankov    2016-01-13  151  
8db00736d365b7 Svetlin Ankov    2016-01-13  152  static void send_add_uevent(struct gb_audio_manager_module *module)
8db00736d365b7 Svetlin Ankov    2016-01-13  153  {
8db00736d365b7 Svetlin Ankov    2016-01-13  154  	char name_string[128];
8db00736d365b7 Svetlin Ankov    2016-01-13  155  	char vid_string[64];
8db00736d365b7 Svetlin Ankov    2016-01-13  156  	char pid_string[64];
d0af1bd5f6f449 Pankaj Bharadiya 2016-10-16  157  	char intf_id_string[64];
a9234bfd6cec44 Vaibhav Agarwal  2016-03-30  158  	char ip_devices_string[64];
a9234bfd6cec44 Vaibhav Agarwal  2016-03-30  159  	char op_devices_string[64];
8db00736d365b7 Svetlin Ankov    2016-01-13  160  
757f49b7d08da4 Raiden Horner    2026-10-01  161  	char * const envp[] = {
8db00736d365b7 Svetlin Ankov    2016-01-13  162  		name_string,
8db00736d365b7 Svetlin Ankov    2016-01-13  163  		vid_string,
8db00736d365b7 Svetlin Ankov    2016-01-13  164  		pid_string,
d0af1bd5f6f449 Pankaj Bharadiya 2016-10-16  165  		intf_id_string,
a9234bfd6cec44 Vaibhav Agarwal  2016-03-30  166  		ip_devices_string,
a9234bfd6cec44 Vaibhav Agarwal  2016-03-30  167  		op_devices_string,
8db00736d365b7 Svetlin Ankov    2016-01-13  168  		NULL
8db00736d365b7 Svetlin Ankov    2016-01-13  169  	};
8db00736d365b7 Svetlin Ankov    2016-01-13  170  
8db00736d365b7 Svetlin Ankov    2016-01-13  171  	snprintf(name_string, 128, "NAME=%s", module->desc.name);
8db00736d365b7 Svetlin Ankov    2016-01-13  172  	snprintf(vid_string, 64, "VID=%d", module->desc.vid);
8db00736d365b7 Svetlin Ankov    2016-01-13  173  	snprintf(pid_string, 64, "PID=%d", module->desc.pid);
d0af1bd5f6f449 Pankaj Bharadiya 2016-10-16  174  	snprintf(intf_id_string, 64, "INTF_ID=%d", module->desc.intf_id);
a9234bfd6cec44 Vaibhav Agarwal  2016-03-30  175  	snprintf(ip_devices_string, 64, "I/P DEVICES=0x%X",
a9234bfd6cec44 Vaibhav Agarwal  2016-03-30  176  		 module->desc.ip_devices);
a9234bfd6cec44 Vaibhav Agarwal  2016-03-30  177  	snprintf(op_devices_string, 64, "O/P DEVICES=0x%X",
a9234bfd6cec44 Vaibhav Agarwal  2016-03-30  178  		 module->desc.op_devices);
8db00736d365b7 Svetlin Ankov    2016-01-13  179  
8db00736d365b7 Svetlin Ankov    2016-01-13 @180  	kobject_uevent_env(&module->kobj, KOBJ_ADD, envp);
8db00736d365b7 Svetlin Ankov    2016-01-13  181  }
8db00736d365b7 Svetlin Ankov    2016-01-13  182  

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki