[drm-amdgpu:drm-amdgpu-next 166/175] drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c:535 amdgpu_vm_pt_alloc() warn: missing error code 'r'

[drm-amdgpu:drm-amdgpu-next 166/175] drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c:535 amdgpu_vm_pt_alloc() warn: missing error code 'r'

[kernel test robot]

Unfiltered warning: this smatch report is sent as-is and has not been
reviewed for false positives, so please treat it with due skepticism.

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
TO: "Christian König" <christian.koenig@amd.com>
CC: Alex Deucher <alexander.deucher@amd.com>
CC: Natalie Vock <nat@pixelcluster.dev>

tree:   https://gitlab.freedesktop.org/drm/amdgpu/kernel drm-amdgpu-next
head:   41505ac433cc4c5179deee8860d197b04f6d1c1d
commit: 0dc93a683a9470b7cda79468404384c8d50088d4 [166/175] drm/amdgpu: rework eviction lock handling into critical section v3
:::::: branch date: 7 hours ago
:::::: commit date: 28 hours ago
config: i386-randconfig-2200-20261002 (https://download.01.org/0day-ci/archive/20261003/202610030116.Fl3NpsoK-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
smatch: v0.5.0-9187-g5189e3fb

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202610030116.Fl3NpsoK-lkp@intel.com/

smatch warnings:
drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c:535 amdgpu_vm_pt_alloc() warn: missing error code 'r'

vim +/r +535 drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c

184a69ca4d4125 Christian König 2022-03-15  504  
184a69ca4d4125 Christian König 2022-03-15  505  /**
184a69ca4d4125 Christian König 2022-03-15  506   * amdgpu_vm_pt_alloc - Allocate a specific page table
184a69ca4d4125 Christian König 2022-03-15  507   *
0dc93a683a9470 Christian König 2026-05-27  508   * @p: see amdgpu_vm_update_params definition
184a69ca4d4125 Christian König 2022-03-15  509   * @cursor: Which page table to allocate
184a69ca4d4125 Christian König 2022-03-15  510   *
184a69ca4d4125 Christian König 2022-03-15  511   * Make sure a specific page table or directory is allocated.
184a69ca4d4125 Christian König 2022-03-15  512   *
184a69ca4d4125 Christian König 2022-03-15  513   * Returns:
0dc93a683a9470 Christian König 2026-05-27  514   *
0dc93a683a9470 Christian König 2026-05-27  515   * 0 on success or a negative error code on failure.
184a69ca4d4125 Christian König 2022-03-15  516   */
0dc93a683a9470 Christian König 2026-05-27  517  static int amdgpu_vm_pt_alloc(struct amdgpu_vm_update_params *p,
0dc93a683a9470 Christian König 2026-05-27  518  			      struct amdgpu_vm_pt_cursor *cursor)
184a69ca4d4125 Christian König 2022-03-15  519  {
184a69ca4d4125 Christian König 2022-03-15  520  	struct amdgpu_vm_bo_base *entry = cursor->entry;
184a69ca4d4125 Christian König 2022-03-15  521  	struct amdgpu_bo *pt_bo;
184a69ca4d4125 Christian König 2022-03-15  522  	struct amdgpu_bo_vm *pt;
0dc93a683a9470 Christian König 2026-05-27  523  	int r, r2;
184a69ca4d4125 Christian König 2022-03-15  524  
184a69ca4d4125 Christian König 2022-03-15  525  	if (entry->bo)
184a69ca4d4125 Christian König 2022-03-15  526  		return 0;
184a69ca4d4125 Christian König 2022-03-15  527  
0dc93a683a9470 Christian König 2026-05-27  528  	amdgpu_vm_end_critical(p);
0dc93a683a9470 Christian König 2026-05-27  529  	r = amdgpu_vm_pt_create(p->adev, p->vm, cursor->level, p->immediate,
0dc93a683a9470 Christian König 2026-05-27  530  				&pt, p->vm->root.bo->xcp_id);
0dc93a683a9470 Christian König 2026-05-27  531  	r2 = amdgpu_vm_begin_critical(p);
184a69ca4d4125 Christian König 2022-03-15  532  	if (r)
184a69ca4d4125 Christian König 2022-03-15  533  		return r;
0dc93a683a9470 Christian König 2026-05-27  534  	if (r2)
0dc93a683a9470 Christian König 2026-05-27 @535  		goto error_free_pt;
184a69ca4d4125 Christian König 2022-03-15  536  
184a69ca4d4125 Christian König 2022-03-15  537  	/* Keep a reference to the root directory to avoid
184a69ca4d4125 Christian König 2022-03-15  538  	 * freeing them up in the wrong order.
184a69ca4d4125 Christian König 2022-03-15  539  	 */
184a69ca4d4125 Christian König 2022-03-15  540  	pt_bo = &pt->bo;
184a69ca4d4125 Christian König 2022-03-15  541  	pt_bo->parent = amdgpu_bo_ref(cursor->parent->bo);
0dc93a683a9470 Christian König 2026-05-27  542  	amdgpu_vm_bo_base_init(entry, p->vm, pt_bo);
0dc93a683a9470 Christian König 2026-05-27  543  	r = amdgpu_vm_pt_clear(p->adev, p->vm, pt, p->immediate);
184a69ca4d4125 Christian König 2022-03-15  544  	if (r)
0dc93a683a9470 Christian König 2026-05-27  545  		goto error_unpin;
184a69ca4d4125 Christian König 2022-03-15  546  
184a69ca4d4125 Christian König 2022-03-15  547  	return 0;
184a69ca4d4125 Christian König 2022-03-15  548  
0dc93a683a9470 Christian König 2026-05-27  549  error_unpin:
0dc93a683a9470 Christian König 2026-05-27  550  	if (p->vm->is_npa)
e05a54573df7df Felix Kuehling  2026-06-08  551  		amdgpu_bo_unpin(pt_bo);
0dc93a683a9470 Christian König 2026-05-27  552  error_free_pt:
184a69ca4d4125 Christian König 2022-03-15  553  	amdgpu_bo_unref(&pt_bo);
184a69ca4d4125 Christian König 2022-03-15  554  	return r;
184a69ca4d4125 Christian König 2022-03-15  555  }
184a69ca4d4125 Christian König 2022-03-15  556  

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki