[PATCH] staging: rtl8723bs: remove CamelCase variable pbDriverStopped

[PATCH] staging: rtl8723bs: remove CamelCase variable pbDriverStopped

[Luca Hernandez]

Rename the pointer variable pbDriverStopped to driver_stopped to eliminate
the use of CamelCase and Hungarian notation prefixes. This aligns the
driver's HAL code with standard Linux kernel coding style guidelines and
resolves checkpatch.pl audit warnings.

Signed-off-by: Luca Hernandez <lucay202@gmail.com>
---
 drivers/staging/rtl8723bs/hal/odm.c | 2 +-
 drivers/staging/rtl8723bs/hal/odm.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/odm.c b/drivers/staging/rtl8723bs/hal/odm.c
index f3989fa33d9f..505c21bd1847 100644
--- a/drivers/staging/rtl8723bs/hal/odm.c
+++ b/drivers/staging/rtl8723bs/hal/odm.c
@@ -773,7 +773,7 @@ void ODM_CmnInfoHook(struct dm_odm_t *pDM_Odm, enum odm_cmninfo_e CmnInfo, void
 		break;
 
 	case ODM_CMNINFO_DRV_STOP:
-		pDM_Odm->pbDriverStopped =  pValue;
+		pDM_Odm->driver_stopped =  pValue;
 		break;
 
 	case ODM_CMNINFO_PNP_IN:
diff --git a/drivers/staging/rtl8723bs/hal/odm.h b/drivers/staging/rtl8723bs/hal/odm.h
index 3532f0d79363..47034ca1af26 100644
--- a/drivers/staging/rtl8723bs/hal/odm.h
+++ b/drivers/staging/rtl8723bs/hal/odm.h
@@ -848,7 +848,7 @@ struct dm_odm_t { /* DM_Out_Source_Dynamic_Mechanism_Structure */
 
 	/* common */
 
-	bool *pbDriverStopped;
+	bool *driver_stopped;
 	bool *pbDriverIsGoingToPnpSetPowerSleep;
 	bool *pinit_adpt_in_progress;
 
-- 
2.55.0

Re: [PATCH] staging: rtl8723bs: remove CamelCase variable pbDriverStopped

[Greg KH]

On Sat, Oct 03, 2026 at 12:58:19PM +0100, Luca Hernandez wrote:
> Rename the pointer variable pbDriverStopped to driver_stopped to eliminate
> the use of CamelCase and Hungarian notation prefixes. This aligns the
> driver's HAL code with standard Linux kernel coding style guidelines and
> resolves checkpatch.pl audit warnings.
> 
> Signed-off-by: Luca Hernandez <lucay202@gmail.com>
> ---
>  drivers/staging/rtl8723bs/hal/odm.c | 2 +-
>  drivers/staging/rtl8723bs/hal/odm.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/odm.c b/drivers/staging/rtl8723bs/hal/odm.c
> index f3989fa33d9f..505c21bd1847 100644
> --- a/drivers/staging/rtl8723bs/hal/odm.c
> +++ b/drivers/staging/rtl8723bs/hal/odm.c
> @@ -773,7 +773,7 @@ void ODM_CmnInfoHook(struct dm_odm_t *pDM_Odm, enum odm_cmninfo_e CmnInfo, void
>  		break;
>  
>  	case ODM_CMNINFO_DRV_STOP:
> -		pDM_Odm->pbDriverStopped =  pValue;
> +		pDM_Odm->driver_stopped =  pValue;

So this is only set but never done anything with at all?  Why is this
needed?  Why not just remove this field entirely?

thanks,

greg k-h