Re: [PATCH v2 13/21] arm64: dts: apple: t8103-j45x: Add headset jack nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dts: missing compatible fallback for j457 macaudio
--

commit a6a8b80fc66fd2ea6915047fd678103277b8c956
Author: James Calligeros <jcalligeros99@gmail.com>

arm64: dts: apple: t8103-j45x: Add headset jack nodes

This commit adds headset jack nodes for the M1 iMacs and advertises them
to the machine driver via the sound node.

> diff --git a/arch/arm64/boot/dts/apple/t8103-j457.dts b/arch/arm64/boot/dts/apple/t8103-j457.dts
> index ebddde75455c6..d8ea6bb53b3f1 100644
> --- a/arch/arm64/boot/dts/apple/t8103-j457.dts
> +++ b/arch/arm64/boot/dts/apple/t8103-j457.dts
[ ... ]
> @@ -69,3 +69,41 @@ ethernet0: ethernet@0,0 {
[ ... ]
> +/ {
> +	sound: sound {
> +		compatible = "apple,j457-macaudio";

[Severity: Medium]
Does this compatible string need "apple,j456-macaudio" as a fallback?

The ASoC driver sound/soc/apple/macaudio.c does not contain
"apple,j457-macaudio" in its of_device_id match table, and appears to
expect j457 to use j456 as a fallback. Without the fallback string
in the device tree (such as "apple,j457-macaudio", "apple,j456-macaudio"),
the platform bus will not bind the driver, which could leave the J457
iMac without functional audio.

> +		model = "iMac J457";
> +
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		dai-link@1 {
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261004-macaudio-v2-0-7b47ed6335a8@gmail.com?part=13