Re: [PATCH v2 05/21] ASoC: dt-bindings: Add binding for Apple Silicon Mac audio

[Krzysztof Kozlowski <krzk@kernel.org>]

On 09/10/2026 09:21, James Calligeros wrote:
> On Friday, 9 October 2026 5:17:53 pm Australian Eastern Standard Time 
> Krzysztof Kozlowski wrote:
>> On Sun, Oct 04, 2026 at 04:03:32PM +1000, James Calligeros wrote:
>>> +examples:
>>> +  - |
>>> +    sound {
>>> +      compatible = "apple,j416-macaudio", "apple,j316-macaudio";
>>> +      model = "MacBook Pro J416";
>>> +
>>> +      #address-cells = <1>;
>>> +      #size-cells = <0>;
>>> +
>>> +      dai-link@0 {
>>> +        reg = <0>;
>>> +        link-name = "Speakers";
>>> +
>>> +        dai-tdm-idle-mode-0 = "zero";
>>> +        dai-tdm-idle-mode-3 = "zero";
>>> +        dai-tdm-slot-tx-idle-mask-0 = <0xf0f0f0>;
>>> +        dai-tdm-slot-tx-idle-mask-3 = <0x0f0f0f>;
>>> +
>>> +        codec {
>>> +          sound-dai = <&speaker_left_woof1>,
>>> +                      <&speaker_left_tweet>,
>>> +                      <&speaker_left_woof2>,
>>> +                      <&speaker_right_woof1>,
>>> +                      <&speaker_right_tweet>,
>>> +                      <&speaker_right_woof2>;
>>> +        };
>>> +
>>> +        cpu {
>>> +          sound-dai = <&mca 0>, <&mca 1>;
>>> +        };
>>> +      };
>>> +
>>> +      dai-link@1 {
>>> +        reg = <1>;
>>> +        link-name = "Headphone Jack";
>>> +
>>> +        codec {
>>> +          sound-dai = <&jack_codec>;
>>> +        };
>>> +
>>> +        cpu {
>>> +          sound-dai = <&mca 2>;
>>
>> Example looks incomplete, you miss TDM slot properties.
> 
> The machine driver generates the TDM slot assignments for the DAIs
> and sets them at runtime.

Ah, I found them in dai-link node, one level up.

Best regards,
Krzysztof