Re: nfs/localio: pin clients during global invalidation

Re: nfs/localio: pin clients during global invalidation

[kernel test robot]

Hi Jinpyo,

kernel test robot noticed the following build errors:



url:    https://github.com/intel-lab-lkp/linux/commits/Jinpyo-Lee/nfs-localio-pin-clients-during-global-invalidation/20260930-145053
base:   
patch link:    https://lore.kernel.org/r/202610040648.34KSnXrl-lkp%40intel.com
config: nios2-randconfig-1001-20261003 (https://download.01.org/0day-ci/archive/20261004/202610040648.34KSnXrl-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 11.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261004/202610040648.34KSnXrl-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202610040648.34KSnXrl-lkp@intel.com/

All errors (new ones prefixed by >>):

   nios2-linux-ld: fs/nfs_common/nfslocalio.o: in function `nfs_localio_invalidate_clients':
>> fs/nfs_common/nfslocalio.c:253:(.text+0x7f0): undefined reference to `nfs_put_client'
>> fs/nfs_common/nfslocalio.c:253:(.text+0x7f0): relocation truncated to fit: R_NIOS2_CALL26 against `nfs_put_client'


vim +253 fs/nfs_common/nfslocalio.c

   225	
   226	void nfs_localio_invalidate_clients(struct list_head *nn_local_clients,
   227					    spinlock_t *nn_local_clients_lock)
   228	{
   229		nfs_uuid_t *nfs_uuid;
   230		struct nfs_client *clp;
   231	
   232		for (;;) {
   233			spin_lock(nn_local_clients_lock);
   234			nfs_uuid = list_first_entry_or_null(nn_local_clients,
   235							    nfs_uuid_t, list);
   236			if (!nfs_uuid) {
   237				spin_unlock(nn_local_clients_lock);
   238				break;
   239			}
   240			if (WARN_ON(nfs_uuid->list_lock != nn_local_clients_lock)) {
   241				spin_unlock(nn_local_clients_lock);
   242				break;
   243			}
   244			clp = container_of(nfs_uuid, struct nfs_client, cl_uuid);
   245			if (!refcount_inc_not_zero(&clp->cl_count)) {
   246				spin_unlock(nn_local_clients_lock);
   247				cond_resched();
   248				continue;
   249			}
   250			spin_unlock(nn_local_clients_lock);
   251	
   252			nfs_localio_disable_client(clp);
 > 253			nfs_put_client(clp);
   254		}
   255	}
   256	EXPORT_SYMBOL_GPL(nfs_localio_invalidate_clients);
   257	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki