From: sashiko-bot@kernel.org
To: "Arnaldo Carvalho de Melo" <acme@kernel.org>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v10 2/9] perf config: Make perf_etc_perfconfig() never return NULL
Date: Sun, 04 Oct 2026 10:28:28 +0000 [thread overview]
Message-ID: <20261004102828.6FEE71F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20261004102133.26392-3-acme@kernel.org>
> From: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> perf_etc_perfconfig() returns what system_path() gives, and that
> allocates, so on failure every caller dereferenced NULL, the
> pre-existing ones in perf_config_set__init() and in the daemon
> included. For the usual absolute ETC_PERFCONFIG system_path() just
> returns a strdup of it, so use ETC_PERFCONFIG itself when that fails.
>
> Assisted-by: LLM
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261004102133.26392-1-acme@kernel.org?part=2
next prev parent reply other threads:[~2026-10-04 10:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-04 10:21 [PATCH v10 0/9] perf tools: Add progress diagnostics and a false-sharing workload Arnaldo Carvalho de Melo
2026-10-04 10:21 ` [PATCH v10 1/9] perf config: Move perf_config__set_variable() to util/config.c Arnaldo Carvalho de Melo
2026-10-04 10:33 ` sashiko-bot
2026-10-04 10:21 ` [PATCH v10 2/9] perf config: Make perf_etc_perfconfig() never return NULL Arnaldo Carvalho de Melo
2026-10-04 10:28 ` sashiko-bot [this message]
2026-10-04 10:21 ` [PATCH v10 3/9] perf mutex: Add DEFINE_MUTEX() static initializer Arnaldo Carvalho de Melo
2026-10-04 10:26 ` sashiko-bot
2026-10-04 10:21 ` [PATCH v10 4/9] perf mutex: Add DO_ONCE() for one-time initialization Arnaldo Carvalho de Melo
2026-10-04 10:27 ` sashiko-bot
2026-10-04 10:21 ` [PATCH v10 5/9] perf config: Serialize config file access with a mutex Arnaldo Carvalho de Melo
2026-10-04 10:31 ` sashiko-bot
2026-10-04 10:21 ` [PATCH v10 6/9] perf report: Add --progress option Arnaldo Carvalho de Melo
2026-10-04 10:28 ` sashiko-bot
2026-10-04 10:21 ` [PATCH v10 7/9] perf report: Add --no-progress option Arnaldo Carvalho de Melo
2026-10-04 10:29 ` sashiko-bot
2026-10-04 10:21 ` [PATCH v10 8/9] perf scripts: Add perf-stuck, to tell where a running perf is stuck Arnaldo Carvalho de Melo
2026-10-04 10:30 ` sashiko-bot
2026-10-04 10:21 ` [PATCH v10 9/9] perf test: Add false_sharing workload exhibiting cross-CPU false sharing Arnaldo Carvalho de Melo
2026-10-04 10:27 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261004102828.6FEE71F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=acme@kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.