* [PATCH] hwmon: (asus-ec-sensors) add CPU_Opt fan for ROG STRIX X570-E GAMING
@ 2026-10-04 14:26 ` Matt Layher
0 siblings, 0 replies; 4+ messages in thread
From: Matt Layher via B4 Relay @ 2026-10-04 14:26 UTC (permalink / raw)
To: Eugene Shalygin, Guenter Roeck; +Cc: linux-hwmon, linux-kernel, Matt Layher
From: Matt Layher <mdlayher@gmail.com>
Enable the CPU_Opt fan sensor for ROG STRIX X570-E GAMING.
The board has a CPU_OPT fan header, and its UEFI hardware monitor shows a
fan connected to it spinning at about 2000 RPM, but the driver does not
expose the sensor and the board's NCT6798D does not report it either.
Reading the EC directly through ec_sys on this board (BIOS 4408), the
CPU_Opt register used by the rest of the AMD 500 series family (bank 0,
0xb0) returns 0x0580, 1408 RPM under the operating system's fan curve,
while the chipset fan register at 0xb4 returns 0, matching what the
driver already reports for that fan.
Assisted-by: LLM sparse
Signed-off-by: Matt Layher <mdlayher@gmail.com>
---
An LLM coding assistant did most of the work on this patch: it found the
missing sensor while auditing this machine's monitoring, compared the
driver's board table with the BIOS hardware monitor, worked out which EC
register to read, and drafted the change and this changelog. I
reviewed both, and every test below ran on my own machines.
Testing:
- Runtime: the same one-line change applied to the driver in v6.18.54,
loaded on the board in place of the stock module; CPU_Opt read
1454-1463 RPM and the chipset fan 0.
- Build: hwmon-next with W=1 and sparse (C=1), no warnings;
checkpatch --strict reports no errors, warnings or checks.
---
drivers/hwmon/asus-ec-sensors.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwmon/asus-ec-sensors.c b/drivers/hwmon/asus-ec-sensors.c
index 19f423e45ce5..8261ddd00653 100644
--- a/drivers/hwmon/asus-ec-sensors.c
+++ b/drivers/hwmon/asus-ec-sensors.c
@@ -721,7 +721,7 @@ static const struct ec_board_info board_info_strix_x470_i_gaming = {
static const struct ec_board_info board_info_strix_x570_e_gaming = {
.sensors = SENSOR_SET_TEMP_CHIPSET_CPU_MB |
- SENSOR_TEMP_T_SENSOR |
+ SENSOR_TEMP_T_SENSOR | SENSOR_FAN_CPU_OPT |
SENSOR_FAN_CHIPSET | SENSOR_CURR_CPU |
SENSOR_IN_CPU_CORE,
.mutex_path = ASUS_HW_ACCESS_MUTEX_ASMX,
---
base-commit: 4781ca52761e666cf18b591e6bb0478396c90320
change-id: 20261004-asus-ec-x570e-cpu-opt-623621af0790
Best regards,
--
Matt Layher <mdlayher@gmail.com>
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] hwmon: (asus-ec-sensors) add CPU_Opt fan for ROG STRIX X570-E GAMING
@ 2026-10-04 14:26 ` Matt Layher
0 siblings, 0 replies; 4+ messages in thread
From: Matt Layher @ 2026-10-04 14:26 UTC (permalink / raw)
To: Eugene Shalygin, Guenter Roeck; +Cc: linux-hwmon, linux-kernel, Matt Layher
Enable the CPU_Opt fan sensor for ROG STRIX X570-E GAMING.
The board has a CPU_OPT fan header, and its UEFI hardware monitor shows a
fan connected to it spinning at about 2000 RPM, but the driver does not
expose the sensor and the board's NCT6798D does not report it either.
Reading the EC directly through ec_sys on this board (BIOS 4408), the
CPU_Opt register used by the rest of the AMD 500 series family (bank 0,
0xb0) returns 0x0580, 1408 RPM under the operating system's fan curve,
while the chipset fan register at 0xb4 returns 0, matching what the
driver already reports for that fan.
Assisted-by: LLM sparse
Signed-off-by: Matt Layher <mdlayher@gmail.com>
---
An LLM coding assistant did most of the work on this patch: it found the
missing sensor while auditing this machine's monitoring, compared the
driver's board table with the BIOS hardware monitor, worked out which EC
register to read, and drafted the change and this changelog. I
reviewed both, and every test below ran on my own machines.
Testing:
- Runtime: the same one-line change applied to the driver in v6.18.54,
loaded on the board in place of the stock module; CPU_Opt read
1454-1463 RPM and the chipset fan 0.
- Build: hwmon-next with W=1 and sparse (C=1), no warnings;
checkpatch --strict reports no errors, warnings or checks.
---
drivers/hwmon/asus-ec-sensors.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwmon/asus-ec-sensors.c b/drivers/hwmon/asus-ec-sensors.c
index 19f423e45ce5..8261ddd00653 100644
--- a/drivers/hwmon/asus-ec-sensors.c
+++ b/drivers/hwmon/asus-ec-sensors.c
@@ -721,7 +721,7 @@ static const struct ec_board_info board_info_strix_x470_i_gaming = {
static const struct ec_board_info board_info_strix_x570_e_gaming = {
.sensors = SENSOR_SET_TEMP_CHIPSET_CPU_MB |
- SENSOR_TEMP_T_SENSOR |
+ SENSOR_TEMP_T_SENSOR | SENSOR_FAN_CPU_OPT |
SENSOR_FAN_CHIPSET | SENSOR_CURR_CPU |
SENSOR_IN_CPU_CORE,
.mutex_path = ASUS_HW_ACCESS_MUTEX_ASMX,
---
base-commit: 4781ca52761e666cf18b591e6bb0478396c90320
change-id: 20261004-asus-ec-x570e-cpu-opt-623621af0790
Best regards,
--
Matt Layher <mdlayher@gmail.com>
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] hwmon: (asus-ec-sensors) add CPU_Opt fan for ROG STRIX X570-E GAMING
2026-10-04 14:26 ` Matt Layher
(?)
@ 2026-10-04 14:32 ` sashiko-bot
-1 siblings, 0 replies; 4+ messages in thread
From: sashiko-bot @ 2026-10-04 14:32 UTC (permalink / raw)
To: Matt Layher; +Cc: linux-hwmon
> From: Matt Layher <mdlayher@gmail.com>
>
> Enable the CPU_Opt fan sensor for ROG STRIX X570-E GAMING.
>
> The board has a CPU_OPT fan header, and its UEFI hardware monitor shows a
> fan connected to it spinning at about 2000 RPM, but the driver does not
> expose the sensor and the board's NCT6798D does not report it either.
>
> Reading the EC directly through ec_sys on this board (BIOS 4408), the
> CPU_Opt register used by the rest of the AMD 500 series family (bank 0,
> 0xb0) returns 0x0580, 1408 RPM under the operating system's fan curve,
> while the chipset fan register at 0xb4 returns 0, matching what the
> driver already reports for that fan.
>
> Assisted-by: LLM sparse
> Signed-off-by: Matt Layher <mdlayher@gmail.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261004-asus-ec-x570e-cpu-opt-v1-1-d9ea371c30d5@gmail.com?part=1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] hwmon: (asus-ec-sensors) add CPU_Opt fan for ROG STRIX X570-E GAMING
2026-10-04 14:26 ` Matt Layher
(?)
(?)
@ 2026-10-06 11:48 ` Eugene Shalygin
-1 siblings, 0 replies; 4+ messages in thread
From: Eugene Shalygin @ 2026-10-06 11:48 UTC (permalink / raw)
To: mdlayher; +Cc: Guenter Roeck, linux-hwmon, linux-kernel
Hi Matt,
On Sun, 4 Oct 2026 at 16:26, Matt Layher via B4 Relay
<devnull+mdlayher.gmail.com@kernel.org> wrote:
>
> From: Matt Layher <mdlayher@gmail.com>
>
> Enable the CPU_Opt fan sensor for ROG STRIX X570-E GAMING.
Can we have a laconic description for this more or less trivial change, please?
Cheers,
Eugene
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-10-06 11:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-04 14:26 [PATCH] hwmon: (asus-ec-sensors) add CPU_Opt fan for ROG STRIX X570-E GAMING Matt Layher via B4 Relay
2026-10-04 14:26 ` Matt Layher
2026-10-04 14:32 ` sashiko-bot
2026-10-06 11:48 ` Eugene Shalygin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.