Re: remoteproc: core: add KUnit tests for rproc_check_carveout_da()

Re: remoteproc: core: add KUnit tests for rproc_check_carveout_da()

[kernel test robot]

Hi Sailesh,

kernel test robot noticed the following build warnings:



url:    https://github.com/intel-lab-lkp/linux/commits/Sailesh-Nandanavanam/remoteproc-core-add-KUnit-tests-for-rproc_check_carveout_da/20260927-225428
base:   
patch link:    https://lore.kernel.org/r/202610042130.ObA85SKb-lkp%40intel.com
config: xtensa-allyesconfig (https://download.01.org/0day-ci/archive/20261004/202610042130.ObA85SKb-lkp@intel.com/config)
compiler: xtensa-linux-gcc (GCC) 16.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261004/202610042130.ObA85SKb-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202610042130.ObA85SKb-lkp@intel.com/

All warnings (new ones prefixed by >>):

   In file included from drivers/remoteproc/remoteproc_core.c:2847:
   drivers/remoteproc/tests/remoteproc_core-kunit.h: In function 'rproc_test_check_carveout_len_exceeds':
>> drivers/remoteproc/tests/remoteproc_core-kunit.h:34:1: warning: the frame size of 1728 bytes is larger than 1536 bytes [-Wframe-larger-than=]
      34 | }
         | ^
   drivers/remoteproc/tests/remoteproc_core-kunit.h: In function 'rproc_test_check_carveout_da_exceeds_end':
   drivers/remoteproc/tests/remoteproc_core-kunit.h:76:1: warning: the frame size of 1744 bytes is larger than 1536 bytes [-Wframe-larger-than=]
      76 | }
         | ^
   drivers/remoteproc/tests/remoteproc_core-kunit.h: In function 'rproc_test_check_carveout_da_negative_delta':
   drivers/remoteproc/tests/remoteproc_core-kunit.h:62:1: warning: the frame size of 1744 bytes is larger than 1536 bytes [-Wframe-larger-than=]
      62 | }
         | ^


vim +34 drivers/remoteproc/tests/remoteproc_core-kunit.h

     6	
     7	/*
     8	 * Tests for rproc_check_carveout_da().
     9	 *
    10	 * The function is static, so this header is #include'd directly at the
    11	 * bottom of remoteproc_core.c (see CONFIG_REMOTEPROC_KUNIT_TEST), giving
    12	 * it access to the symbol despite the lack of external linkage.
    13	 *
    14	 * rproc_check_carveout_da() only touches &rproc->dev for dev_err() on
    15	 * its failure paths, so a zeroed struct rproc is sufficient here -- no
    16	 * device registration needed. dev_err()'s formatting chain
    17	 * (dev_driver_string() -> "" on NULL driver/bus/class, dev_name() ->
    18	 * NULL on an unregistered device, and the kernel's own %s NULL guard
    19	 * in lib/vsprintf.c) is safe end-to-end against a bare zeroed device.
    20	 */
    21	
    22	static void rproc_test_check_carveout_len_exceeds(struct kunit *test)
    23	{
    24		struct rproc rproc = { 0 };
    25		struct rproc_mem_entry mem = { 0 };
    26		int ret;
    27	
    28		/* mem->len = 0x100; request len 0x200 with no da constraint */
    29		mem.da = FW_RSC_ADDR_ANY;
    30		mem.len = 0x100;
    31	
    32		ret = rproc_check_carveout_da(&rproc, &mem, FW_RSC_ADDR_ANY, 0x200);
    33		KUNIT_EXPECT_EQ(test, ret, -EINVAL);
  > 34	}
    35	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki