From: Jamin Lin <jamin_lin@aspeedtech.com>
To: "Cédric Le Goater" <clg@kaod.org>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Steven Lee" <steven_lee@aspeedtech.com>,
"Troy Lee" <leetroy@gmail.com>,
"Kane Chen" <kane_chen@aspeedtech.com>,
"Andrew Jeffery" <andrew@codeconstruct.com.au>,
"Joel Stanley" <joel@jms.id.au>,
"open list:ASPEED BMCs" <qemu-arm@nongnu.org>,
"open list:All patches CC here" <qemu-devel@nongnu.org>
Cc: "Jamin Lin" <jamin_lin@aspeedtech.com>,
"Troy Lee" <troy_lee@aspeedtech.com>,
"Cédric Le Goater" <clg@redhat.com>
Subject: [PATCH v2 1/2] hw/arm/aspeed: Sort device IDs alphabetically
Date: Mon, 5 Oct 2026 02:04:29 +0000 [thread overview]
Message-ID: <20261005020428.3496039-2-jamin_lin@aspeedtech.com> (raw)
In-Reply-To: <20261005020428.3496039-1-jamin_lin@aspeedtech.com>
The ASPEED device ID enum has grown over time without a consistent
ordering rule. This makes it difficult to determine where new device
IDs should be added and reduces readability and maintainability as
more devices are introduced.
Sort the device IDs alphabetically to provide a consistent ordering
rule. Keep related numbered devices together, such as SPI0, SPI1 and
SPI2.
No functional change.
Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
---
include/hw/arm/aspeed_soc.h | 176 ++++++++++++++++++------------------
1 file changed, 88 insertions(+), 88 deletions(-)
diff --git a/include/hw/arm/aspeed_soc.h b/include/hw/arm/aspeed_soc.h
index 38226d9b80..a110385743 100644
--- a/include/hw/arm/aspeed_soc.h
+++ b/include/hw/arm/aspeed_soc.h
@@ -195,64 +195,56 @@ struct AspeedSoCClass {
};
enum {
- ASPEED_DEV_VBOOTROM,
- ASPEED_DEV_SPI_BOOT,
- ASPEED_DEV_IOMEM,
- ASPEED_DEV_IOMEM0,
- ASPEED_DEV_IOMEM1,
- ASPEED_DEV_UART0,
- ASPEED_DEV_UART1,
- ASPEED_DEV_UART2,
- ASPEED_DEV_UART3,
- ASPEED_DEV_UART4,
- ASPEED_DEV_UART5,
- ASPEED_DEV_UART6,
- ASPEED_DEV_UART7,
- ASPEED_DEV_UART8,
- ASPEED_DEV_UART9,
- ASPEED_DEV_UART10,
- ASPEED_DEV_UART11,
- ASPEED_DEV_UART12,
- ASPEED_DEV_UART13,
- ASPEED_DEV_VUART,
- ASPEED_DEV_FMC,
- ASPEED_DEV_SPI0,
- ASPEED_DEV_SPI1,
- ASPEED_DEV_SPI2,
+ ASPEED_DEV_ACRY,
+ ASPEED_DEV_ADC,
+ ASPEED_DEV_DP,
+ ASPEED_DEV_DPMCU,
ASPEED_DEV_EHCI1,
ASPEED_DEV_EHCI2,
ASPEED_DEV_EHCI3,
ASPEED_DEV_EHCI4,
- ASPEED_DEV_VIC,
- ASPEED_DEV_INTC,
- ASPEED_DEV_INTCIO,
- ASPEED_DEV_SDMC,
- ASPEED_DEV_SCU,
- ASPEED_DEV_ADC,
- ASPEED_DEV_SBC,
+ ASPEED_DEV_EMMC,
ASPEED_DEV_EMMC_BC,
- ASPEED_DEV_VIDEO,
- ASPEED_DEV_SRAM0,
- ASPEED_DEV_SRAM1,
- ASPEED_DEV_SDHCI,
+ ASPEED_DEV_ESPI,
+ ASPEED_DEV_ETH1,
+ ASPEED_DEV_ETH2,
+ ASPEED_DEV_ETH3,
+ ASPEED_DEV_ETH4,
+ ASPEED_DEV_FMC,
+ ASPEED_DEV_FSI1,
+ ASPEED_DEV_FSI2,
ASPEED_DEV_GPIO,
ASPEED_DEV_GPIO_1_8V,
- ASPEED_DEV_SGPIOM0,
- ASPEED_DEV_SGPIOM1,
- ASPEED_DEV_RTC,
- ASPEED_DEV_TIMER1,
- ASPEED_DEV_TIMER2,
- ASPEED_DEV_TIMER3,
- ASPEED_DEV_TIMER4,
- ASPEED_DEV_TIMER5,
- ASPEED_DEV_TIMER6,
- ASPEED_DEV_TIMER7,
- ASPEED_DEV_TIMER8,
- ASPEED_DEV_WDT,
- ASPEED_DEV_PWM,
- ASPEED_DEV_LPC,
- ASPEED_DEV_IBT,
+ ASPEED_DEV_HACE,
ASPEED_DEV_I2C,
+ ASPEED_DEV_I3C,
+ ASPEED_DEV_IBT,
+ ASPEED_DEV_INTC,
+ ASPEED_DEV_INTCIO,
+ ASPEED_DEV_IOMEM,
+ ASPEED_DEV_IOMEM0,
+ ASPEED_DEV_IOMEM1,
+ ASPEED_DEV_IOEXP0_I2C,
+ ASPEED_DEV_IOEXP1_I2C,
+ ASPEED_DEV_IOEXP0_I3C,
+ ASPEED_DEV_IOEXP1_I3C,
+ ASPEED_DEV_IOEXP0_INTCIO,
+ ASPEED_DEV_IOEXP1_INTCIO,
+ ASPEED_DEV_IPC0,
+ ASPEED_DEV_IPC1,
+ ASPEED_DEV_JTAG0,
+ ASPEED_DEV_JTAG1,
+ ASPEED_DEV_KCS,
+ ASPEED_DEV_LPC,
+ ASPEED_DEV_LTPI_CTRL1,
+ ASPEED_DEV_LTPI_CTRL2,
+ ASPEED_DEV_LTPI_IO0,
+ ASPEED_DEV_LTPI_IO1,
+ ASPEED_DEV_MII1,
+ ASPEED_DEV_MII2,
+ ASPEED_DEV_MII3,
+ ASPEED_DEV_MII4,
+ ASPEED_DEV_OTP,
ASPEED_DEV_PCIE0,
ASPEED_DEV_PCIE1,
ASPEED_DEV_PCIE2,
@@ -263,49 +255,57 @@ enum {
ASPEED_DEV_PCIE_MMIO1,
ASPEED_DEV_PCIE_MMIO2,
ASPEED_DEV_PECI,
- ASPEED_DEV_ETH1,
- ASPEED_DEV_ETH2,
- ASPEED_DEV_ETH3,
- ASPEED_DEV_ETH4,
- ASPEED_DEV_MII1,
- ASPEED_DEV_MII2,
- ASPEED_DEV_MII3,
- ASPEED_DEV_MII4,
- ASPEED_DEV_SDRAM,
- ASPEED_DEV_XDMA,
- ASPEED_DEV_EMMC,
- ASPEED_DEV_KCS,
- ASPEED_DEV_HACE,
- ASPEED_DEV_ACRY,
- ASPEED_DEV_DPMCU,
- ASPEED_DEV_DP,
- ASPEED_DEV_I3C,
- ASPEED_DEV_ESPI,
- ASPEED_DEV_UDC,
- ASPEED_DEV_JTAG0,
- ASPEED_DEV_JTAG1,
- ASPEED_DEV_FSI1,
- ASPEED_DEV_FSI2,
+ ASPEED_DEV_PRIC0,
+ ASPEED_DEV_PRIC1,
+ ASPEED_DEV_PWM,
+ ASPEED_DEV_RTC,
+ ASPEED_DEV_SBC,
+ ASPEED_DEV_SCU,
ASPEED_DEV_SCUIO,
+ ASPEED_DEV_SDHCI,
+ ASPEED_DEV_SDMC,
+ ASPEED_DEV_SDRAM,
+ ASPEED_DEV_SGPIOM0,
+ ASPEED_DEV_SGPIOM1,
ASPEED_DEV_SLI,
ASPEED_DEV_SLIIO,
+ ASPEED_DEV_SPI_BOOT,
+ ASPEED_DEV_SPI0,
+ ASPEED_DEV_SPI1,
+ ASPEED_DEV_SPI2,
+ ASPEED_DEV_SRAM0,
+ ASPEED_DEV_SRAM1,
+ ASPEED_DEV_TIMER1,
+ ASPEED_DEV_TIMER2,
+ ASPEED_DEV_TIMER3,
+ ASPEED_DEV_TIMER4,
+ ASPEED_DEV_TIMER5,
+ ASPEED_DEV_TIMER6,
+ ASPEED_DEV_TIMER7,
+ ASPEED_DEV_TIMER8,
+ ASPEED_DEV_UART0,
+ ASPEED_DEV_UART1,
+ ASPEED_DEV_UART2,
+ ASPEED_DEV_UART3,
+ ASPEED_DEV_UART4,
+ ASPEED_DEV_UART5,
+ ASPEED_DEV_UART6,
+ ASPEED_DEV_UART7,
+ ASPEED_DEV_UART8,
+ ASPEED_DEV_UART9,
+ ASPEED_DEV_UART10,
+ ASPEED_DEV_UART11,
+ ASPEED_DEV_UART12,
+ ASPEED_DEV_UART13,
+ ASPEED_DEV_UDC,
+ ASPEED_DEV_VBOOTROM,
+ ASPEED_DEV_VIC,
+ ASPEED_DEV_VIDEO,
+ ASPEED_DEV_VUART,
+ ASPEED_DEV_WDT,
+ ASPEED_DEV_XDMA,
ASPEED_GIC_DIST,
ASPEED_GIC_REDIST,
- ASPEED_DEV_IPC0,
- ASPEED_DEV_IPC1,
- ASPEED_DEV_LTPI_CTRL1,
- ASPEED_DEV_LTPI_CTRL2,
- ASPEED_DEV_LTPI_IO0,
- ASPEED_DEV_LTPI_IO1,
- ASPEED_DEV_IOEXP0_I2C,
- ASPEED_DEV_IOEXP1_I2C,
- ASPEED_DEV_IOEXP0_INTCIO,
- ASPEED_DEV_IOEXP1_INTCIO,
- ASPEED_DEV_IOEXP0_I3C,
- ASPEED_DEV_IOEXP1_I3C,
- ASPEED_DEV_PRIC0,
- ASPEED_DEV_PRIC1,
- ASPEED_DEV_OTP,
};
const char *aspeed_soc_cpu_type(const char * const *valid_cpu_types);
--
2.43.0
next prev parent reply other threads:[~2026-10-05 2:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-05 2:04 [PATCH v2 0/2] hw/arm/aspeed: Sort device IDs and add IO expander test Jamin Lin
2026-10-05 2:04 ` Jamin Lin [this message]
2026-10-05 2:04 ` [PATCH v2 2/2] tests/functional/aarch64/test_aspeed_ast2700a2: Add I2C test for IO expander 1 Jamin Lin
2026-10-07 13:08 ` Cédric Le Goater
2026-10-07 13:10 ` [PATCH v2 0/2] hw/arm/aspeed: Sort device IDs and add IO expander test Cédric Le Goater
2026-10-08 0:52 ` Jamin Lin
2026-10-08 21:09 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261005020428.3496039-2-jamin_lin@aspeedtech.com \
--to=jamin_lin@aspeedtech.com \
--cc=andrew@codeconstruct.com.au \
--cc=clg@kaod.org \
--cc=clg@redhat.com \
--cc=joel@jms.id.au \
--cc=kane_chen@aspeedtech.com \
--cc=leetroy@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=steven_lee@aspeedtech.com \
--cc=troy_lee@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.