All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bradley Morgan <brads@mainlining.org>
To: akpm@linux-foundation.org, vgupta@kernel.org, guoren@kernel.org,
	chris@zankel.net, jcmvbkbc@gmail.com
Cc: arnd@arndb.de, paulmck@kernel.org, david.laight.linux@gmail.com,
	glaubitz@physik.fu-berlin.de, ysato@users.sourceforge.jp,
	dalias@libc.org, linux-snps-arc@lists.infradead.org,
	linux-csky@vger.kernel.org, linux-kernel@vger.kernel.org,
	brads@mainlining.org
Subject: [PATCH v5 3/3] xtensa: Emulate two-byte cmpxchg
Date: Mon,  5 Oct 2026 12:07:00 +0000	[thread overview]
Message-ID: <20261005120700.383058-4-brads@mainlining.org> (raw)
In-Reply-To: <20261005120700.383058-1-brads@mainlining.org>

Xtensa has no two-byte atomic compare and swap, so the __cmpxchg()
switch lets case 2 fall through to __cmpxchg_called_with_bad_pointer(),
which is declared but never defined, so a two-byte cmpxchg() fails
at link time.

Route case 2 through the new cmpxchg_emu_u16(), which takes the
old and new values as unsigned long and narrows them itself, so
the call needs no extra casts.

Signed-off-by: Bradley Morgan <brads@mainlining.org>
---
 arch/xtensa/include/asm/cmpxchg.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/xtensa/include/asm/cmpxchg.h b/arch/xtensa/include/asm/cmpxchg.h
index b6db4838b175..8dea8e357fc0 100644
--- a/arch/xtensa/include/asm/cmpxchg.h
+++ b/arch/xtensa/include/asm/cmpxchg.h
@@ -76,6 +76,7 @@ __cmpxchg(volatile void *ptr, unsigned long old, unsigned long new, int size)
 {
 	switch (size) {
 	case 1:  return cmpxchg_emu_u8(ptr, old, new);
+	case 2:  return cmpxchg_emu_u16(ptr, old, new);
 	case 4:  return __cmpxchg_u32(ptr, old, new);
 	default: __cmpxchg_called_with_bad_pointer();
 		 return old;
-- 
2.53.0


WARNING: multiple messages have this Message-ID (diff)
From: Bradley Morgan <brads@mainlining.org>
To: akpm@linux-foundation.org, vgupta@kernel.org, guoren@kernel.org,
	chris@zankel.net, jcmvbkbc@gmail.com
Cc: arnd@arndb.de, paulmck@kernel.org, david.laight.linux@gmail.com,
	glaubitz@physik.fu-berlin.de, ysato@users.sourceforge.jp,
	dalias@libc.org, linux-snps-arc@lists.infradead.org,
	linux-csky@vger.kernel.org, linux-kernel@vger.kernel.org,
	brads@mainlining.org
Subject: [PATCH v5 3/3] xtensa: Emulate two-byte cmpxchg
Date: Mon,  5 Oct 2026 12:07:00 +0000	[thread overview]
Message-ID: <20261005120700.383058-4-brads@mainlining.org> (raw)
In-Reply-To: <20261005120700.383058-1-brads@mainlining.org>

Xtensa has no two-byte atomic compare and swap, so the __cmpxchg()
switch lets case 2 fall through to __cmpxchg_called_with_bad_pointer(),
which is declared but never defined, so a two-byte cmpxchg() fails
at link time.

Route case 2 through the new cmpxchg_emu_u16(), which takes the
old and new values as unsigned long and narrows them itself, so
the call needs no extra casts.

Signed-off-by: Bradley Morgan <brads@mainlining.org>
---
 arch/xtensa/include/asm/cmpxchg.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/xtensa/include/asm/cmpxchg.h b/arch/xtensa/include/asm/cmpxchg.h
index b6db4838b175..8dea8e357fc0 100644
--- a/arch/xtensa/include/asm/cmpxchg.h
+++ b/arch/xtensa/include/asm/cmpxchg.h
@@ -76,6 +76,7 @@ __cmpxchg(volatile void *ptr, unsigned long old, unsigned long new, int size)
 {
 	switch (size) {
 	case 1:  return cmpxchg_emu_u8(ptr, old, new);
+	case 2:  return cmpxchg_emu_u16(ptr, old, new);
 	case 4:  return __cmpxchg_u32(ptr, old, new);
 	default: __cmpxchg_called_with_bad_pointer();
 		 return old;
-- 
2.53.0

_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc

  parent reply	other threads:[~2026-10-05 12:09 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-05 12:06 [PATCH v5 0/3] Add two-byte cmpxchg emulation and wire it into the architectures Bradley Morgan
2026-10-05 12:06 ` Bradley Morgan
2026-10-05 12:06 ` [PATCH v5 1/3] ARC: Emulate two-byte cmpxchg Bradley Morgan
2026-10-05 12:06   ` Bradley Morgan
2026-10-06  9:55   ` kernel test robot
2026-10-06  9:55     ` kernel test robot
2026-10-05 12:06 ` [PATCH v5 2/3] csky: " Bradley Morgan
2026-10-05 12:06   ` Bradley Morgan
2026-10-05 12:07 ` Bradley Morgan [this message]
2026-10-05 12:07   ` [PATCH v5 3/3] xtensa: " Bradley Morgan
2026-10-06  9:54   ` kernel test robot
2026-10-06  9:54     ` kernel test robot
2026-10-06 15:44     ` Paul E. McKenney
2026-10-06 15:44       ` Paul E. McKenney
2026-10-06 15:46       ` Bradley Morgan
2026-10-06 15:46         ` Bradley Morgan
2026-10-06 16:10         ` Paul E. McKenney
2026-10-06 16:10           ` Paul E. McKenney
2026-10-07  8:26         ` Vineet Gupta
2026-10-07  8:26           ` Vineet Gupta
2026-10-07  8:24       ` Vineet Gupta
2026-10-07  8:24         ` Vineet Gupta
2026-10-07 15:56         ` Paul E. McKenney
2026-10-07 15:56           ` Paul E. McKenney
2026-10-05 12:19 ` [PATCH v5 0/3] Add two-byte cmpxchg emulation and wire it into the architectures Bradley Morgan
2026-10-05 12:19   ` Bradley Morgan
2026-10-05 18:02 ` David Laight
2026-10-05 18:02   ` David Laight
2026-10-06 18:16   ` Paul E. McKenney
2026-10-06 18:16     ` Paul E. McKenney
2026-10-06 21:25     ` David Laight
2026-10-06 21:25       ` David Laight
2026-10-06 18:31 ` Paul E. McKenney
2026-10-06 18:31   ` Paul E. McKenney
  -- strict thread matches above, loose matches on Subject: below --
2026-10-05 12:05 Bradley Morgan
2026-10-05 12:05 ` [PATCH v5 3/3] xtensa: Emulate two-byte cmpxchg Bradley Morgan
2026-10-05 12:05   ` Bradley Morgan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261005120700.383058-4-brads@mainlining.org \
    --to=brads@mainlining.org \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=chris@zankel.net \
    --cc=dalias@libc.org \
    --cc=david.laight.linux@gmail.com \
    --cc=glaubitz@physik.fu-berlin.de \
    --cc=guoren@kernel.org \
    --cc=jcmvbkbc@gmail.com \
    --cc=linux-csky@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-snps-arc@lists.infradead.org \
    --cc=paulmck@kernel.org \
    --cc=vgupta@kernel.org \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.