Re: [PATCH v7 3/8] Bluetooth: hci_qca: Set 'bt_en_available' based on pwrseq power controllability

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] bluetooth: hci_qca: missing error check for pwrseq_enable() in probe
--

commit 842e42b3b693b54c6eab8132c98045df38fc5343
Author: Loic Poulain <loic.poulain@oss.qualcomm.com>

Bluetooth: hci_qca: Set 'bt_en_available' based on pwrseq power controllability

This commit updates the driver to query pwrseq_is_controllable() when Bluetooth
power comes from a sequencer. If the power is not controllable, it clears
bt_en_available so that the non-persistent setup quirk is not set and treats
the device as always-on.

> diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
> index f53f95601693d..20d8c5e890a89 100644
> --- a/drivers/bluetooth/hci_qca.c
> +++ b/drivers/bluetooth/hci_qca.c
> @@ -2557,7 +2557,20 @@ static int qca_serdev_probe(struct serdev_device *serdev)
>  			return PTR_ERR(qcadev->susclk);
>  		}
>  	}
> -	
> +
> +	if (qcadev->bt_power->pwrseq) {
> +		bt_en_available = pwrseq_is_controllable(qcadev->bt_power->pwrseq);
> +		if (!bt_en_available) {
> +			/* The host cannot gate the BT power individually.
> +			 * Treat it as always-on and drop the pwrseq handle.
> +			 * The descriptor itself is still released by devres,
> +			 * so dropping the handle here is not a leak.
> +			 */
> +			pwrseq_power_on(qcadev->bt_power->pwrseq);

[Severity: High]
Does this code need to check the return value of pwrseq_power_on()?

If powering on the Bluetooth hardware fails, the driver incorrectly continues
probing and returns success. This leads to silent hardware initialization
failures and downstream communication timeouts when the host attempts to
interact with the unpowered controller.

Note: The undefined function typo (pwrseq_power_on) present in this patch
is fixed in a subsequent patch in this series (commit 'Bluetooth: hci_qca:
Flatten struct qca_power into struct qca_serdev'), but the missing error
check for the corrected pwrseq_enable() call remains unfixed in the final
state of the series.

> +			qcadev->bt_power->pwrseq = NULL;
> +		}
> +	}
> +
>  	err = hci_uart_register_device(&qcadev->serdev_hu, &qca_proto);

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261005-monza-wireless-v7-0-5a6de7662dcb@oss.qualcomm.com?part=3