* [PATCH] platform/x86: thinkpad_acpi: Use bool for local is_thinkpad variable
@ 2026-10-05 16:31 Thorsten Blum
2026-10-06 12:33 ` Mark Pearson
2026-10-12 15:56 ` Ilpo Järvinen
0 siblings, 2 replies; 3+ messages in thread
From: Thorsten Blum @ 2026-10-05 16:31 UTC (permalink / raw)
To: Mark Pearson, Derek J. Clark, Henrique de Moraes Holschuh,
Hans de Goede, Ilpo Järvinen
Cc: Thorsten Blum, ibm-acpi-devel, platform-driver-x86, linux-kernel
Use bool for the local is_thinkpad variable because it only stores a
boolean value.
Signed-off-by: Thorsten Blum <blum@kernel.org>
---
drivers/platform/x86/lenovo/thinkpad_acpi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/lenovo/thinkpad_acpi.c b/drivers/platform/x86/lenovo/thinkpad_acpi.c
index 1661f070c571..1082c36ae723 100644
--- a/drivers/platform/x86/lenovo/thinkpad_acpi.c
+++ b/drivers/platform/x86/lenovo/thinkpad_acpi.c
@@ -11925,7 +11925,7 @@ static int __must_check __init get_thinkpad_model_data(
static int __init probe_for_thinkpad(void)
{
- int is_thinkpad;
+ bool is_thinkpad;
if (acpi_disabled)
return -ENODEV;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] platform/x86: thinkpad_acpi: Use bool for local is_thinkpad variable
2026-10-05 16:31 [PATCH] platform/x86: thinkpad_acpi: Use bool for local is_thinkpad variable Thorsten Blum
@ 2026-10-06 12:33 ` Mark Pearson
2026-10-12 15:56 ` Ilpo Järvinen
1 sibling, 0 replies; 3+ messages in thread
From: Mark Pearson @ 2026-10-06 12:33 UTC (permalink / raw)
To: Thorsten Blum, Derek J . Clark, Henrique de Moraes Holschuh,
Hans de Goede, Ilpo Järvinen
Cc: ibm-acpi-devel, platform-driver-x86@vger.kernel.org, linux-kernel
On Mon, Oct 5, 2026, at 12:31 PM, Thorsten Blum wrote:
> Use bool for the local is_thinkpad variable because it only stores a
> boolean value.
>
> Signed-off-by: Thorsten Blum <blum@kernel.org>
> ---
> drivers/platform/x86/lenovo/thinkpad_acpi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/lenovo/thinkpad_acpi.c
> b/drivers/platform/x86/lenovo/thinkpad_acpi.c
> index 1661f070c571..1082c36ae723 100644
> --- a/drivers/platform/x86/lenovo/thinkpad_acpi.c
> +++ b/drivers/platform/x86/lenovo/thinkpad_acpi.c
> @@ -11925,7 +11925,7 @@ static int __must_check __init
> get_thinkpad_model_data(
>
> static int __init probe_for_thinkpad(void)
> {
> - int is_thinkpad;
> + bool is_thinkpad;
>
> if (acpi_disabled)
> return -ENODEV;
Reviewed-by: Mark Pearson <mpearson-lenovo@squebb.ca>
Mark
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] platform/x86: thinkpad_acpi: Use bool for local is_thinkpad variable
2026-10-05 16:31 [PATCH] platform/x86: thinkpad_acpi: Use bool for local is_thinkpad variable Thorsten Blum
2026-10-06 12:33 ` Mark Pearson
@ 2026-10-12 15:56 ` Ilpo Järvinen
1 sibling, 0 replies; 3+ messages in thread
From: Ilpo Järvinen @ 2026-10-12 15:56 UTC (permalink / raw)
To: Mark Pearson, Derek J. Clark, Henrique de Moraes Holschuh,
Hans de Goede, Thorsten Blum
Cc: ibm-acpi-devel, platform-driver-x86, linux-kernel
On Mon, 05 Oct 2026 18:31:31 +0200, Thorsten Blum wrote:
> Use bool for the local is_thinkpad variable because it only stores a
> boolean value.
Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.
FYI [if applicable to your patch], as per Linus' policy change, also
fixes are mostly routed through for-next unless the fix is for a
commit introduced in the most recent cycle or is clearly a regression
fix.
The list of commits applied:
[1/1] platform/x86: thinkpad_acpi: Use bool for local is_thinkpad variable
commit: acf32e5497af0bfaaa68b30cecab18aaea56a31b
--
i.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-10-12 15:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-05 16:31 [PATCH] platform/x86: thinkpad_acpi: Use bool for local is_thinkpad variable Thorsten Blum
2026-10-06 12:33 ` Mark Pearson
2026-10-12 15:56 ` Ilpo Järvinen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.