All of lore.kernel.org
 help / color / mirror / Atom feed
* drivers/platform/x86/toshiba_acpi.c:3573 toshiba_acpi_probe() warn: '&dev->miscdev' from misc_register() not released on lines: 3573.
@ 2026-06-24  4:18 kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2026-06-24  4:18 UTC (permalink / raw)
  To: oe-kbuild; +Cc: lkp, Dan Carpenter

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: "Rafael J. Wysocki" <rjw@rjwysocki.net>
CC: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   840ef6c78e6a2f694b578ecb9063241c992aaa9e
commit: 246d6cefe525f3fc760017e717bd77a3e751a260 platform/x86: toshiba_acpi: Convert ACPI driver to a platform one
date:   3 months ago
:::::: branch date: 3 hours ago
:::::: commit date: 3 months ago
config: i386-randconfig-r073-20260624 (https://download.01.org/0day-ci/archive/20260624/202606241215.qZRNUUem-lkp@intel.com/config)
compiler: clang version 22.1.3 (https://github.com/llvm/llvm-project e9846648fd6183ee6d8cbdb4502213fcf902a211)
smatch: v0.5.0-9185-gbcc58b9c

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Fixes: 246d6cefe525 ("platform/x86: toshiba_acpi: Convert ACPI driver to a platform one")
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202606241215.qZRNUUem-lkp@intel.com/

New smatch warnings:
drivers/platform/x86/toshiba_acpi.c:3573 toshiba_acpi_probe() warn: '&dev->miscdev' from misc_register() not released on lines: 3573.

Old smatch warnings:
drivers/platform/x86/toshiba_acpi.c:2707 toshiba_acpi_setup_wwan_rfkill() warn: 'dev->wwan_rfk' is an error pointer or valid

vim +3573 drivers/platform/x86/toshiba_acpi.c

c727ba4cd95a12 drivers/platform/x86/toshiba_acpi.c Arvid Norlander   2022-09-02  3532  
6873f46a630c48 drivers/platform/x86/toshiba_acpi.c Azael Avalos      2015-11-23  3533  	toshiba_wwan_available(dev);
2fdde83443aa84 drivers/platform/x86/toshiba_acpi.c Azael Avalos      2015-11-23  3534  	if (dev->wwan_supported)
2fdde83443aa84 drivers/platform/x86/toshiba_acpi.c Azael Avalos      2015-11-23  3535  		toshiba_acpi_setup_wwan_rfkill(dev);
6873f46a630c48 drivers/platform/x86/toshiba_acpi.c Azael Avalos      2015-11-23  3536  
763ff32f19442b drivers/platform/x86/toshiba_acpi.c Azael Avalos      2016-01-25  3537  	toshiba_cooling_method_available(dev);
763ff32f19442b drivers/platform/x86/toshiba_acpi.c Azael Avalos      2016-01-25  3538  
89655fbb396aff drivers/platform/x86/toshiba_acpi.c Arvid Norlander   2022-09-02  3539  	toshiba_battery_charge_mode_available(dev);
89655fbb396aff drivers/platform/x86/toshiba_acpi.c Arvid Norlander   2022-09-02  3540  
0409cbced3c9ab drivers/platform/x86/toshiba_acpi.c Azael Avalos      2015-07-31  3541  	print_supported_features(dev);
0409cbced3c9ab drivers/platform/x86/toshiba_acpi.c Azael Avalos      2015-07-31  3542  
360f0f39d0c584 drivers/platform/x86/toshiba_acpi.c Azael Avalos      2014-03-25  3543  	ret = sysfs_create_group(&dev->acpi_dev->dev.kobj,
360f0f39d0c584 drivers/platform/x86/toshiba_acpi.c Azael Avalos      2014-03-25  3544  				 &toshiba_attr_group);
360f0f39d0c584 drivers/platform/x86/toshiba_acpi.c Azael Avalos      2014-03-25  3545  	if (ret) {
360f0f39d0c584 drivers/platform/x86/toshiba_acpi.c Azael Avalos      2014-03-25  3546  		dev->sysfs_created = 0;
360f0f39d0c584 drivers/platform/x86/toshiba_acpi.c Azael Avalos      2014-03-25  3547  		goto error;
360f0f39d0c584 drivers/platform/x86/toshiba_acpi.c Azael Avalos      2014-03-25  3548  	}
360f0f39d0c584 drivers/platform/x86/toshiba_acpi.c Azael Avalos      2014-03-25  3549  	dev->sysfs_created = !ret;
360f0f39d0c584 drivers/platform/x86/toshiba_acpi.c Azael Avalos      2014-03-25  3550  
b0bcf48c74cc7f drivers/platform/x86/toshiba_acpi.c Rafael J. Wysocki 2026-03-24  3551  	ret = acpi_dev_install_notify_handler(acpi_dev, ACPI_DEVICE_NOTIFY,
b0bcf48c74cc7f drivers/platform/x86/toshiba_acpi.c Rafael J. Wysocki 2026-03-24  3552  					      toshiba_acpi_notify, dev);
b0bcf48c74cc7f drivers/platform/x86/toshiba_acpi.c Rafael J. Wysocki 2026-03-24  3553  	if (ret)
b0bcf48c74cc7f drivers/platform/x86/toshiba_acpi.c Rafael J. Wysocki 2026-03-24  3554  		goto error;
b0bcf48c74cc7f drivers/platform/x86/toshiba_acpi.c Rafael J. Wysocki 2026-03-24  3555  
b0bcf48c74cc7f drivers/platform/x86/toshiba_acpi.c Rafael J. Wysocki 2026-03-24  3556  	dev->notify_handler_installed = 1;
b0bcf48c74cc7f drivers/platform/x86/toshiba_acpi.c Rafael J. Wysocki 2026-03-24  3557  
36d03f93558c66 drivers/platform/x86/toshiba_acpi.c Seth Forshee      2011-09-20  3558  	create_toshiba_proc_entries(dev);
36d03f93558c66 drivers/platform/x86/toshiba_acpi.c Seth Forshee      2011-09-20  3559  
29cd293f9f8cd7 drivers/platform/x86/toshiba_acpi.c Seth Forshee      2012-01-18  3560  	toshiba_acpi = dev;
29cd293f9f8cd7 drivers/platform/x86/toshiba_acpi.c Seth Forshee      2012-01-18  3561  
8ef5db9eb084f6 drivers/platform/x86/toshiba_acpi.c Arvid Norlander   2022-09-02  3562  	/*
8ef5db9eb084f6 drivers/platform/x86/toshiba_acpi.c Arvid Norlander   2022-09-02  3563  	 * As the battery hook relies on the static variable toshiba_acpi being
8ef5db9eb084f6 drivers/platform/x86/toshiba_acpi.c Arvid Norlander   2022-09-02  3564  	 * set, this must be done after toshiba_acpi is assigned.
8ef5db9eb084f6 drivers/platform/x86/toshiba_acpi.c Arvid Norlander   2022-09-02  3565  	 */
8ef5db9eb084f6 drivers/platform/x86/toshiba_acpi.c Arvid Norlander   2022-09-02  3566  	if (dev->battery_charge_mode_supported)
8ef5db9eb084f6 drivers/platform/x86/toshiba_acpi.c Arvid Norlander   2022-09-02  3567  		battery_hook_register(&battery_hook);
8ef5db9eb084f6 drivers/platform/x86/toshiba_acpi.c Arvid Norlander   2022-09-02  3568  
c41a40c58b623f drivers/acpi/toshiba_acpi.c         philipl@overt.org 2008-08-30  3569  	return 0;
135740de77641b drivers/platform/x86/toshiba_acpi.c Seth Forshee      2011-09-20  3570  
135740de77641b drivers/platform/x86/toshiba_acpi.c Seth Forshee      2011-09-20  3571  error:
246d6cefe525f3 drivers/platform/x86/toshiba_acpi.c Rafael J. Wysocki 2026-03-24  3572  	toshiba_acpi_remove(pdev);
135740de77641b drivers/platform/x86/toshiba_acpi.c Seth Forshee      2011-09-20 @3573  	return ret;
135740de77641b drivers/platform/x86/toshiba_acpi.c Seth Forshee      2011-09-20  3574  }
135740de77641b drivers/platform/x86/toshiba_acpi.c Seth Forshee      2011-09-20  3575  

:::::: The code at line 3573 was first introduced by commit
:::::: 135740de77641b4180c8a1f19abcfcd5e4351b15 toshiba_acpi: Convert to use acpi_driver

:::::: TO: Seth Forshee <seth.forshee@canonical.com>
:::::: CC: Matthew Garrett <mjg@redhat.com>

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 2+ messages in thread

* drivers/platform/x86/toshiba_acpi.c:3573 toshiba_acpi_probe() warn: '&dev->miscdev' from misc_register() not released on lines: 3573.
@ 2026-10-05 14:50 kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2026-10-05 14:50 UTC (permalink / raw)
  To: oe-kbuild; +Cc: lkp, Dan Carpenter

Unfiltered warning: this smatch report is sent as-is and has not been
reviewed for false positives, so please treat it with due skepticism.

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: "Rafael J. Wysocki" <rjw@rjwysocki.net>
CC: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   a90ee4305c4a5df72c11b31dacfdc76e00fcf78a
commit: 246d6cefe525f3fc760017e717bd77a3e751a260 platform/x86: toshiba_acpi: Convert ACPI driver to a platform one
date:   6 months ago
:::::: branch date: 18 hours ago
:::::: commit date: 6 months ago
config: i386-randconfig-r2202-20261005 (https://download.01.org/0day-ci/archive/20261005/202610051641.0nM1If4b-lkp@intel.com/config)
compiler: clang version 22.1.8 (https://github.com/llvm/llvm-project ca7933e47d3a3451d81e72ac174dcb5aa28b59d1)
smatch: v0.5.0-9187-g5189e3fb

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Fixes: 246d6cefe525 ("platform/x86: toshiba_acpi: Convert ACPI driver to a platform one")
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202610051641.0nM1If4b-lkp@intel.com/

New smatch warnings:
drivers/platform/x86/toshiba_acpi.c:3573 toshiba_acpi_probe() warn: '&dev->miscdev' from misc_register() not released on lines: 3573.

Old smatch warnings:
drivers/platform/x86/toshiba_acpi.c:2707 toshiba_acpi_setup_wwan_rfkill() warn: 'dev->wwan_rfk' is an error pointer or valid

vim +3573 drivers/platform/x86/toshiba_acpi.c

c727ba4cd95a12 drivers/platform/x86/toshiba_acpi.c Arvid Norlander   2022-09-02  3532  
6873f46a630c48 drivers/platform/x86/toshiba_acpi.c Azael Avalos      2015-11-23  3533  	toshiba_wwan_available(dev);
2fdde83443aa84 drivers/platform/x86/toshiba_acpi.c Azael Avalos      2015-11-23  3534  	if (dev->wwan_supported)
2fdde83443aa84 drivers/platform/x86/toshiba_acpi.c Azael Avalos      2015-11-23  3535  		toshiba_acpi_setup_wwan_rfkill(dev);
6873f46a630c48 drivers/platform/x86/toshiba_acpi.c Azael Avalos      2015-11-23  3536  
763ff32f19442b drivers/platform/x86/toshiba_acpi.c Azael Avalos      2016-01-25  3537  	toshiba_cooling_method_available(dev);
763ff32f19442b drivers/platform/x86/toshiba_acpi.c Azael Avalos      2016-01-25  3538  
89655fbb396aff drivers/platform/x86/toshiba_acpi.c Arvid Norlander   2022-09-02  3539  	toshiba_battery_charge_mode_available(dev);
89655fbb396aff drivers/platform/x86/toshiba_acpi.c Arvid Norlander   2022-09-02  3540  
0409cbced3c9ab drivers/platform/x86/toshiba_acpi.c Azael Avalos      2015-07-31  3541  	print_supported_features(dev);
0409cbced3c9ab drivers/platform/x86/toshiba_acpi.c Azael Avalos      2015-07-31  3542  
360f0f39d0c584 drivers/platform/x86/toshiba_acpi.c Azael Avalos      2014-03-25  3543  	ret = sysfs_create_group(&dev->acpi_dev->dev.kobj,
360f0f39d0c584 drivers/platform/x86/toshiba_acpi.c Azael Avalos      2014-03-25  3544  				 &toshiba_attr_group);
360f0f39d0c584 drivers/platform/x86/toshiba_acpi.c Azael Avalos      2014-03-25  3545  	if (ret) {
360f0f39d0c584 drivers/platform/x86/toshiba_acpi.c Azael Avalos      2014-03-25  3546  		dev->sysfs_created = 0;
360f0f39d0c584 drivers/platform/x86/toshiba_acpi.c Azael Avalos      2014-03-25  3547  		goto error;
360f0f39d0c584 drivers/platform/x86/toshiba_acpi.c Azael Avalos      2014-03-25  3548  	}
360f0f39d0c584 drivers/platform/x86/toshiba_acpi.c Azael Avalos      2014-03-25  3549  	dev->sysfs_created = !ret;
360f0f39d0c584 drivers/platform/x86/toshiba_acpi.c Azael Avalos      2014-03-25  3550  
b0bcf48c74cc7f drivers/platform/x86/toshiba_acpi.c Rafael J. Wysocki 2026-03-24  3551  	ret = acpi_dev_install_notify_handler(acpi_dev, ACPI_DEVICE_NOTIFY,
b0bcf48c74cc7f drivers/platform/x86/toshiba_acpi.c Rafael J. Wysocki 2026-03-24  3552  					      toshiba_acpi_notify, dev);
b0bcf48c74cc7f drivers/platform/x86/toshiba_acpi.c Rafael J. Wysocki 2026-03-24  3553  	if (ret)
b0bcf48c74cc7f drivers/platform/x86/toshiba_acpi.c Rafael J. Wysocki 2026-03-24  3554  		goto error;
b0bcf48c74cc7f drivers/platform/x86/toshiba_acpi.c Rafael J. Wysocki 2026-03-24  3555  
b0bcf48c74cc7f drivers/platform/x86/toshiba_acpi.c Rafael J. Wysocki 2026-03-24  3556  	dev->notify_handler_installed = 1;
b0bcf48c74cc7f drivers/platform/x86/toshiba_acpi.c Rafael J. Wysocki 2026-03-24  3557  
36d03f93558c66 drivers/platform/x86/toshiba_acpi.c Seth Forshee      2011-09-20  3558  	create_toshiba_proc_entries(dev);
36d03f93558c66 drivers/platform/x86/toshiba_acpi.c Seth Forshee      2011-09-20  3559  
29cd293f9f8cd7 drivers/platform/x86/toshiba_acpi.c Seth Forshee      2012-01-18  3560  	toshiba_acpi = dev;
29cd293f9f8cd7 drivers/platform/x86/toshiba_acpi.c Seth Forshee      2012-01-18  3561  
8ef5db9eb084f6 drivers/platform/x86/toshiba_acpi.c Arvid Norlander   2022-09-02  3562  	/*
8ef5db9eb084f6 drivers/platform/x86/toshiba_acpi.c Arvid Norlander   2022-09-02  3563  	 * As the battery hook relies on the static variable toshiba_acpi being
8ef5db9eb084f6 drivers/platform/x86/toshiba_acpi.c Arvid Norlander   2022-09-02  3564  	 * set, this must be done after toshiba_acpi is assigned.
8ef5db9eb084f6 drivers/platform/x86/toshiba_acpi.c Arvid Norlander   2022-09-02  3565  	 */
8ef5db9eb084f6 drivers/platform/x86/toshiba_acpi.c Arvid Norlander   2022-09-02  3566  	if (dev->battery_charge_mode_supported)
8ef5db9eb084f6 drivers/platform/x86/toshiba_acpi.c Arvid Norlander   2022-09-02  3567  		battery_hook_register(&battery_hook);
8ef5db9eb084f6 drivers/platform/x86/toshiba_acpi.c Arvid Norlander   2022-09-02  3568  
c41a40c58b623f drivers/acpi/toshiba_acpi.c         philipl@overt.org 2008-08-30  3569  	return 0;
135740de77641b drivers/platform/x86/toshiba_acpi.c Seth Forshee      2011-09-20  3570  
135740de77641b drivers/platform/x86/toshiba_acpi.c Seth Forshee      2011-09-20  3571  error:
246d6cefe525f3 drivers/platform/x86/toshiba_acpi.c Rafael J. Wysocki 2026-03-24  3572  	toshiba_acpi_remove(pdev);
135740de77641b drivers/platform/x86/toshiba_acpi.c Seth Forshee      2011-09-20 @3573  	return ret;
135740de77641b drivers/platform/x86/toshiba_acpi.c Seth Forshee      2011-09-20  3574  }
135740de77641b drivers/platform/x86/toshiba_acpi.c Seth Forshee      2011-09-20  3575  

:::::: The code at line 3573 was first introduced by commit
:::::: 135740de77641b4180c8a1f19abcfcd5e4351b15 toshiba_acpi: Convert to use acpi_driver

:::::: TO: Seth Forshee <seth.forshee@canonical.com>
:::::: CC: Matthew Garrett <mjg@redhat.com>

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-10-05 14:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-05 14:50 drivers/platform/x86/toshiba_acpi.c:3573 toshiba_acpi_probe() warn: '&dev->miscdev' from misc_register() not released on lines: 3573 kernel test robot
  -- strict thread matches above, loose matches on Subject: below --
2026-06-24  4:18 kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.