From: kernel test robot <lkp@intel.com>
Cc: oe-kbuild-all@lists.linux.dev
Subject: Re: ACPI: Add stub for acpi_has_method() for !CONFIG_ACPI
Date: Mon, 5 Oct 2026 17:11:09 +0200 [thread overview]
Message-ID: <202610051732.mHvl7l40-lkp@intel.com> (raw)
In-Reply-To: <202610051732.mHvl7l40-lkp@intel.com>
Hi Bowen,
kernel test robot noticed the following build warnings:
url: https://github.com/intel-lab-lkp/linux/commits/Bowen-Yu/ACPI-Add-stub-for-acpi_has_method-for-CONFIG_ACPI/20260929-201347
base:
patch link: https://lore.kernel.org/r/202610051732.mHvl7l40-lkp%40intel.com
config: mips-randconfig-r2307-20261005 (https://download.01.org/0day-ci/archive/20261005/202610051732.mHvl7l40-lkp@intel.com/config)
compiler: clang version 24.0.0git (https://github.com/llvm/llvm-project 195c81658995a4b7531c30a12c5aef6cf2bbd671)
sparse: v0.6.5-rc1
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261005/202610051732.mHvl7l40-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202610051732.mHvl7l40-lkp@intel.com/
All warnings (new ones prefixed by >>):
In file included from drivers/irqchip/irq-goldfish-pic.c:12:
In file included from include/linux/irqchip.h:14:
include/linux/acpi.h:1033:20: error: redefinition of 'acpi_has_method'
1033 | static inline bool acpi_has_method(acpi_handle handle, char *name)
| ^
include/acpi/acpi_bus.h:957:20: note: previous definition is here
957 | static inline bool acpi_has_method(acpi_handle handle, char *name)
| ^
>> drivers/irqchip/irq-goldfish-pic.c:101:29: warning: shift count >= width of type [-Wshift-count-overflow]
101 | irq_setup_generic_chip(gc, IRQ_MSK(GFPIC_NR_IRQS), 0,
| ^~~~~~~~~~~~~~~~~~~~~~
include/linux/irq.h:1227:41: note: expanded from macro 'IRQ_MSK'
1227 | #define IRQ_MSK(n) (u32)((n) < 32 ? ((1 << (n)) - 1) : UINT_MAX)
| ^ ~~~
drivers/irqchip/irq-goldfish-pic.c:120:31: warning: shift count >= width of type [-Wshift-count-overflow]
120 | irq_destroy_generic_chip(gc, IRQ_MSK(GFPIC_NR_IRQS),
| ^~~~~~~~~~~~~~~~~~~~~~
include/linux/irq.h:1227:41: note: expanded from macro 'IRQ_MSK'
1227 | #define IRQ_MSK(n) (u32)((n) < 32 ? ((1 << (n)) - 1) : UINT_MAX)
| ^ ~~~
2 warnings and 1 error generated.
vim +101 drivers/irqchip/irq-goldfish-pic.c
4235ff50cf98dd Miodrag Dinic 2017-12-29 54
4235ff50cf98dd Miodrag Dinic 2017-12-29 55 static int __init goldfish_pic_of_init(struct device_node *of_node,
4235ff50cf98dd Miodrag Dinic 2017-12-29 56 struct device_node *parent)
4235ff50cf98dd Miodrag Dinic 2017-12-29 57 {
4235ff50cf98dd Miodrag Dinic 2017-12-29 58 struct goldfish_pic_data *gfpic;
4235ff50cf98dd Miodrag Dinic 2017-12-29 59 struct irq_chip_generic *gc;
4235ff50cf98dd Miodrag Dinic 2017-12-29 60 struct irq_chip_type *ct;
4235ff50cf98dd Miodrag Dinic 2017-12-29 61 unsigned int parent_irq;
4235ff50cf98dd Miodrag Dinic 2017-12-29 62 int ret = 0;
4235ff50cf98dd Miodrag Dinic 2017-12-29 63
bf4afc53b77aea Linus Torvalds 2026-02-21 64 gfpic = kzalloc_obj(*gfpic);
4235ff50cf98dd Miodrag Dinic 2017-12-29 65 if (!gfpic) {
4235ff50cf98dd Miodrag Dinic 2017-12-29 66 ret = -ENOMEM;
4235ff50cf98dd Miodrag Dinic 2017-12-29 67 goto out_err;
4235ff50cf98dd Miodrag Dinic 2017-12-29 68 }
4235ff50cf98dd Miodrag Dinic 2017-12-29 69
4235ff50cf98dd Miodrag Dinic 2017-12-29 70 parent_irq = irq_of_parse_and_map(of_node, 0);
4235ff50cf98dd Miodrag Dinic 2017-12-29 71 if (!parent_irq) {
4235ff50cf98dd Miodrag Dinic 2017-12-29 72 pr_err("Failed to map parent IRQ!\n");
4235ff50cf98dd Miodrag Dinic 2017-12-29 73 ret = -EINVAL;
4235ff50cf98dd Miodrag Dinic 2017-12-29 74 goto out_free;
4235ff50cf98dd Miodrag Dinic 2017-12-29 75 }
4235ff50cf98dd Miodrag Dinic 2017-12-29 76
4235ff50cf98dd Miodrag Dinic 2017-12-29 77 gfpic->base = of_iomap(of_node, 0);
4235ff50cf98dd Miodrag Dinic 2017-12-29 78 if (!gfpic->base) {
4235ff50cf98dd Miodrag Dinic 2017-12-29 79 pr_err("Failed to map base address!\n");
4235ff50cf98dd Miodrag Dinic 2017-12-29 80 ret = -ENOMEM;
4235ff50cf98dd Miodrag Dinic 2017-12-29 81 goto out_unmap_irq;
4235ff50cf98dd Miodrag Dinic 2017-12-29 82 }
4235ff50cf98dd Miodrag Dinic 2017-12-29 83
4235ff50cf98dd Miodrag Dinic 2017-12-29 84 /* Mask interrupts. */
4235ff50cf98dd Miodrag Dinic 2017-12-29 85 writel(1, gfpic->base + GFPIC_REG_IRQ_DISABLE_ALL);
4235ff50cf98dd Miodrag Dinic 2017-12-29 86
4235ff50cf98dd Miodrag Dinic 2017-12-29 87 gc = irq_alloc_generic_chip("GFPIC", 1, GFPIC_IRQ_BASE, gfpic->base,
4235ff50cf98dd Miodrag Dinic 2017-12-29 88 handle_level_irq);
4235ff50cf98dd Miodrag Dinic 2017-12-29 89 if (!gc) {
4235ff50cf98dd Miodrag Dinic 2017-12-29 90 pr_err("Failed to allocate chip structures!\n");
4235ff50cf98dd Miodrag Dinic 2017-12-29 91 ret = -ENOMEM;
4235ff50cf98dd Miodrag Dinic 2017-12-29 92 goto out_iounmap;
4235ff50cf98dd Miodrag Dinic 2017-12-29 93 }
4235ff50cf98dd Miodrag Dinic 2017-12-29 94
4235ff50cf98dd Miodrag Dinic 2017-12-29 95 ct = gc->chip_types;
4235ff50cf98dd Miodrag Dinic 2017-12-29 96 ct->regs.enable = GFPIC_REG_IRQ_ENABLE;
4235ff50cf98dd Miodrag Dinic 2017-12-29 97 ct->regs.disable = GFPIC_REG_IRQ_DISABLE;
4235ff50cf98dd Miodrag Dinic 2017-12-29 98 ct->chip.irq_unmask = irq_gc_unmask_enable_reg;
4235ff50cf98dd Miodrag Dinic 2017-12-29 99 ct->chip.irq_mask = irq_gc_mask_disable_reg;
4235ff50cf98dd Miodrag Dinic 2017-12-29 100
4235ff50cf98dd Miodrag Dinic 2017-12-29 @101 irq_setup_generic_chip(gc, IRQ_MSK(GFPIC_NR_IRQS), 0,
4235ff50cf98dd Miodrag Dinic 2017-12-29 102 IRQ_NOPROBE | IRQ_LEVEL, 0);
4235ff50cf98dd Miodrag Dinic 2017-12-29 103
affdc0d1bdfa54 Jiri Slaby (SUSE 2025-03-19 104) gfpic->irq_domain = irq_domain_create_legacy(of_fwnode_handle(of_node), GFPIC_NR_IRQS,
affdc0d1bdfa54 Jiri Slaby (SUSE 2025-03-19 105) GFPIC_IRQ_BASE, 0, &goldfish_irq_domain_ops,
4235ff50cf98dd Miodrag Dinic 2017-12-29 106 NULL);
4235ff50cf98dd Miodrag Dinic 2017-12-29 107 if (!gfpic->irq_domain) {
4235ff50cf98dd Miodrag Dinic 2017-12-29 108 pr_err("Failed to add irqdomain!\n");
4235ff50cf98dd Miodrag Dinic 2017-12-29 109 ret = -ENOMEM;
4235ff50cf98dd Miodrag Dinic 2017-12-29 110 goto out_destroy_generic_chip;
4235ff50cf98dd Miodrag Dinic 2017-12-29 111 }
4235ff50cf98dd Miodrag Dinic 2017-12-29 112
4235ff50cf98dd Miodrag Dinic 2017-12-29 113 irq_set_chained_handler_and_data(parent_irq,
4235ff50cf98dd Miodrag Dinic 2017-12-29 114 goldfish_pic_cascade, gfpic);
4235ff50cf98dd Miodrag Dinic 2017-12-29 115
4235ff50cf98dd Miodrag Dinic 2017-12-29 116 pr_info("Successfully registered.\n");
4235ff50cf98dd Miodrag Dinic 2017-12-29 117 return 0;
4235ff50cf98dd Miodrag Dinic 2017-12-29 118
4235ff50cf98dd Miodrag Dinic 2017-12-29 119 out_destroy_generic_chip:
4235ff50cf98dd Miodrag Dinic 2017-12-29 120 irq_destroy_generic_chip(gc, IRQ_MSK(GFPIC_NR_IRQS),
4235ff50cf98dd Miodrag Dinic 2017-12-29 121 IRQ_NOPROBE | IRQ_LEVEL, 0);
4235ff50cf98dd Miodrag Dinic 2017-12-29 122 out_iounmap:
4235ff50cf98dd Miodrag Dinic 2017-12-29 123 iounmap(gfpic->base);
4235ff50cf98dd Miodrag Dinic 2017-12-29 124 out_unmap_irq:
4235ff50cf98dd Miodrag Dinic 2017-12-29 125 irq_dispose_mapping(parent_irq);
4235ff50cf98dd Miodrag Dinic 2017-12-29 126 out_free:
4235ff50cf98dd Miodrag Dinic 2017-12-29 127 kfree(gfpic);
4235ff50cf98dd Miodrag Dinic 2017-12-29 128 out_err:
4235ff50cf98dd Miodrag Dinic 2017-12-29 129 pr_err("Failed to initialize! (errno = %d)\n", ret);
4235ff50cf98dd Miodrag Dinic 2017-12-29 130 return ret;
4235ff50cf98dd Miodrag Dinic 2017-12-29 131 }
4235ff50cf98dd Miodrag Dinic 2017-12-29 132
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next parent reply other threads:[~2026-10-05 15:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-05 15:11 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-10-05 9:43 ACPI: Add stub for acpi_has_method() for !CONFIG_ACPI kernel test robot
2026-10-05 5:32 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202610051732.mHvl7l40-lkp@intel.com \
--to=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.