From: sashiko-bot@kernel.org
To: "Paul Sajna" <sajattack@postmarketos.org>
Cc: robh@kernel.org, lee@kernel.org, linux-leds@vger.kernel.org,
devicetree@vger.kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v2 5/7] leds: aw2013: Move assignment of chip->num_leds
Date: Tue, 06 Oct 2026 04:01:10 +0000 [thread overview]
Message-ID: <20261006040110.6BC391F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20261005-aw2013-aw20xx-rename-v2-5-108ecbdf2775@postmarketos.org>
> devm_led_classdev_register_ext() executes default triggers
> synchronously, which call aw20xx_brightness_set().
> aw20xx_chip_in_use() silently returns false, skipping chip enablement and
> causing unbalanced regulator disables while probe is still running.
>
> Increment chip->num_leds inside the loop, so that each call gets the
> correct value for it's default trigger.
>
> Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261005-aw2013-aw20xx-rename-v2-0-108ecbdf2775@postmarketos.org?part=5
next prev parent reply other threads:[~2026-10-06 4:01 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-06 3:46 [PATCH v2 0/7] leds: aw2013: Add AW2027 support Paul Sajna
2026-10-06 3:46 ` [PATCH v2 1/7] dt-bindings: leds: aw2013: Add awinic,aw2027 compatible Paul Sajna
2026-10-06 3:48 ` sashiko-bot
2026-10-07 10:30 ` Conor Dooley
2026-10-06 3:46 ` [PATCH v2 2/7] leds: aw2013: Rename internal APIs from aw2013 to aw20xx Paul Sajna
2026-10-06 3:56 ` sashiko-bot
2026-10-06 10:45 ` Griffin Kroah-Hartman
2026-10-06 18:54 ` Paul Sajna
2026-10-06 3:46 ` [PATCH v2 3/7] leds: aw2013: Add AW2027 support Paul Sajna
2026-10-06 3:56 ` sashiko-bot
2026-10-06 3:46 ` [PATCH v2 4/7] leds: aw2013: use dev_err_probe Paul Sajna
2026-10-06 3:57 ` sashiko-bot
2026-10-06 19:52 ` Griffin Kroah-Hartman
2026-10-07 7:36 ` Andreas Kemnade
2026-10-10 20:06 ` David Heidelberg
2026-10-06 3:46 ` [PATCH v2 5/7] leds: aw2013: Move assignment of chip->num_leds Paul Sajna
2026-10-06 4:01 ` sashiko-bot [this message]
2026-10-06 3:46 ` [PATCH v2 6/7] leds: aw2013: Prevent writes to unpowered chip Paul Sajna
2026-10-06 3:59 ` sashiko-bot
2026-10-06 3:46 ` [PATCH v2 7/7] leds: aw2013: move reset from probe_dt to chip_init Paul Sajna
2026-10-06 4:00 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261006040110.6BC391F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sajattack@postmarketos.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.