All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Igor Velkov" <iav@iav.lv>
Cc: linux-amlogic@lists.infradead.org, robh@kernel.org,
	conor+dt@kernel.org, devicetree@vger.kernel.org,
	neil.armstrong@linaro.org
Subject: Re: [PATCH] arm64: dts: amlogic: meson-sm1-odroid-hc4: add the fan tachometer
Date: Tue, 06 Oct 2026 04:17:33 +0000	[thread overview]
Message-ID: <20261006041733.8C4081F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20261006-hc4-fan-tach-v1-1-4e7cecf0b45b@iav.lv>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] arm64: dts: amlogic: missing pinctrl for fan tachometer interrupt
--

commit a6a97db21df93ac09c2154310040802278dbb495
Author: Igor Velkov <iav@iav.lv>

arm64: dts: amlogic: meson-sm1-odroid-hc4: add the fan tachometer

This commit adds the interrupt configuration for the fan tachometer to the
pwm-fan node on the ODROID-HC4, mapping it to GPIOX_7.

> diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts b/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts
> index 5f15c2299509b..261a42560a5e9 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts
> @@ -21,6 +21,8 @@ fan0: pwm-fan {
>  		#cooling-cells = <2>;
>  		cooling-levels = <0 120 170 220>;
>  		pwms = <&pwm_cd 1 40000 0>;
> +		interrupt-parent = <&gpio_intc>;
> +		interrupts = <IRQID_GPIOX_7 IRQ_TYPE_EDGE_FALLING>;

[Severity: Medium]
Does this configuration leave the hardware pin direction entirely dependent on
the pre-kernel bootloader state?

The pwm-fan driver requests the IRQ via devm_request_irq(), and the
meson-gpio-intc interrupt controller does not implement .irq_request_resources
to automatically mux the pin to GPIO mode.

Without an explicit pinctrl-0 property in the fan0 node, will the fan
tachometer silently fail to read the fan speed (always reporting 0) on systems
where the bootloader leaves GPIOX_7 configured as an alternate function (such
as uart_b_rx or pwm_f_x) instead of a GPIO input?

>  	};
>  
>  	leds {

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261006-hc4-fan-tach-v1-1-4e7cecf0b45b@iav.lv?part=1

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

WARNING: multiple messages have this Message-ID (diff)
From: sashiko-bot@kernel.org
To: "Igor Velkov" <iav@iav.lv>
Cc: linux-amlogic@lists.infradead.org, robh@kernel.org,
	conor+dt@kernel.org, devicetree@vger.kernel.org,
	neil.armstrong@linaro.org
Subject: Re: [PATCH] arm64: dts: amlogic: meson-sm1-odroid-hc4: add the fan tachometer
Date: Tue, 06 Oct 2026 04:17:33 +0000	[thread overview]
Message-ID: <20261006041733.8C4081F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20261006-hc4-fan-tach-v1-1-4e7cecf0b45b@iav.lv>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] arm64: dts: amlogic: missing pinctrl for fan tachometer interrupt
--

commit a6a97db21df93ac09c2154310040802278dbb495
Author: Igor Velkov <iav@iav.lv>

arm64: dts: amlogic: meson-sm1-odroid-hc4: add the fan tachometer

This commit adds the interrupt configuration for the fan tachometer to the
pwm-fan node on the ODROID-HC4, mapping it to GPIOX_7.

> diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts b/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts
> index 5f15c2299509b..261a42560a5e9 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts
> @@ -21,6 +21,8 @@ fan0: pwm-fan {
>  		#cooling-cells = <2>;
>  		cooling-levels = <0 120 170 220>;
>  		pwms = <&pwm_cd 1 40000 0>;
> +		interrupt-parent = <&gpio_intc>;
> +		interrupts = <IRQID_GPIOX_7 IRQ_TYPE_EDGE_FALLING>;

[Severity: Medium]
Does this configuration leave the hardware pin direction entirely dependent on
the pre-kernel bootloader state?

The pwm-fan driver requests the IRQ via devm_request_irq(), and the
meson-gpio-intc interrupt controller does not implement .irq_request_resources
to automatically mux the pin to GPIO mode.

Without an explicit pinctrl-0 property in the fan0 node, will the fan
tachometer silently fail to read the fan speed (always reporting 0) on systems
where the bootloader leaves GPIOX_7 configured as an alternate function (such
as uart_b_rx or pwm_f_x) instead of a GPIO input?

>  	};
>  
>  	leds {

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261006-hc4-fan-tach-v1-1-4e7cecf0b45b@iav.lv?part=1

  reply	other threads:[~2026-10-06  4:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-06  4:07 [PATCH] arm64: dts: amlogic: meson-sm1-odroid-hc4: add the fan tachometer Igor Velkov via B4 Relay
2026-10-06  4:07 ` Igor Velkov
2026-10-06  4:07 ` Igor Velkov via B4 Relay
2026-10-06  4:17 ` sashiko-bot [this message]
2026-10-06  4:17   ` sashiko-bot
2026-10-06  4:29   ` Igor Velkov
2026-10-06  4:29     ` Igor Velkov
2026-10-06 13:03     ` Neil Armstrong
2026-10-06 13:03       ` Neil Armstrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261006041733.8C4081F000FF@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=iav@iav.lv \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=neil.armstrong@linaro.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.