drivers/net/ethernet/broadcom/bnge/bnge_link.c:401:8-32: opportunity for str_on_off(( fec & BNGE_FEC_AUTONEG ))

drivers/net/ethernet/broadcom/bnge/bnge_link.c:401:8-32: opportunity for str_on_off(( fec & BNGE_FEC_AUTONEG ))

[kernel test robot]

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Bhargava Marreddy <bhargava.marreddy@broadcom.com>
CC: Jakub Kicinski <kuba@kernel.org>
CC: Vikas Gupta <vikas.gupta@broadcom.com>
CC: Rajashekar Hudumula <rajashekar.hudumula@broadcom.com>
CC: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   22430ae5d90ab288b0ee2ad99ae941f4a666b694
commit: 7626cd3d53be5249769bd2784a65bfccdce9ffaf bng_en: query PHY capabilities and report link status
date:   6 months ago
:::::: branch date: 5 hours ago
:::::: commit date: 6 months ago
config: powerpc64-randconfig-r2104-20261005 (https://download.01.org/0day-ci/archive/20261006/202610061616.gcBpAFvk-lkp@intel.com/config)
compiler: clang version 24.0.0git (https://github.com/llvm/llvm-project 195c81658995a4b7531c30a12c5aef6cf2bbd671)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Fixes: 7626cd3d53be ("bng_en: query PHY capabilities and report link status")
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Julia Lawall <julia.lawall@inria.fr>
| Closes: https://lore.kernel.org/r/202610061616.gcBpAFvk-lkp@intel.com/

cocci warnings: (new ones prefixed by >>)
>> drivers/net/ethernet/broadcom/bnge/bnge_link.c:401:8-32: opportunity for str_on_off(( fec & BNGE_FEC_AUTONEG ))

vim +401 drivers/net/ethernet/broadcom/bnge/bnge_link.c

7626cd3d53be52 Bhargava Marreddy 2026-04-06  349  
7626cd3d53be52 Bhargava Marreddy 2026-04-06  350  void bnge_report_link(struct bnge_dev *bd)
7626cd3d53be52 Bhargava Marreddy 2026-04-06  351  {
7626cd3d53be52 Bhargava Marreddy 2026-04-06  352  	if (BNGE_LINK_IS_UP(bd)) {
7626cd3d53be52 Bhargava Marreddy 2026-04-06  353  		const char *signal = "";
7626cd3d53be52 Bhargava Marreddy 2026-04-06  354  		const char *flow_ctrl;
7626cd3d53be52 Bhargava Marreddy 2026-04-06  355  		const char *duplex;
7626cd3d53be52 Bhargava Marreddy 2026-04-06  356  		u32 speed;
7626cd3d53be52 Bhargava Marreddy 2026-04-06  357  		u16 fec;
7626cd3d53be52 Bhargava Marreddy 2026-04-06  358  
7626cd3d53be52 Bhargava Marreddy 2026-04-06  359  		netif_carrier_on(bd->netdev);
7626cd3d53be52 Bhargava Marreddy 2026-04-06  360  		speed = bnge_fw_to_ethtool_speed(bd->link_info.link_speed);
7626cd3d53be52 Bhargava Marreddy 2026-04-06  361  		if (speed == SPEED_UNKNOWN) {
7626cd3d53be52 Bhargava Marreddy 2026-04-06  362  			netdev_info(bd->netdev,
7626cd3d53be52 Bhargava Marreddy 2026-04-06  363  				    "NIC Link is Up, speed unknown\n");
7626cd3d53be52 Bhargava Marreddy 2026-04-06  364  			return;
7626cd3d53be52 Bhargava Marreddy 2026-04-06  365  		}
7626cd3d53be52 Bhargava Marreddy 2026-04-06  366  		if (bd->link_info.duplex == BNGE_LINK_DUPLEX_FULL)
7626cd3d53be52 Bhargava Marreddy 2026-04-06  367  			duplex = "full";
7626cd3d53be52 Bhargava Marreddy 2026-04-06  368  		else
7626cd3d53be52 Bhargava Marreddy 2026-04-06  369  			duplex = "half";
7626cd3d53be52 Bhargava Marreddy 2026-04-06  370  		if (bd->link_info.pause == BNGE_LINK_PAUSE_BOTH)
7626cd3d53be52 Bhargava Marreddy 2026-04-06  371  			flow_ctrl = "ON - receive & transmit";
7626cd3d53be52 Bhargava Marreddy 2026-04-06  372  		else if (bd->link_info.pause == BNGE_LINK_PAUSE_TX)
7626cd3d53be52 Bhargava Marreddy 2026-04-06  373  			flow_ctrl = "ON - transmit";
7626cd3d53be52 Bhargava Marreddy 2026-04-06  374  		else if (bd->link_info.pause == BNGE_LINK_PAUSE_RX)
7626cd3d53be52 Bhargava Marreddy 2026-04-06  375  			flow_ctrl = "ON - receive";
7626cd3d53be52 Bhargava Marreddy 2026-04-06  376  		else
7626cd3d53be52 Bhargava Marreddy 2026-04-06  377  			flow_ctrl = "none";
7626cd3d53be52 Bhargava Marreddy 2026-04-06  378  		if (bd->link_info.phy_qcfg_resp.option_flags &
7626cd3d53be52 Bhargava Marreddy 2026-04-06  379  		    PORT_PHY_QCFG_RESP_OPTION_FLAGS_SIGNAL_MODE_KNOWN) {
7626cd3d53be52 Bhargava Marreddy 2026-04-06  380  			u8 sig_mode = bd->link_info.active_fec_sig_mode &
7626cd3d53be52 Bhargava Marreddy 2026-04-06  381  				      PORT_PHY_QCFG_RESP_SIGNAL_MODE_MASK;
7626cd3d53be52 Bhargava Marreddy 2026-04-06  382  			switch (sig_mode) {
7626cd3d53be52 Bhargava Marreddy 2026-04-06  383  			case PORT_PHY_QCFG_RESP_SIGNAL_MODE_NRZ:
7626cd3d53be52 Bhargava Marreddy 2026-04-06  384  				signal = "(NRZ) ";
7626cd3d53be52 Bhargava Marreddy 2026-04-06  385  				break;
7626cd3d53be52 Bhargava Marreddy 2026-04-06  386  			case PORT_PHY_QCFG_RESP_SIGNAL_MODE_PAM4:
7626cd3d53be52 Bhargava Marreddy 2026-04-06  387  				signal = "(PAM4 56Gbps) ";
7626cd3d53be52 Bhargava Marreddy 2026-04-06  388  				break;
7626cd3d53be52 Bhargava Marreddy 2026-04-06  389  			case PORT_PHY_QCFG_RESP_SIGNAL_MODE_PAM4_112:
7626cd3d53be52 Bhargava Marreddy 2026-04-06  390  				signal = "(PAM4 112Gbps) ";
7626cd3d53be52 Bhargava Marreddy 2026-04-06  391  				break;
7626cd3d53be52 Bhargava Marreddy 2026-04-06  392  			default:
7626cd3d53be52 Bhargava Marreddy 2026-04-06  393  				break;
7626cd3d53be52 Bhargava Marreddy 2026-04-06  394  			}
7626cd3d53be52 Bhargava Marreddy 2026-04-06  395  		}
7626cd3d53be52 Bhargava Marreddy 2026-04-06  396  		netdev_info(bd->netdev, "NIC Link is Up, %u Mbps %s%s duplex, Flow control: %s\n",
7626cd3d53be52 Bhargava Marreddy 2026-04-06  397  			    speed, signal, duplex, flow_ctrl);
7626cd3d53be52 Bhargava Marreddy 2026-04-06  398  		fec = bd->link_info.fec_cfg;
7626cd3d53be52 Bhargava Marreddy 2026-04-06  399  		if (!(fec & PORT_PHY_QCFG_RESP_FEC_CFG_FEC_NONE_SUPPORTED))
7626cd3d53be52 Bhargava Marreddy 2026-04-06  400  			netdev_info(bd->netdev, "FEC autoneg %s encoding: %s\n",
7626cd3d53be52 Bhargava Marreddy 2026-04-06 @401  				    (fec & BNGE_FEC_AUTONEG) ? "on" : "off",

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki